All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Replace magic numbers by constants
Date: Sun, 17 Aug 2008 16:12:02 +0200	[thread overview]
Message-ID: <877iaf20jx.fsf@xs4all.nl> (raw)
In-Reply-To: <20080817130119.GA22343@pina.cat> (Carles Pina i. Estany's message of "Sun, 17 Aug 2008 15:01:19 +0200")

Hi,

Carles Pina i Estany <carles@pina.cat> writes:

> When I did the Home/End keys patch I noticied that in normal/menu.c
> there was some magic numbers (and some constants was already defined, in
> include/grub/term.h (actually, reading the ChangeLog was committed by
> Robert Millan on 2008-02-05)
>
> I'm sending a patch to change the magic numbers by constants.
>
> ChangeLog:
> --------
> 2008-08-17  Carles Pina i Estany  <carles@pina.cat>
>
> 	* menu/normal.c (run_menu): Change magic numbers by constants.

Can you be more specific about what you replace?

Thanks,
Marco




  reply	other threads:[~2008-08-17 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-17 13:01 [PATCH] Replace magic numbers by constants Carles Pina i Estany
2008-08-17 14:12 ` Marco Gerards [this message]
2008-08-17 14:29   ` Carles Pina i Estany
2008-08-17 15:37     ` Robert Millan
2008-08-17 19:11       ` Carles Pina i Estany
2008-08-20  9:26         ` Carles Pina i Estany
2008-08-20 10:08         ` Robert Millan
2008-08-20 10:51           ` Carles Pina i Estany

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877iaf20jx.fsf@xs4all.nl \
    --to=mgerards@xs4all.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.