From: Robert Richter <robert.richter@amd.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
oprofile-list@lists.sourceforge.net, cel <cel@linux.vnet.ibm.com>,
cbe-oss-dev@ozlabs.org
Subject: Re: powerpc/cell/oprofile: avoid double free of profile buffer
Date: Tue, 19 Aug 2008 13:53:18 +0200 [thread overview]
Message-ID: <20080819115317.GD1488@erda.amd.com> (raw)
In-Reply-To: <200808110925.44243.arnd@arndb.de>
On 11.08.08 09:25:43, Arnd Bergmann wrote:
> From: Carl Love <cel@us.ibm.com>
>
> If an error occurs on opcontrol start, the event and per cpu buffers
> are released. If later opcontrol shutdown is called then the free
> function will be called again to free buffers that no longer
> exist. This results in a kernel oops. The following changes
> prevent the call to delete buffers that don't exist.
>
> Signed-off-by: Carl Love <carll@us.ibm.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Richter <robert.richter@amd.com>
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
WARNING: multiple messages have this Message-ID (diff)
From: Robert Richter <robert.richter@amd.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org,
linux-kernel <linux-kernel@vger.kernel.org>,
oprofile-list@lists.sourceforge.net,
Paul Mackerras <paulus@samba.org>, cel <cel@linux.vnet.ibm.com>
Subject: Re: powerpc/cell/oprofile: avoid double free of profile buffer
Date: Tue, 19 Aug 2008 13:53:18 +0200 [thread overview]
Message-ID: <20080819115317.GD1488@erda.amd.com> (raw)
In-Reply-To: <200808110925.44243.arnd@arndb.de>
On 11.08.08 09:25:43, Arnd Bergmann wrote:
> From: Carl Love <cel@us.ibm.com>
>
> If an error occurs on opcontrol start, the event and per cpu buffers
> are released. If later opcontrol shutdown is called then the free
> function will be called again to free buffers that no longer
> exist. This results in a kernel oops. The following changes
> prevent the call to delete buffers that don't exist.
>
> Signed-off-by: Carl Love <carll@us.ibm.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Richter <robert.richter@amd.com>
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2008-08-19 11:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 20:01 [PATCH 2/2] Cell OProfile: SPU mutex lock fix, version 4 Carl Love
2008-08-08 13:26 ` Arnd Bergmann
2008-08-08 13:26 ` Arnd Bergmann
2008-08-08 22:39 ` [PATCH 2/2] Repost " Carl Love
2008-08-09 13:13 ` please pull cell merge branch Arnd Bergmann
2008-08-09 13:13 ` Arnd Bergmann
2008-08-10 23:17 ` Paul Mackerras
2008-08-10 23:17 ` Paul Mackerras
2008-08-11 7:18 ` [Cbe-oss-dev] " Arnd Bergmann
2008-08-11 7:18 ` Arnd Bergmann
2008-08-11 7:25 ` powerpc/cell/oprofile: fix mutex locking for spu-oprofile Arnd Bergmann
2008-08-11 7:25 ` Arnd Bergmann
2008-08-20 11:57 ` Robert Richter
2008-08-20 11:57 ` Robert Richter
2008-08-20 12:05 ` Arnd Bergmann
2008-08-20 12:05 ` Arnd Bergmann
2008-08-20 12:39 ` Robert Richter
2008-08-20 12:39 ` Robert Richter
2008-08-20 14:58 ` Carl Love
2008-08-20 12:39 ` Robert Richter
2008-08-20 12:39 ` Robert Richter
2008-08-20 13:19 ` Arnd Bergmann
2008-08-20 13:19 ` Arnd Bergmann
2008-08-21 4:21 ` Paul Mackerras
2008-08-21 4:21 ` Paul Mackerras
2008-08-21 8:14 ` [Cbe-oss-dev] " Arnd Bergmann
2008-08-21 8:14 ` Arnd Bergmann
2008-08-21 10:20 ` Michael Ellerman
2008-08-21 10:20 ` Michael Ellerman
2008-08-21 14:58 ` Carl Love
2008-08-25 6:31 ` Paul Mackerras
2008-08-25 6:31 ` Paul Mackerras
2008-08-25 7:55 ` Arnd Bergmann
2008-08-25 7:55 ` Arnd Bergmann
2008-10-13 14:53 ` Arnd Bergmann
2008-10-13 14:53 ` Arnd Bergmann
2008-10-13 15:13 ` Robert Richter
2008-10-13 15:13 ` Robert Richter
2008-08-11 7:25 ` powerpc/cell/oprofile: avoid double free of profile buffer Arnd Bergmann
2008-08-11 7:25 ` Arnd Bergmann
2008-08-19 11:53 ` Robert Richter [this message]
2008-08-19 11:53 ` Robert Richter
2008-08-11 15:34 ` [Cbe-oss-dev] please pull cell merge branch Carl Love
2008-08-11 15:34 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819115317.GD1488@erda.amd.com \
--to=robert.richter@amd.com \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=cel@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.