All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: "Tomas Winkler" <tomasw@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	davem@davemloft.net, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless-2.6 2008-08-26
Date: Wed, 27 Aug 2008 22:25:09 +0200	[thread overview]
Message-ID: <200808272225.10557.mb@bu3sch.de> (raw)
In-Reply-To: <1ba2fa240808271226i95a7789k481a68b09dc60164@mail.gmail.com>

On Wednesday 27 August 2008, Tomas Winkler wrote:
> > John W. Linville (1):
> >      mac80211: quiet chatty IBSS merge message
> 
> This patch is correct yet it suppresses an important warning, meaning
> that you have constant IBSS reconnection, remove all connected station
> and adding them again, This greatly degraded performance. This is
> caused by inability to adjust to TSF of the IBSS leader
> 
> <snipt>
> static int ieee80211_sta_join_ibss(struct net_device *dev,
> 				   struct ieee80211_if_sta *ifsta,
> 				   struct ieee80211_sta_bss *bss)
> .....
> /* Remove possible STA entries from other IBSS networks. */
> 	sta_info_flush_delayed(sdata);
> </snip>

I fail to see how the TSF could be related to an ever reconnecting
station. Can you elaborate on what happens?

I was under the impression that the firmware would handle TSF stuff.
Also the "IBSS leader" is a new thing to me. I remember from the specs
that the device should accept the TSF from _any_ beacon. Not just a
"leader". Am I mislead? :)

I also fail to see how we could _ever_ set the TSF to something remotely
correct from the driver because of the FIFO delay.

> 
> > Assaf Krauss (1):
> >      iwlwifi: W/A for the TSF correction in IBSS

I cannot find this patch in wireless-testing and I don't
have a copy of wireless-2.6 here. Can you send me the patch, or
explain what it does?

WARNING: multiple messages have this Message-ID (diff)
From: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
To: "Tomas Winkler" <tomasw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "John W. Linville"
	<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: pull request: wireless-2.6 2008-08-26
Date: Wed, 27 Aug 2008 22:25:09 +0200	[thread overview]
Message-ID: <200808272225.10557.mb@bu3sch.de> (raw)
In-Reply-To: <1ba2fa240808271226i95a7789k481a68b09dc60164-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wednesday 27 August 2008, Tomas Winkler wrote:
> > John W. Linville (1):
> >      mac80211: quiet chatty IBSS merge message
> 
> This patch is correct yet it suppresses an important warning, meaning
> that you have constant IBSS reconnection, remove all connected station
> and adding them again, This greatly degraded performance. This is
> caused by inability to adjust to TSF of the IBSS leader
> 
> <snipt>
> static int ieee80211_sta_join_ibss(struct net_device *dev,
> 				   struct ieee80211_if_sta *ifsta,
> 				   struct ieee80211_sta_bss *bss)
> .....
> /* Remove possible STA entries from other IBSS networks. */
> 	sta_info_flush_delayed(sdata);
> </snip>

I fail to see how the TSF could be related to an ever reconnecting
station. Can you elaborate on what happens?

I was under the impression that the firmware would handle TSF stuff.
Also the "IBSS leader" is a new thing to me. I remember from the specs
that the device should accept the TSF from _any_ beacon. Not just a
"leader". Am I mislead? :)

I also fail to see how we could _ever_ set the TSF to something remotely
correct from the driver because of the FIFO delay.

> 
> > Assaf Krauss (1):
> >      iwlwifi: W/A for the TSF correction in IBSS

I cannot find this patch in wireless-testing and I don't
have a copy of wireless-2.6 here. Can you send me the patch, or
explain what it does?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-08-27 20:25 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27  1:30 pull request: wireless-2.6 2008-08-26 John W. Linville
2008-08-27  7:38 ` Tomas Winkler
2008-08-27  7:38   ` Tomas Winkler
2008-08-27  8:40   ` David Miller
2008-08-27  8:40     ` David Miller
2008-08-27  9:13     ` Tomas Winkler
2008-08-27 11:10     ` Marcel Holtmann
2008-08-27 10:05       ` Tomas Winkler
2008-08-27 10:10         ` Johannes Berg
2008-08-27 10:33           ` David Miller
2008-08-27 10:33             ` David Miller
2008-08-27 11:34           ` Tomas Winkler
2008-08-27 11:34             ` Tomas Winkler
2008-08-27 11:45             ` David Miller
2008-08-27 12:26               ` Tomas Winkler
2008-08-27 12:26                 ` Tomas Winkler
2008-08-27 13:10             ` Michael Buesch
2008-08-27 13:10               ` Michael Buesch
2008-08-27 14:55               ` Tomas Winkler
2008-08-27 15:22                 ` Michael Buesch
2008-08-27 15:22                   ` Michael Buesch
2008-08-27 15:45                   ` Tomas Winkler
2008-08-27 15:45                     ` Tomas Winkler
2008-08-27 10:32         ` David Miller
2008-08-27 10:32           ` David Miller
2008-08-27 11:42           ` Tomas Winkler
2008-08-27 13:57         ` Arjan van de Ven
2008-08-27 13:57           ` Arjan van de Ven
2008-08-27 11:39 ` David Miller
2008-08-27 19:26 ` Tomas Winkler
2008-08-27 20:25   ` Michael Buesch [this message]
2008-08-27 20:25     ` Michael Buesch
2008-08-27 23:11     ` Tomas Winkler
2008-08-27 23:11       ` Tomas Winkler
2008-08-27 23:31       ` Luis R. Rodriguez
2008-08-27 23:31         ` Luis R. Rodriguez
2008-08-28  0:19         ` Tomas Winkler
2008-08-28  1:30           ` Luis R. Rodriguez
2008-08-28  1:30             ` Luis R. Rodriguez
2008-08-28  7:59             ` Tomas Winkler
2008-08-28  7:59               ` Tomas Winkler
2008-08-28 10:35         ` Bruno Randolf
2008-08-28 10:35           ` Bruno Randolf
2008-08-28 10:52           ` Tomas Winkler
2008-08-28 11:13             ` Bruno Randolf
2008-08-28 11:13               ` Bruno Randolf
2008-08-28  8:31       ` Michael Buesch
2008-08-28  8:31         ` Michael Buesch
2008-08-28  9:29         ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808272225.10557.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.