[U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

[Wolfgang Denk <wd@denx.de>]

Dear Guennadi Liakhovetski,

In message <Pine.LNX.4.64.0809011028550.4686@axis700.grange> you wrote:
> 
> 1. do not use the union
> 
> well, I would still prefer to use it and I hope I will be allowed to do so 
> in a separate NAND-tool. I agree, it would be better to use the definition 
> from the environment.h directly. But:

There is no such thing as a separate NAND tool - this mkes zero sense.
There shall be one tool that supports both NOR and NAND (and soon
probably DataFlash and OneNAND and ... ).

> 2. do not use single.crc in redundant case
> 
> This is done only at two places, yes, I realise, this is not very clean, 

Indeed. But the problem goes away automatically whenyou get rid of the
union.

> 4. fix MTD_OLD
> 
> Would we still need this with NAND-only tool?

Yes of course we need it. I will not accept such thing as a NAND-only tool.

> 5. clarify back-up mode
> 
> This is actually a comment improvement, can do.

Actually the whole implementation needs to be explained.

> Shall I keep support for NOR in the separate NAND version or completely 
> remove it? The "type == MTD_NORFLASH" code is quite small, so, removing it 

I don't understand why you come up with such an idea. There shall  be
just  the  one  tool we have now, just with extended functionality. I
just wanted to get rid of the futile attempts to make  the  one  huge
change looking like a series af several big but incremental changes.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Plan to throw one away. You will anyway."
                              - Fred Brooks, "The Mythical Man Month"