[U-Boot] [PATCH 2/6] Separate flash read and write operations

[Wolfgang Denk <wd@denx.de>]

Dear Guennadi Liakhovetski,

In message <Pine.LNX.4.64.0808271746001.6718@axis700.grange> you wrote:

Your

> Subject: Re: [U-Boot] [PATCH 2/6] Separate flash read and write operations

does not make a good  commit  comment  -  you  should  at  least  add
"fw_env:"  or  similar  so  eveybody know which "flash read and write
operations" you are talking about.

> The flash_io function was used for both read and write operations, whereby
> very little code was shared between the two modes. By breaking this function
> we simplify the code and save one level of identation.

If I see this correctly, you did not implement any functional changes
or bug fixes, i. e. it was just  a  code  restructuring  because  you
didn't like the current style and preferred another one?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Perfection is reached, not when there is no longer anything  to  add,
but when there is no longer anything to take away.
                                           - Antoine de Saint-Exupery