From: "Jörn Engel" <joern@logfs.org>
To: Jared Hulbert <jaredeh@gmail.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
tim.bird@am.sony.com, cotte@de.ibm.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH 00/10] AXFS: Advanced XIP filesystem
Date: Tue, 2 Sep 2008 19:15:01 +0200 [thread overview]
Message-ID: <20080902171500.GC19618@logfs.org> (raw)
In-Reply-To: <6934efce0809020944s36dd7f82wec77c4189ef1b114@mail.gmail.com>
On Tue, 2 September 2008 09:44:19 -0700, Jared Hulbert wrote:
>
> How is one expected to read those last 4 bytes of a loopbacked file?
> Are they unreadable? We can add the padding. I am just wondering if
> this is a bug or a known limitation in the loopback handling or if
> there is a different safer way of reading block devs with truncated
> last blocks.
Can't you just include the final magic into the last block, thereby
making the size a clean multiple of 4k? It looks as if you have some
padding before the magic anyway. So you just have to make sure the
padding is at least 4 bytes and write the magic to the end of it. Apart
from solving this bug, it should also save you some space. ;)
Jörn
--
Invincibility is in oneself, vulnerability is in the opponent.
-- Sun Tzu
WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@logfs.org>
To: Jared Hulbert <jaredeh@gmail.com>
Cc: cotte@de.ibm.com, linux-embedded@vger.kernel.org,
nickpiggin@yahoo.com.au, Linux-kernel@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
tim.bird@am.sony.com,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH 00/10] AXFS: Advanced XIP filesystem
Date: Tue, 2 Sep 2008 19:15:01 +0200 [thread overview]
Message-ID: <20080902171500.GC19618@logfs.org> (raw)
In-Reply-To: <6934efce0809020944s36dd7f82wec77c4189ef1b114@mail.gmail.com>
On Tue, 2 September 2008 09:44:19 -0700, Jared Hulbert wrote:
>
> How is one expected to read those last 4 bytes of a loopbacked file?
> Are they unreadable? We can add the padding. I am just wondering if
> this is a bug or a known limitation in the loopback handling or if
> there is a different safer way of reading block devs with truncated
> last blocks.
Can't you just include the final magic into the last block, thereby
making the size a clean multiple of 4k? It looks as if you have some
padding before the magic anyway. So you just have to make sure the
padding is at least 4 bytes and write the magic to the end of it. Apart
from solving this bug, it should also save you some space. ;)
Jörn
--
Invincibility is in oneself, vulnerability is in the opponent.
-- Sun Tzu
WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@logfs.org>
To: Jared Hulbert <jaredeh@gmail.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
tim.bird@am.sony.com, cotte@de.ibm.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH 00/10] AXFS: Advanced XIP filesystem
Date: Tue, 2 Sep 2008 19:15:01 +0200 [thread overview]
Message-ID: <20080902171500.GC19618@logfs.org> (raw)
In-Reply-To: <6934efce0809020944s36dd7f82wec77c4189ef1b114@mail.gmail.com>
On Tue, 2 September 2008 09:44:19 -0700, Jared Hulbert wrote:
>
> How is one expected to read those last 4 bytes of a loopbacked file?
> Are they unreadable? We can add the padding. I am just wondering if
> this is a bug or a known limitation in the loopback handling or if
> there is a different safer way of reading block devs with truncated
> last blocks.
Can't you just include the final magic into the last block, thereby
making the size a clean multiple of 4k? It looks as if you have some
padding before the magic anyway. So you just have to make sure the
padding is at least 4 bytes and write the magic to the end of it. Apart
from solving this bug, it should also save you some space. ;)
Jörn
--
Invincibility is in oneself, vulnerability is in the opponent.
-- Sun Tzu
next prev parent reply other threads:[~2008-09-02 17:15 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 5:44 [PATCH 00/10] AXFS: Advanced XIP filesystem Jared Hulbert
2008-08-21 5:44 ` Jared Hulbert
2008-08-21 6:32 ` Frans Meulenbroeks
2008-08-21 6:32 ` Frans Meulenbroeks
2008-08-21 19:32 ` Jared Hulbert
2008-08-21 19:32 ` Jared Hulbert
2008-08-22 2:04 ` Nick Piggin
2008-08-22 2:04 ` Nick Piggin
2008-08-21 8:39 ` Dave Chinner
2008-08-21 8:39 ` Dave Chinner
2008-08-21 14:19 ` Jared Hulbert
2008-08-21 14:19 ` Jared Hulbert
2008-08-21 14:31 ` Leon Woestenberg
2008-08-21 14:31 ` Leon Woestenberg
2008-08-21 14:42 ` Jared Hulbert
2008-08-21 14:42 ` Jared Hulbert
2008-08-21 14:49 ` Geert Uytterhoeven
2008-08-21 14:49 ` Geert Uytterhoeven
2008-08-21 10:25 ` Carsten Otte
2008-08-21 10:25 ` Carsten Otte
2008-08-21 10:43 ` Nick Piggin
2008-08-21 10:43 ` Nick Piggin
2008-08-21 12:53 ` Arnd Bergmann
2008-08-21 12:53 ` Arnd Bergmann
2008-08-21 14:12 ` Jared Hulbert
2008-08-21 14:12 ` Jared Hulbert
2008-08-21 14:14 ` Arnd Bergmann
2008-08-21 14:14 ` Arnd Bergmann
2008-08-21 14:13 ` Jared Hulbert
2008-08-21 14:13 ` Jared Hulbert
2008-08-22 2:32 ` Nick Piggin
2008-08-22 2:32 ` Nick Piggin
2008-08-21 14:30 ` Jared Hulbert
2008-08-21 14:30 ` Jared Hulbert
2008-08-21 11:07 ` Jamie Lokier
2008-08-21 11:07 ` Jamie Lokier
2008-08-21 14:11 ` Jared Hulbert
2008-08-21 14:11 ` Jared Hulbert
2008-08-22 0:12 ` Greg Ungerer
2008-08-22 0:12 ` Greg Ungerer
2008-08-22 2:48 ` Jared Hulbert
2008-08-22 2:48 ` Jared Hulbert
2008-08-25 6:35 ` Greg Ungerer
2008-08-25 6:35 ` Greg Ungerer
2008-08-25 11:43 ` Jamie Lokier
2008-08-25 11:43 ` Jamie Lokier
2008-08-25 14:02 ` Greg Ungerer
2008-08-25 14:02 ` Greg Ungerer
2008-08-22 18:13 ` Jamie Lokier
2008-08-22 18:13 ` Jamie Lokier
2008-08-22 18:16 ` Jared Hulbert
2008-08-22 18:16 ` Jared Hulbert
2008-08-22 18:37 ` Jamie Lokier
2008-08-22 18:37 ` Jamie Lokier
2008-08-22 18:43 ` Jamie Lokier
2008-08-22 18:43 ` Jamie Lokier
2008-09-12 21:52 ` Jared Hulbert
2008-09-12 21:52 ` Jared Hulbert
2008-09-15 16:34 ` Jamie Lokier
2008-09-15 16:34 ` Jamie Lokier
2008-09-15 19:43 ` Jared Hulbert
2008-09-15 19:43 ` Jared Hulbert
2008-09-19 19:20 ` Trent Piepho
2008-09-19 19:20 ` Trent Piepho
2008-09-16 6:57 ` Ricard Wanderlof
2008-09-16 6:57 ` Ricard Wanderlof
2008-09-16 6:57 ` Ricard Wanderlof
2008-09-16 15:30 ` Jared Hulbert
2008-09-16 15:30 ` Jared Hulbert
2008-09-12 20:17 ` Jared Hulbert
2008-09-12 20:17 ` Jared Hulbert
2008-09-15 16:40 ` Jamie Lokier
2008-09-15 16:40 ` Jamie Lokier
2008-08-21 23:46 ` Greg Ungerer
2008-08-21 23:46 ` Greg Ungerer
2008-08-22 18:10 ` Jamie Lokier
2008-08-22 18:10 ` Jamie Lokier
2008-08-22 14:54 ` Geert Uytterhoeven
2008-08-22 14:54 ` Geert Uytterhoeven
2008-08-22 15:19 ` Arnd Bergmann
2008-08-22 15:19 ` Arnd Bergmann
2008-08-22 16:51 ` Jared Hulbert
2008-08-22 16:51 ` Jared Hulbert
2008-08-25 9:37 ` Geert Uytterhoeven
2008-08-25 9:37 ` Geert Uytterhoeven
2008-08-25 9:37 ` Geert Uytterhoeven
2008-08-25 10:52 ` Carsten Otte
2008-08-25 10:52 ` Carsten Otte
2008-08-25 12:16 ` David Woodhouse
2008-08-25 12:16 ` David Woodhouse
2008-08-28 15:40 ` Geert Uytterhoeven
2008-08-28 15:40 ` Geert Uytterhoeven
2008-09-02 15:37 ` Geert Uytterhoeven
2008-09-02 15:37 ` Geert Uytterhoeven
2008-09-02 16:44 ` Jared Hulbert
2008-09-02 16:44 ` Jared Hulbert
2008-09-02 17:15 ` Jörn Engel [this message]
2008-09-02 17:15 ` Jörn Engel
2008-09-02 17:15 ` Jörn Engel
2008-09-02 17:47 ` Jared Hulbert
2008-09-02 17:47 ` Jared Hulbert
2008-09-02 18:33 ` Geert Uytterhoeven
2008-09-02 18:33 ` Geert Uytterhoeven
2008-08-22 22:09 ` Will Marone
2008-08-22 22:09 ` Will Marone
2008-08-25 7:23 ` Geert Uytterhoeven
2008-08-25 7:23 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902171500.GC19618@logfs.org \
--to=joern@logfs.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=cotte@de.ibm.com \
--cc=jaredeh@gmail.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.