From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bryan Wu <cooloney@kernel.org>
Cc: Cliff Cai <cliff.cai@analog.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] ASoC: Blackfin: DMA Driver for AC97 sound chip
Date: Thu, 4 Sep 2008 13:37:41 +0100 [thread overview]
Message-ID: <20080904123741.GA13735@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1220516528-20301-5-git-send-email-cooloney@kernel.org>
On Thu, Sep 04, 2008 at 04:22:03PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@analog.com>
>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
A couple of coding standards nits below but please fix these as an
incremental patch to save on reviewing.
> + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> + curr = sport_curr_offset_tx(sport) / sizeof(struct ac97_frame);
> + else {
> + curr = sport_curr_offset_rx(sport) / sizeof(struct ac97_frame);
> +
> + }
Don't need the { }.
> + ret = snd_pcm_hw_constraint_integer(runtime, \
> + SNDRV_PCM_HW_PARAM_PERIODS);
> + if (ret < 0)
> + goto out;
No need for the line continuation here.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bryan Wu <cooloney@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Cliff Cai <cliff.cai@analog.com>
Subject: Re: [PATCH 4/9] ASoC: Blackfin: DMA Driver for AC97 sound chip
Date: Thu, 4 Sep 2008 13:37:41 +0100 [thread overview]
Message-ID: <20080904123741.GA13735@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1220516528-20301-5-git-send-email-cooloney@kernel.org>
On Thu, Sep 04, 2008 at 04:22:03PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@analog.com>
>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
A couple of coding standards nits below but please fix these as an
incremental patch to save on reviewing.
> + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> + curr = sport_curr_offset_tx(sport) / sizeof(struct ac97_frame);
> + else {
> + curr = sport_curr_offset_rx(sport) / sizeof(struct ac97_frame);
> +
> + }
Don't need the { }.
> + ret = snd_pcm_hw_constraint_integer(runtime, \
> + SNDRV_PCM_HW_PARAM_PERIODS);
> + if (ret < 0)
> + goto out;
No need for the line continuation here.
next prev parent reply other threads:[~2008-09-04 12:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 8:21 [PATCH 0/9] ASoC Blackfin supporting Bryan Wu
2008-09-04 8:22 ` [PATCH 1/9] ASoC: add Blackfin build options to Kconfig and Makefile of sound soc framework Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 8:22 ` [PATCH 2/9] ASoC: Blackfin: add Blackfin arch ASoC Kconfig and Makefile Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 10:41 ` Mark Brown
2008-09-04 10:41 ` Mark Brown
2008-09-04 8:22 ` [PATCH 3/9] ASoC: Blackfin: SPORT peripheral interface driver Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 10:47 ` Mark Brown
2008-09-04 10:47 ` Mark Brown
2008-09-04 14:11 ` Mike Frysinger
2008-09-04 8:22 ` [PATCH 4/9] ASoC: Blackfin: DMA Driver for AC97 sound chip Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 12:37 ` Mark Brown [this message]
2008-09-04 12:37 ` Mark Brown
2008-09-04 8:22 ` [PATCH 5/9] ASoC: Blackfin: AC97 Blackfin CPU DAI driver Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 12:46 ` Mark Brown
2008-09-04 12:46 ` Mark Brown
2008-09-04 12:49 ` Mark Brown
2008-09-04 12:49 ` Mark Brown
2008-09-04 8:22 ` [PATCH 6/9] ASoC: Blackfin: DMA Driver for I2S sound chip Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 14:32 ` Mark Brown
2008-09-04 14:32 ` Mark Brown
2008-09-04 8:22 ` [PATCH 7/9] ASoC: Blackfin: I2S CPU DAI driver Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 14:43 ` Mark Brown
2008-09-04 14:43 ` Mark Brown
2008-10-09 6:53 ` John Kacur
2008-10-09 6:58 ` Fwd: " John Kacur
2008-10-09 7:35 ` Valdis.Kletnieks
2008-10-09 8:02 ` John Kacur
2008-10-09 8:02 ` John Kacur
2008-10-09 10:44 ` Mark Brown
2008-10-09 10:44 ` [alsa-devel] " Mark Brown
2008-09-04 8:22 ` [PATCH 8/9] ASoC: Blackfin: board driver for AD1980/1 audio codec Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 14:44 ` Mark Brown
2008-09-04 14:44 ` Mark Brown
2008-09-04 8:22 ` [PATCH 9/9] ASoC: Blackfin: board driver for SSM2602 sound chip Bryan Wu
2008-09-04 8:22 ` Bryan Wu
2008-09-04 14:49 ` Mark Brown
2008-09-04 14:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904123741.GA13735@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.