All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Move normal, serial & pci to i386.rmk
Date: Mon, 8 Sep 2008 17:09:20 +0200	[thread overview]
Message-ID: <20080908150920.GA24943@thorin> (raw)
In-Reply-To: <20080908104902.o5gbh1bm2o8cssgs-cebfxv@webmail.spamcop.net>

On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote:
> Quoting Robert Millan <rmh@aybabtu.com>:
> 
> >
> >This patch moves normal, serial and pci to conf/i386.rmk.
> 
> Why i386?  That code is not i386 specific.

It is.  Notice it's being moved from conf/i386-*.rmk, not common.rmk.

normal:  Includes normal/i386/setjmp.S

serial, pci:  Relies on grub_{in,out}{b,w,l} functions, which are only
  implemented for i386 so far.  Of course, if someone writes the powerpc
  stubs, then they could be moved to common.rmk, but they're i386-specific
  now.

> I believe we could declare SPARC broken, but keep PowerPC working.

Agreed.  I suggest we remove the conf/sparc* files, which are burdensome
(since people unaware that SPARC is broken might try to keep them uptodate)
and don't really provide any hard-to-find knowledge, and keep the
kern/*/sparc/* bits which might be useful if/when someone tries to reinstate
the port.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  parent reply	other threads:[~2008-09-08 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08 13:47 [PATCH] Move normal, serial & pci to i386.rmk Robert Millan
2008-09-08 14:49 ` Pavel Roskin
2008-09-08 14:58   ` Vesa Jääskeläinen
2008-09-08 15:09   ` Robert Millan [this message]
2008-09-08 15:17     ` Vesa Jääskeläinen
2008-09-08 18:24       ` Robert Millan
2008-09-08 18:36         ` Vesa Jääskeläinen
2008-09-08 15:25     ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080908150920.GA24943@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.