From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Move normal, serial & pci to i386.rmk
Date: Mon, 08 Sep 2008 21:36:06 +0300 [thread overview]
Message-ID: <48C57096.1020006@nic.fi> (raw)
In-Reply-To: <20080908182409.GA31031@thorin>
Robert Millan wrote:
> On Mon, Sep 08, 2008 at 06:17:34PM +0300, Vesa Jääskeläinen wrote:
>> Robert Millan wrote:
>>> On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote:
>>>> Quoting Robert Millan <rmh@aybabtu.com>:
>>>>
>>>>> This patch moves normal, serial and pci to conf/i386.rmk.
>>>> Why i386? That code is not i386 specific.
>>> It is. Notice it's being moved from conf/i386-*.rmk, not common.rmk.
>>>
>>> normal: Includes normal/i386/setjmp.S
>> Should we move this out of normal.mod ?
>
> You mean as a standalone module, or to kernel? In a standalone module, we'd
> still want to have that module in i386.rmk? Then it's basicaly the same
> issue. And in kernel there's the problem about size...
>
Or another option is to put all common stuff in common.rmk and then
concatenate platform features in platform specific .rmk.
next prev parent reply other threads:[~2008-09-08 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 13:47 [PATCH] Move normal, serial & pci to i386.rmk Robert Millan
2008-09-08 14:49 ` Pavel Roskin
2008-09-08 14:58 ` Vesa Jääskeläinen
2008-09-08 15:09 ` Robert Millan
2008-09-08 15:17 ` Vesa Jääskeläinen
2008-09-08 18:24 ` Robert Millan
2008-09-08 18:36 ` Vesa Jääskeläinen [this message]
2008-09-08 15:25 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C57096.1020006@nic.fi \
--to=chaac@nic.fi \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.