Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef

["Kirill A. Shutemov" <kirill@shutemov.name>]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

On Wed, Sep 10, 2008 at 05:11:58PM +0400, Alexey Dobriyan wrote:
> On Wed, Sep 10, 2008 at 03:55:04PM +0300, Kirill A. Shutemov wrote:
> > On Wed, Sep 10, 2008 at 04:14:50PM +0400, Alexey Dobriyan wrote:
> > > On Wed, Sep 10, 2008 at 02:22:04PM +0300, Kirill A. Shutemov wrote:
> > > > --- a/include/linux/dlm_plock.h
> > > > +++ b/include/linux/dlm_plock.h
> > > 
> > > > +#include <linux/types.h>
> > > 
> > > I'd say that unless you can demonstrate compilation breakage, these will
> > > only slow down compilation.
> > 
> > Do you think that minor slow down is worse than dependence on the order of
> > inclusion?
> 
> Since it compiles fine there is no such dependency.

It doesn't compiles:

$ make headers_install
...
$ gcc usr/include/linux/dlm_plock.h
usr/include/linux/dlm_plock.h:25: error: expected specifier-qualifier-list
before ‘__u32’

> Just removing externs from function prototypes makes compiles go faster for
> _seconds_.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]