All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: David Miller <davem@davemloft.net>
Cc: adobriyan@gmail.com, linux-kernel@vger.kernel.org,
	caulfie@redhat.com, teigland@redhat.com, dwmw2@infradead.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef
Date: Thu, 11 Sep 2008 18:29:18 +0300	[thread overview]
Message-ID: <20080911152916.GE4933@localhost.localdomain> (raw)
In-Reply-To: <20080910.131824.244309370.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On Wed, Sep 10, 2008 at 01:18:24PM -0700, David Miller wrote:
> From: "Kirill A. Shutemov" <kirill@shutemov.name>
> Date: Wed, 10 Sep 2008 16:15:13 +0300
> 
> > $ make headers_install
> > ...
> > $ gcc usr/include/linux/dlm_plock.h
> > usr/include/linux/dlm_plock.h:25: error: expected specifier-qualifier-list
> > before ‘__u32’
> 
> That's not how this file is used by real applications.
> Anybody can cook up contrived cases like this.
> 
> Please show a real application or kernel compilation which breaks
> because of the lack of types.h include here.

Any application which include this header before linux/types.h (directly or 
indirectly) will get the error. It's dependence on the order of inclusion.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-09-11 15:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 11:22 [PATCH] include <linux/fs.h> into linux/ext2_fs.h Kirill A. Shutemov
2008-09-10 11:22 ` [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef Kirill A. Shutemov
2008-09-10 11:22   ` [PATCH] include <linux/types.h> into linux/if_addrlabel.h " Kirill A. Shutemov
2008-09-10 11:22     ` [PATCH] include <linux/videodev2.h> into linux/ivtv.h Kirill A. Shutemov
2008-09-10 12:14   ` [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef Alexey Dobriyan
2008-09-10 12:55     ` Kirill A. Shutemov
2008-09-10 13:11       ` Alexey Dobriyan
2008-09-10 13:15         ` Kirill A. Shutemov
2008-09-10 20:18           ` David Miller
2008-09-11 15:29             ` Kirill A. Shutemov [this message]
2008-09-10 14:20     ` David Woodhouse
2008-09-10 11:27 ` [PATCH] include <linux/fs.h> into linux/ext2_fs.h Christoph Hellwig
2008-09-10 11:40   ` Kirill A. Shutemov
2008-09-10 11:40     ` Christoph Hellwig
2008-09-10 11:49       ` Kirill A. Shutemov
2008-09-10 13:39         ` Eric Sandeen
2008-09-10 13:47           ` Kirill A. Shutemov
2008-09-10 14:57             ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080911152916.GE4933@localhost.localdomain \
    --to=kirill@shutemov.name \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=caulfie@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.