From: Eric Sandeen <sandeen@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-ext4@vger.kernel.org, David Howells <dhowells@redhat.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h
Date: Wed, 10 Sep 2008 08:39:00 -0500 [thread overview]
Message-ID: <48C7CDF4.2020206@redhat.com> (raw)
In-Reply-To: <20080910114923.GC3757@localhost.localdomain>
Kirill A. Shutemov wrote:
> On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote:
>> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote:
>>> On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote:
>>>> On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
>>>>> linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h
>>>> And who cares?
>
> Do you think it isn't error?
>
>>> It breaks building pam_mktemp at least.
>> pam_mktemp should not use <linux/ext2_fs.h>, but rather
>> <ext2fs/ext2_fs.h>.
That's right.
> Why linux/ext2_fs.h does export to userspace?
>
it does?
$ grep header-y include/linux/Kbuild | wc -l
163
$ grep header-y include/linux/Kbuild | grep ext2
$
I think it does not.
-Eric
next prev parent reply other threads:[~2008-09-10 13:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 11:22 [PATCH] include <linux/fs.h> into linux/ext2_fs.h Kirill A. Shutemov
2008-09-10 11:22 ` [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef Kirill A. Shutemov
2008-09-10 11:22 ` [PATCH] include <linux/types.h> into linux/if_addrlabel.h " Kirill A. Shutemov
2008-09-10 11:22 ` [PATCH] include <linux/videodev2.h> into linux/ivtv.h Kirill A. Shutemov
2008-09-10 12:14 ` [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef Alexey Dobriyan
2008-09-10 12:55 ` Kirill A. Shutemov
2008-09-10 13:11 ` Alexey Dobriyan
2008-09-10 13:15 ` Kirill A. Shutemov
2008-09-10 20:18 ` David Miller
2008-09-11 15:29 ` Kirill A. Shutemov
2008-09-10 14:20 ` David Woodhouse
2008-09-10 11:27 ` [PATCH] include <linux/fs.h> into linux/ext2_fs.h Christoph Hellwig
2008-09-10 11:40 ` Kirill A. Shutemov
2008-09-10 11:40 ` Christoph Hellwig
2008-09-10 11:49 ` Kirill A. Shutemov
2008-09-10 13:39 ` Eric Sandeen [this message]
2008-09-10 13:47 ` Kirill A. Shutemov
2008-09-10 14:57 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C7CDF4.2020206@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=kirill@shutemov.name \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.