All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, kkeil@suse.de, netdev@vger.kernel.org,
	andi@firstfloor.org, ak@linux.intel.com
Subject: Re: [patch 4/4] mISDN: misc timerdev fixes
Date: Tue, 23 Sep 2008 04:27:32 +0200	[thread overview]
Message-ID: <20080923022731.GE25711@one.firstfloor.org> (raw)
In-Reply-To: <20080922.191826.16007223.davem@davemloft.net>

On Mon, Sep 22, 2008 at 07:18:26PM -0700, David Miller wrote:
> From: akpm@linux-foundation.org
> Date: Mon, 22 Sep 2008 14:51:03 -0700
> 
> > - Remove noop VFS stubs. The VFS does that on a NULL pointer anyways.
> > - Fix timer handler prototype to be correct
> > - Comment ugly SMP race I didn't fix.
> > 
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Applied to net-next-2.6

I'm hoping someone takes care of the SMP race. I think the timers
need all reference counting similar to other network objects to
handle this cleanly.

It might be a good idea to mark it BROKEN_ON_SMP in the meantime.

-Andi

-- 
ak@linux.intel.com

  reply	other threads:[~2008-09-23  2:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 21:51 [patch 4/4] mISDN: misc timerdev fixes akpm
2008-09-23  2:18 ` David Miller
2008-09-23  2:27   ` Andi Kleen [this message]
2008-09-23  6:34     ` Karsten Keil
2008-09-23 11:49       ` Christoph Hellwig
2008-09-23 10:40 ` Christoph Hellwig
2008-09-23 11:30   ` Andrew Morton
2008-09-23 11:45     ` Christoph Hellwig
2008-09-23 12:00       ` Karsten Keil
2008-09-23 17:31         ` Andrew Morton
2008-09-23 14:14     ` Andi Kleen
2008-09-23 14:17     ` [patch 4/4] mISDN: misc timerdev fixes II Andi Kleen
2008-09-23 15:58       ` Christoph Hellwig
2008-09-23 16:46         ` Andi Kleen
2008-09-23 16:48           ` Christoph Hellwig
2008-10-12 11:05     ` [patch 4/4] mISDN: misc timerdev fixes Christoph Hellwig
2008-10-13  2:11       ` Andrew Morton
2008-10-13  2:16         ` Christoph Hellwig
2008-10-13  4:00         ` David Miller
2008-10-13 11:56           ` Andrew Morton
2008-10-13 18:47             ` David Miller
2008-09-23 14:13   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080923022731.GE25711@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=kkeil@suse.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.