From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
kkeil@suse.de, netdev@vger.kernel.org, ak@linux.intel.com
Subject: Re: [patch 4/4] mISDN: misc timerdev fixes II
Date: Tue, 23 Sep 2008 18:46:52 +0200 [thread overview]
Message-ID: <20080923164651.GK25711@one.firstfloor.org> (raw)
In-Reply-To: <20080923155844.GA30526@infradead.org>
On Tue, Sep 23, 2008 at 11:58:44AM -0400, Christoph Hellwig wrote:
> On Tue, Sep 23, 2008 at 04:17:40PM +0200, Andi Kleen wrote:
> > > > > static struct file_operations mISDN_fops = {
> > > > > - .llseek = mISDN_llseek,
> > > >
> > > > This is wrong. no llseek means we use default_llseek, which is
> > > > different from returning -ESPIPE.
> > >
> > > so.. this?
> >
> > Hmm actually on double checking it's really needed, sorry.
>
> Yes, unfortunately the only way it's cleared currently is through using
> nonseekable_open, but I've started preparing a war plan to sort this whole
> mess out.
Yes it would be much more logical if FMODE_SEEK was cleared on character devices
by default. That is what I assumed with the original patch.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-09-23 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 21:51 [patch 4/4] mISDN: misc timerdev fixes akpm
2008-09-23 2:18 ` David Miller
2008-09-23 2:27 ` Andi Kleen
2008-09-23 6:34 ` Karsten Keil
2008-09-23 11:49 ` Christoph Hellwig
2008-09-23 10:40 ` Christoph Hellwig
2008-09-23 11:30 ` Andrew Morton
2008-09-23 11:45 ` Christoph Hellwig
2008-09-23 12:00 ` Karsten Keil
2008-09-23 17:31 ` Andrew Morton
2008-09-23 14:14 ` Andi Kleen
2008-09-23 14:17 ` [patch 4/4] mISDN: misc timerdev fixes II Andi Kleen
2008-09-23 15:58 ` Christoph Hellwig
2008-09-23 16:46 ` Andi Kleen [this message]
2008-09-23 16:48 ` Christoph Hellwig
2008-10-12 11:05 ` [patch 4/4] mISDN: misc timerdev fixes Christoph Hellwig
2008-10-13 2:11 ` Andrew Morton
2008-10-13 2:16 ` Christoph Hellwig
2008-10-13 4:00 ` David Miller
2008-10-13 11:56 ` Andrew Morton
2008-10-13 18:47 ` David Miller
2008-09-23 14:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923164651.GK25711@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.