From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: hch@infradead.org, kkeil@suse.de, netdev@vger.kernel.org,
andi@firstfloor.org, ak@linux.intel.com
Subject: Re: [patch 4/4] mISDN: misc timerdev fixes
Date: Sun, 12 Oct 2008 19:11:13 -0700 [thread overview]
Message-ID: <20081012191113.4aa0d6ef.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081012110510.GA19600@infradead.org>
> On Sun, 12 Oct 2008 07:05:10 -0400 Christoph Hellwig <hch@infradead.org> wrote:
>
> The bogus version which removes ->llseek just got into Linus' tree..
Well I still have this queued:
From: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Karsten Keil <kkeil@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/isdn/mISDN/timerdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix drivers/isdn/mISDN/timerdev.c
--- a/drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix
+++ a/drivers/isdn/mISDN/timerdev.c
@@ -61,7 +61,7 @@ mISDN_open(struct inode *ino, struct fil
init_waitqueue_head(&dev->wait);
filep->private_data = dev;
__module_get(THIS_MODULE);
- return 0;
+ return nonseekable_open(ino, filep);
}
static int
_
So presumably whoever merged the unfixed version flubbed the fix.
If that'll fix it. Is it sufficient? I think so.
next prev parent reply other threads:[~2008-10-13 2:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 21:51 [patch 4/4] mISDN: misc timerdev fixes akpm
2008-09-23 2:18 ` David Miller
2008-09-23 2:27 ` Andi Kleen
2008-09-23 6:34 ` Karsten Keil
2008-09-23 11:49 ` Christoph Hellwig
2008-09-23 10:40 ` Christoph Hellwig
2008-09-23 11:30 ` Andrew Morton
2008-09-23 11:45 ` Christoph Hellwig
2008-09-23 12:00 ` Karsten Keil
2008-09-23 17:31 ` Andrew Morton
2008-09-23 14:14 ` Andi Kleen
2008-09-23 14:17 ` [patch 4/4] mISDN: misc timerdev fixes II Andi Kleen
2008-09-23 15:58 ` Christoph Hellwig
2008-09-23 16:46 ` Andi Kleen
2008-09-23 16:48 ` Christoph Hellwig
2008-10-12 11:05 ` [patch 4/4] mISDN: misc timerdev fixes Christoph Hellwig
2008-10-13 2:11 ` Andrew Morton [this message]
2008-10-13 2:16 ` Christoph Hellwig
2008-10-13 4:00 ` David Miller
2008-10-13 11:56 ` Andrew Morton
2008-10-13 18:47 ` David Miller
2008-09-23 14:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012191113.4aa0d6ef.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.