From: Raphael Zimmerer <killekulla@rdrz.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] git grep: Add "-Z/--null" option as in GNU's grep.
Date: Wed, 1 Oct 2008 15:23:51 +0200 [thread overview]
Message-ID: <20081001132351.GA20659@rdrz.de> (raw)
In-Reply-To: <alpine.DEB.1.00.0810011514530.22125@pacific.mpi-cbg.de.mpi-cbg.de>
On Wed, Oct 01, 2008 at 03:15:34PM +0200, Johannes Schindelin wrote:
> On Wed, 1 Oct 2008, Raphael Zimmerer wrote:
> > On Tue, Sep 30, 2008 at 04:16:19PM -0700, Shawn O. Pearce wrote:
> > > Elsewhere in Git we call this "-z", like "git ls-tree -z", "git log
> > > -z". Should we match grep or git convention here?
> >
> > I'd tend to grep's convention, as most options of git-grep mimic those
> > of grep. grep uses "-z" for \0 on _input_, so that would be very
> > confusing for grep users...
>
> I tend to disagree. Git is _already_ perceived as too heterogenous, and
> we should not add to that pile.
How about discarding "-Z" from my patch, and only leave in "--null"?
That removes ambiguity _and_ is compatible to GNU grep.
- Raphael
next prev parent reply other threads:[~2008-10-01 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 23:13 [PATCH] git grep: Add "-Z/--null" option as in GNU's grep Raphael Zimmerer
2008-09-30 23:16 ` Shawn O. Pearce
2008-09-30 23:41 ` Raphael Zimmerer
2008-10-01 13:15 ` Johannes Schindelin
2008-10-01 13:23 ` Raphael Zimmerer [this message]
2008-10-01 14:52 ` Shawn O. Pearce
2008-10-01 15:11 ` Raphael Zimmerer
2008-10-01 6:12 ` Pierre Habouzit
2008-10-01 15:03 ` Shawn O. Pearce
2008-10-01 16:11 ` [PATCH v2] git grep: Add "-z/--null" " Raphael Zimmerer
2008-10-01 16:17 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001132351.GA20659@rdrz.de \
--to=killekulla@rdrz.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.