From: "Shawn O. Pearce" <spearce@spearce.org>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Raphael Zimmerer <killekulla@rdrz.de>, git@vger.kernel.org
Subject: Re: [PATCH] git grep: Add "-Z/--null" option as in GNU's grep.
Date: Wed, 1 Oct 2008 08:03:08 -0700 [thread overview]
Message-ID: <20081001150308.GZ21310@spearce.org> (raw)
In-Reply-To: <20081001061249.GC22363@artemis.corp>
Pierre Habouzit <madcoder@debian.org> wrote:
> On Tue, Sep 30, 2008 at 11:13:10PM +0000, Raphael Zimmerer wrote:
> > + printf("%s%c", name, opt->null_following_name ? 0 : '\n');
>
> I know I'm nitpicking and I don't know what the git custom on this
> really is, but I tend to prefer '\0' when in the context of a char.
> There is no confusion here of course, but I believe it to be a sane
> habit. (In the same vein that it's ugly to use 0 for NULL ;p).
Its a valid nitpick. NUL is '\0' when dealing with chars in Git,
NULL is NULL, and 0 is the integer 0. That line should read '\0'
to conform with the other code already in git.git.
--
Shawn.
next prev parent reply other threads:[~2008-10-01 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 23:13 [PATCH] git grep: Add "-Z/--null" option as in GNU's grep Raphael Zimmerer
2008-09-30 23:16 ` Shawn O. Pearce
2008-09-30 23:41 ` Raphael Zimmerer
2008-10-01 13:15 ` Johannes Schindelin
2008-10-01 13:23 ` Raphael Zimmerer
2008-10-01 14:52 ` Shawn O. Pearce
2008-10-01 15:11 ` Raphael Zimmerer
2008-10-01 6:12 ` Pierre Habouzit
2008-10-01 15:03 ` Shawn O. Pearce [this message]
2008-10-01 16:11 ` [PATCH v2] git grep: Add "-z/--null" " Raphael Zimmerer
2008-10-01 16:17 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001150308.GZ21310@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=killekulla@rdrz.de \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.