From: "Shawn O. Pearce" <spearce@spearce.org>
To: Raphael Zimmerer <killekulla@rdrz.de>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de, madcoder@debian.org
Subject: Re: [PATCH v2] git grep: Add "-z/--null" option as in GNU's grep.
Date: Wed, 1 Oct 2008 09:17:05 -0700 [thread overview]
Message-ID: <20081001161705.GH21310@spearce.org> (raw)
In-Reply-To: <1222877475-2699-1-git-send-email-killekulla@rdrz.de>
Raphael Zimmerer <killekulla@rdrz.de> wrote:
> diff --git a/builtin-grep.c b/builtin-grep.c
> index 3a51662..2241324 100644
> --- a/builtin-grep.c
> +++ b/builtin-grep.c
> @@ -295,6 +295,9 @@ static int external_grep(struct grep_opt *opt, const char **paths, int cached)
> push_arg("-l");
> if (opt->unmatch_name_only)
> push_arg("-L");
> + if (opt->null_following_name)
> + // in GNU grep git's "-z" translates to "-Z"
> + push_arg("-Z");
We use /* */ style comments in Git. I've amended the patch with
the simple // -> /* */ translation.
The rest of this change looks good to me. Its queued for next.
--
Shawn.
prev parent reply other threads:[~2008-10-01 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 23:13 [PATCH] git grep: Add "-Z/--null" option as in GNU's grep Raphael Zimmerer
2008-09-30 23:16 ` Shawn O. Pearce
2008-09-30 23:41 ` Raphael Zimmerer
2008-10-01 13:15 ` Johannes Schindelin
2008-10-01 13:23 ` Raphael Zimmerer
2008-10-01 14:52 ` Shawn O. Pearce
2008-10-01 15:11 ` Raphael Zimmerer
2008-10-01 6:12 ` Pierre Habouzit
2008-10-01 15:03 ` Shawn O. Pearce
2008-10-01 16:11 ` [PATCH v2] git grep: Add "-z/--null" " Raphael Zimmerer
2008-10-01 16:17 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001161705.GH21310@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=killekulla@rdrz.de \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.