From: Jens Axboe <jens.axboe@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: neilb@suse.de, agk@sourceware.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com
Subject: Re: [PATCH 5/7] block: Find bio sector offset given idx and offset
Date: Thu, 2 Oct 2008 19:07:10 +0200 [thread overview]
Message-ID: <20081002170709.GM19428@kernel.dk> (raw)
In-Reply-To: <yq163obiuoi.fsf@sermon.lab.mkp.net>
On Wed, Oct 01 2008, Martin K. Petersen wrote:
> >>>>> "Jens" == Jens Axboe <jens.axboe@oracle.com> writes:
>
> Jens> Too may BUG's there, me thinks, and the interface looks
> Jens> fragile. What if the bio is alreday done (bi_idx == bi_vcnt)?
>
> Good point! Obviously I've only used the function for bio splitting
> and not at completion time. Updated patch below.
>
>
> block: Find bio sector offset given idx and offset
>
> Helper function to find the sector offset in a bio given bvec index
> and page offset.
Looks good, I've applied patches 1-5.
--
Jens Axboe
next prev parent reply other threads:[~2008-10-02 17:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 7:38 Block integrity patches for 2.6.28 Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-01 7:38 ` [PATCH 1/7] block: Introduce integrity data ownership flag Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-01 7:38 ` [PATCH 2/7] block: Fix double put in blk_integrity_unregister Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-01 7:38 ` [PATCH 3/7] block: Switch blk_integrity_compare from bdev to gendisk Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-01 7:38 ` [PATCH 4/7] block: gendisk integrity wrapper Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-01 7:38 ` [PATCH 5/7] block: Find bio sector offset given idx and offset Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-01 8:10 ` Jens Axboe
2008-10-02 2:42 ` Martin K. Petersen
2008-10-02 2:42 ` Martin K. Petersen
2008-10-02 17:07 ` Jens Axboe [this message]
2008-10-01 7:38 ` [PATCH 6/7] dm: Add support for data integrity to DM Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-01 7:38 ` [PATCH 7/7] md: Add support for data integrity to MD Martin K. Petersen
2008-10-01 7:38 ` Martin K. Petersen
2008-10-02 10:56 ` Block integrity patches for 2.6.28 Jens Axboe
2008-10-02 13:54 ` Martin K. Petersen
2008-10-02 16:29 ` Jens Axboe
2008-10-02 16:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002170709.GM19428@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=agk@sourceware.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.