* [PATCH] HPET: Remove spurious HPET busy warning message.
@ 2008-10-06 8:52 David John
2008-10-08 19:16 ` Venki Pallipadi
0 siblings, 1 reply; 3+ messages in thread
From: David John @ 2008-10-06 8:52 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, clemens, venkatesh.pallipadi, vojtech, bob.picco
On x86 systems with CONFIG_HPET_TIMER enabled
and the HPET driver (drivers/char/hpet.c) compiled in,
an incorrect busy message is printed when the driver
initializes since the HPET has already been allocated
by the core timer code. Remove the warning message.
Signed-off-by: David John <davidjon@xenontk.org>
---
drivers/char/hpet.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index b3f5dbc..454c13b 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
hdp->hd_address = ioremap(addr.minimum, addr.address_length);
if (hpet_is_known(hdp)) {
- printk(KERN_DEBUG "%s: 0x%lx is busy\n",
- __func__, hdp->hd_phys_address);
iounmap(hdp->hd_address);
return AE_ALREADY_EXISTS;
}
@@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
HPET_RANGE_SIZE);
if (hpet_is_known(hdp)) {
- printk(KERN_DEBUG "%s: 0x%lx is busy\n",
- __func__, hdp->hd_phys_address);
iounmap(hdp->hd_address);
return AE_ALREADY_EXISTS;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HPET: Remove spurious HPET busy warning message.
2008-10-06 8:52 [PATCH] HPET: Remove spurious HPET busy warning message David John
@ 2008-10-08 19:16 ` Venki Pallipadi
0 siblings, 0 replies; 3+ messages in thread
From: Venki Pallipadi @ 2008-10-08 19:16 UTC (permalink / raw)
To: David John
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
clemens@ladisch.de, Pallipadi, Venkatesh, vojtech@suse.cz,
bob.picco@hp.com
Yes. This printk is not adding much value and tend to get people confused
making them think that it is some sort of error. It will be good to get rid
of them.
Ingo: Can you pick this patch up into tip?
Thanks,
Venki
Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
On Mon, Oct 06, 2008 at 01:52:20AM -0700, David John wrote:
> On x86 systems with CONFIG_HPET_TIMER enabled
> and the HPET driver (drivers/char/hpet.c) compiled in,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
>
> Signed-off-by: David John <davidjon@xenontk.org>
> ---
> drivers/char/hpet.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> hdp->hd_address = ioremap(addr.minimum, addr.address_length);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> HPET_RANGE_SIZE);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HPET: Remove spurious HPET busy warning message.
[not found] ` <1223619164-16874-1-git-send-email-davidjon@xenontk.org>
@ 2008-10-10 7:26 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-10-10 7:26 UTC (permalink / raw)
To: David John
Cc: clemens, venkatesh.pallipadi, vojtech, bob.picco, linux-kernel,
H. Peter Anvin, Thomas Gleixner
* David John <davidjon@xenontk.org> wrote:
> On x86 systems with CONFIG_HPET_TIMER enabled, when
> the HPET driver (drivers/char/hpet.c) is loaded,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
>
> Signed-off-by: David John <davidjon@xenontk.org>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> ---
> drivers/char/hpet.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> hdp->hd_address = ioremap(addr.minimum, addr.address_length);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> HPET_RANGE_SIZE);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }
applied to tip/timers/hpet, thanks John!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-10 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-06 8:52 [PATCH] HPET: Remove spurious HPET busy warning message David John
2008-10-08 19:16 ` Venki Pallipadi
[not found] <48EEF194.5010008@xenontk.org>
[not found] ` <1223619164-16874-1-git-send-email-davidjon@xenontk.org>
2008-10-10 7:26 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.