From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org,
Syed Mohammed Khasim <x0khasim@ti.com>,
Karthik Dasu <karthik-dp@ti.com>,
Adrian Hunter <ext-adrian.hunter@nokia.com>
Subject: Re: [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support
Date: Thu, 9 Oct 2008 15:47:37 +0100 [thread overview]
Message-ID: <20081009144737.GG435@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1223035779-26306-2-git-send-email-tony@atomide.com>
On Fri, Oct 03, 2008 at 03:09:35PM +0300, Tony Lindgren wrote:
> @@ -51,12 +53,39 @@ static struct map_desc omap2_io_desc[] __initdata = {
> .type = MT_DEVICE
> },
> {
> - .virtual = L4_24XX_VIRT,
> - .pfn = __phys_to_pfn(L4_24XX_PHYS),
> - .length = L4_24XX_SIZE,
> - .type = MT_DEVICE
> + .virtual = L4_24XX_VIRT,
> + .pfn = __phys_to_pfn(L4_24XX_PHYS),
> + .length = L4_24XX_SIZE,
> + .type = MT_DEVICE
It would be good to transition all of the OMAP structure initializations
over to using a trailing ',' on the last initializer as per the rest of
the kernel source. Having that additional ',' makes script based
rewriting of the contents of structures a lot easier, and reduces the
chances of patches clashing.
I'm not suggesting it as something that needs to be done now though.
next prev parent reply other threads:[~2008-10-09 14:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 12:09 [PATCH 0/0] Add minimal omap34xx support Tony Lindgren
2008-10-03 12:09 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Tony Lindgren
2008-10-03 12:09 ` [PATCH 02/05] ARM: OMAP3: Add minimal Beagle board support Tony Lindgren
2008-10-03 12:09 ` [PATCH 03/05] ARM: OMAP3: Add Beagle defconfig Tony Lindgren
2008-10-03 12:09 ` [PATCH 04/05] ARM: OMAP2: Add support for the Gumstix Overo board (rev 3) Tony Lindgren
2008-10-03 12:09 ` [PATCH 05/05] ARM: OMAP2: defconfig " Tony Lindgren
2008-10-03 12:50 ` [PATCH 04/05] ARM: OMAP2: Add support " Tony Lindgren
2008-10-06 14:38 ` Tony Lindgren
2008-10-08 8:21 ` [PATCH 03/05] ARM: OMAP3: Add Beagle defconfig, v2 Tony Lindgren
2008-10-09 14:51 ` [PATCH 02/05] ARM: OMAP3: Add minimal Beagle board support Russell King - ARM Linux
2008-10-10 8:51 ` Tony Lindgren
2008-10-05 8:01 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Tony Lindgren
2008-10-06 14:35 ` Tony Lindgren
2008-10-08 8:19 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support, v2 Tony Lindgren
2008-10-09 14:47 ` Russell King - ARM Linux [this message]
2008-10-09 15:09 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Tony Lindgren
2008-10-03 15:52 ` [PATCH 0/0] Add minimal omap34xx support twebb
2008-10-04 7:05 ` Tony Lindgren
2008-10-04 12:42 ` twebb
2008-10-04 20:37 ` Felipe Balbi
2008-10-09 14:54 ` Russell King - ARM Linux
2008-10-09 15:17 ` Tony Lindgren
2008-10-10 7:32 ` Russell King - ARM Linux
2008-10-10 9:15 ` [PATCH] ARM: OMAP3: Add basic board support for OMAP LDP (Re: [PATCH 0/0] Add minimal omap34xx support) Tony Lindgren
2008-10-10 9:25 ` [PATCH] ARM: OMAP3: Add default kernel config " Tony Lindgren
2008-10-10 11:35 ` git pull request for minimal omap3 support one more time Tony Lindgren
2008-10-13 13:32 ` Russell King - ARM Linux
2008-10-14 17:19 ` Tony Lindgren
2008-10-14 18:51 ` Russell King - ARM Linux
2008-10-14 20:35 ` Tony Lindgren
2008-10-14 20:55 ` Tony Lindgren
2008-10-15 6:02 ` Jarkko Nikula
2008-10-15 18:34 ` Tony Lindgren
2008-10-08 7:50 ` git pull request for minimal omap3 support (Re: [PATCH 0/0] Add minimal omap34xx support) Tony Lindgren
2008-10-08 8:12 ` Tony Lindgren
2008-10-08 14:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009144737.GG435@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ext-adrian.hunter@nokia.com \
--cc=karthik-dp@ti.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=x0khasim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.