From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
twebb <taliaferro62@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org
Subject: Re: git pull request for minimal omap3 support one more time
Date: Wed, 15 Oct 2008 11:34:01 -0700 [thread overview]
Message-ID: <20081015183401.GM8150@atomide.com> (raw)
In-Reply-To: <20081015090250.d32cf7f7.jarkko.nikula@nokia.com>
Hi,
* Jarkko Nikula <jarkko.nikula@nokia.com> [081014 23:03]:
> On Tue, 14 Oct 2008 10:19:08 -0700
> "ext Tony Lindgren" <tony@atomide.com> wrote:
>
> > > Please take a look and resolve ASAP. Thanks.
> >
> > Sorry for the delay, I was sitting in an airplane again.
> >
> > Here's the fix, looks like the missing McBSP irqs should have been
> > merged into the recent McBSP patches.
> >
> > This patch is also in your patch system as 5301/1.
> >
> Tony,
>
> If my patch below from linux-omap was forgotten from original pull
> request, please note that it's required to add those rx/tx irqs into
> omap_mcbsp_platform_data structs in arch/arm/mach-omap2/mcbsp.c as
> well. Otherwise arch/arm/plat-omap/mcbsp.c: omap_mcbsp_request will
> fail when requesting zero defined irqs.
>
> Sorry, not noting this before.
>
>
> Jarkko
>
> commit c29cfcead32c8dcb9738a085d498aebe6ab160af
> Author: Jarkko Nikula <jarkko.nikula@nokia.com>
> Date: Tue Sep 16 15:56:53 2008 +0300
>
> ARM: OMAP: Add RX/TX interrupts for 2430 and 34xx McBSP ports 3-5
>
> Without RX and TX interrupt definitions, the omap_mcbsp_request will
> fail on OMAP2430 and OMAP34xx for ports 3-5 since default io_type is
> OMAP_MCBSP_IRQ_IO.
It's there, in Russell's omap-all branch. I just merged your fix
into your other patch:
commit 05228c35c67995c745ae3c768eaf90740c643fa9
Author: Jarkko Nikula <jarkko.nikula@nokia.com>
Date: Wed Oct 8 10:01:40 2008 +0300
ARM: OMAP: Add support for OMAP2430 in McBSP
Regards,
Tony
next prev parent reply other threads:[~2008-10-15 18:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 12:09 [PATCH 0/0] Add minimal omap34xx support Tony Lindgren
2008-10-03 12:09 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Tony Lindgren
2008-10-03 12:09 ` [PATCH 02/05] ARM: OMAP3: Add minimal Beagle board support Tony Lindgren
2008-10-03 12:09 ` [PATCH 03/05] ARM: OMAP3: Add Beagle defconfig Tony Lindgren
2008-10-03 12:09 ` [PATCH 04/05] ARM: OMAP2: Add support for the Gumstix Overo board (rev 3) Tony Lindgren
2008-10-03 12:09 ` [PATCH 05/05] ARM: OMAP2: defconfig " Tony Lindgren
2008-10-03 12:50 ` [PATCH 04/05] ARM: OMAP2: Add support " Tony Lindgren
2008-10-06 14:38 ` Tony Lindgren
2008-10-08 8:21 ` [PATCH 03/05] ARM: OMAP3: Add Beagle defconfig, v2 Tony Lindgren
2008-10-09 14:51 ` [PATCH 02/05] ARM: OMAP3: Add minimal Beagle board support Russell King - ARM Linux
2008-10-10 8:51 ` Tony Lindgren
2008-10-05 8:01 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Tony Lindgren
2008-10-06 14:35 ` Tony Lindgren
2008-10-08 8:19 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support, v2 Tony Lindgren
2008-10-09 14:47 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Russell King - ARM Linux
2008-10-09 15:09 ` Tony Lindgren
2008-10-03 15:52 ` [PATCH 0/0] Add minimal omap34xx support twebb
2008-10-04 7:05 ` Tony Lindgren
2008-10-04 12:42 ` twebb
2008-10-04 20:37 ` Felipe Balbi
2008-10-09 14:54 ` Russell King - ARM Linux
2008-10-09 15:17 ` Tony Lindgren
2008-10-10 7:32 ` Russell King - ARM Linux
2008-10-10 9:15 ` [PATCH] ARM: OMAP3: Add basic board support for OMAP LDP (Re: [PATCH 0/0] Add minimal omap34xx support) Tony Lindgren
2008-10-10 9:25 ` [PATCH] ARM: OMAP3: Add default kernel config " Tony Lindgren
2008-10-10 11:35 ` git pull request for minimal omap3 support one more time Tony Lindgren
2008-10-13 13:32 ` Russell King - ARM Linux
2008-10-14 17:19 ` Tony Lindgren
2008-10-14 18:51 ` Russell King - ARM Linux
2008-10-14 20:35 ` Tony Lindgren
2008-10-14 20:55 ` Tony Lindgren
2008-10-15 6:02 ` Jarkko Nikula
2008-10-15 18:34 ` Tony Lindgren [this message]
2008-10-08 7:50 ` git pull request for minimal omap3 support (Re: [PATCH 0/0] Add minimal omap34xx support) Tony Lindgren
2008-10-08 8:12 ` Tony Lindgren
2008-10-08 14:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081015183401.GM8150@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=taliaferro62@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.