All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: grundler@parisc-linux.org, linux-driver@qlogic.com,
	netdev@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit
Date: Tue, 14 Oct 2008 02:03:45 +0000	[thread overview]
Message-ID: <20081013.190345.20202604.davem@davemloft.net> (raw)
In-Reply-To: <20081014015455.GA25385@susedev.qlogic.org>

From: Ron Mercer <ron.mercer@qlogic.com>
Date: Mon, 13 Oct 2008 18:54:55 -0700

> Dave/Grant,
> I sent this earlier today but didn't see it on the netdev list.
> Thanks, Ron
> 
> This ASIC does support all page sizes. For 4k and 8k page size the TX control block needs an external scatter gather list.  For page sizes larger than 8k the max frags is satisfied by the original TX control block.
> 
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>

I'm not applying this.  I _explicitly_ said I would not apply a
solution like this.

I waited for you guys all day for this?!?!

We need to find a way to make this a Kconfig dependency.

Build failures are absolutely unacceptable.

People do randconfig, allyesconfig, allmodconfig, etc. for build
regression testing and that has to work no matter what page size gets
selected or is the default for a given platform.


WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: grundler@parisc-linux.org, linux-driver@qlogic.com,
	netdev@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure
Date: Mon, 13 Oct 2008 19:03:45 -0700 (PDT)	[thread overview]
Message-ID: <20081013.190345.20202604.davem@davemloft.net> (raw)
In-Reply-To: <20081014015455.GA25385@susedev.qlogic.org>

From: Ron Mercer <ron.mercer@qlogic.com>
Date: Mon, 13 Oct 2008 18:54:55 -0700

> Dave/Grant,
> I sent this earlier today but didn't see it on the netdev list.
> Thanks, Ron
> 
> This ASIC does support all page sizes. For 4k and 8k page size the TX control block needs an external scatter gather list.  For page sizes larger than 8k the max frags is satisfied by the original TX control block.
> 
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>

I'm not applying this.  I _explicitly_ said I would not apply a
solution like this.

I waited for you guys all day for this?!?!

We need to find a way to make this a Kconfig dependency.

Build failures are absolutely unacceptable.

People do randconfig, allyesconfig, allmodconfig, etc. for build
regression testing and that has to work no matter what page size gets
selected or is the default for a given platform.


  reply	other threads:[~2008-10-14  2:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  6:06 [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit Grant Grundler
2008-10-13  6:06 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Grant Grundler
2008-10-13  6:09 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-13  6:09   ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14  1:54   ` Ron Mercer
2008-10-14  1:54     ` Ron Mercer
2008-10-14  2:03     ` David Miller [this message]
2008-10-14  2:03       ` David Miller
2008-10-14  2:19       ` Matthew Wilcox
2008-10-14  2:19         ` Matthew Wilcox
2008-10-14  2:31         ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14  2:31           ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14  2:53           ` Ron Mercer
2008-10-14  2:53             ` Ron Mercer
2008-10-14  5:56             ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14  5:56               ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081013.190345.20202604.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=grundler@parisc-linux.org \
    --cc=linux-driver@qlogic.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ron.mercer@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.