From: Ron Mercer <ron.mercer@qlogic.com>
To: David Miller <davem@davemloft.net>
Cc: grundler@parisc-linux.org, linux-driver@qlogic.com,
netdev@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure
Date: Tue, 14 Oct 2008 01:54:55 +0000 [thread overview]
Message-ID: <20081014015455.GA25385@susedev.qlogic.org> (raw)
In-Reply-To: <20081012.230939.240550430.davem@davemloft.net>
Dave/Grant,
I sent this earlier today but didn't see it on the netdev list.
Thanks, Ron
This ASIC does support all page sizes. For 4k and 8k page size the TX control block needs an external scatter gather list. For page sizes larger than 8k the max frags is satisfied by the original TX control block.
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/qlge/qlge.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index c37ea43..38116f9 100644
--- a/drivers/net/qlge/qlge.h
+++ b/drivers/net/qlge/qlge.h
@@ -58,7 +58,7 @@
*/
#if (PAGE_SHIFT = 12) || (PAGE_SHIFT = 13) /* 4k & 8k pages */
#define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2)
-#elif (PAGE_SHIFT = 16) /* 64k pages */
+#else /* all other page sizes */
#define TX_DESC_PER_OAL 0
#endif
--
1.6.0
WARNING: multiple messages have this Message-ID (diff)
From: Ron Mercer <ron.mercer@qlogic.com>
To: David Miller <davem@davemloft.net>
Cc: grundler@parisc-linux.org, linux-driver@qlogic.com,
netdev@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure
Date: Mon, 13 Oct 2008 18:54:55 -0700 [thread overview]
Message-ID: <20081014015455.GA25385@susedev.qlogic.org> (raw)
In-Reply-To: <20081012.230939.240550430.davem@davemloft.net>
Dave/Grant,
I sent this earlier today but didn't see it on the netdev list.
Thanks, Ron
This ASIC does support all page sizes. For 4k and 8k page size the TX control block needs an external scatter gather list. For page sizes larger than 8k the max frags is satisfied by the original TX control block.
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/qlge/qlge.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index c37ea43..38116f9 100644
--- a/drivers/net/qlge/qlge.h
+++ b/drivers/net/qlge/qlge.h
@@ -58,7 +58,7 @@
*/
#if (PAGE_SHIFT == 12) || (PAGE_SHIFT == 13) /* 4k & 8k pages */
#define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2)
-#elif (PAGE_SHIFT == 16) /* 64k pages */
+#else /* all other page sizes */
#define TX_DESC_PER_OAL 0
#endif
--
1.6.0
next prev parent reply other threads:[~2008-10-14 1:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 6:06 [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit Grant Grundler
2008-10-13 6:06 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Grant Grundler
2008-10-13 6:09 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-13 6:09 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14 1:54 ` Ron Mercer [this message]
2008-10-14 1:54 ` Ron Mercer
2008-10-14 2:03 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14 2:03 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14 2:19 ` Matthew Wilcox
2008-10-14 2:19 ` Matthew Wilcox
2008-10-14 2:31 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14 2:31 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
2008-10-14 2:53 ` Ron Mercer
2008-10-14 2:53 ` Ron Mercer
2008-10-14 5:56 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14 5:56 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014015455.GA25385@susedev.qlogic.org \
--to=ron.mercer@qlogic.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=linux-driver@qlogic.com \
--cc=linux-ia64@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.