From: Nathan Froyd <froydnj@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable
Date: Tue, 14 Oct 2008 05:57:11 -0700 [thread overview]
Message-ID: <20081014125710.GI18389@codesourcery.com> (raw)
In-Reply-To: <48F46265.3000007@siemens.com>
On Tue, Oct 14, 2008 at 11:12:05AM +0200, Jan Kiszka wrote:
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
> #else
> else if (n < 64) {
> /* f0-f31 */
> - uint32_t fpr;
> -
> env->fpr[n] = ldfl_p(mem_buf);
> return 4;
> } else if (n < 80) {
And if somebody wanted to fix that to return 8 instead of 4, that'd be
great too. :)
-Nathan
next prev parent reply other threads:[~2008-10-14 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 9:12 [Qemu-devel] [PATCH] gdbstub: remove unused local variable Jan Kiszka
2008-10-14 12:57 ` Nathan Froyd [this message]
2008-10-14 15:50 ` Aurelien Jarno
2008-10-14 16:01 ` Nathan Froyd
2008-10-14 19:23 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014125710.GI18389@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.