* [Qemu-devel] [PATCH] gdbstub: remove unused local variable
@ 2008-10-14 9:12 Jan Kiszka
2008-10-14 12:57 ` Nathan Froyd
2008-10-14 19:23 ` Aurelien Jarno
0 siblings, 2 replies; 5+ messages in thread
From: Jan Kiszka @ 2008-10-14 9:12 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
gdbstub.c | 2 --
1 file changed, 2 deletions(-)
Index: b/gdbstub.c
===================================================================
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
#else
else if (n < 64) {
/* f0-f31 */
- uint32_t fpr;
-
env->fpr[n] = ldfl_p(mem_buf);
return 4;
} else if (n < 80) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable
2008-10-14 9:12 [Qemu-devel] [PATCH] gdbstub: remove unused local variable Jan Kiszka
@ 2008-10-14 12:57 ` Nathan Froyd
2008-10-14 15:50 ` Aurelien Jarno
2008-10-14 19:23 ` Aurelien Jarno
1 sibling, 1 reply; 5+ messages in thread
From: Nathan Froyd @ 2008-10-14 12:57 UTC (permalink / raw)
To: qemu-devel
On Tue, Oct 14, 2008 at 11:12:05AM +0200, Jan Kiszka wrote:
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
> #else
> else if (n < 64) {
> /* f0-f31 */
> - uint32_t fpr;
> -
> env->fpr[n] = ldfl_p(mem_buf);
> return 4;
> } else if (n < 80) {
And if somebody wanted to fix that to return 8 instead of 4, that'd be
great too. :)
-Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable
2008-10-14 12:57 ` Nathan Froyd
@ 2008-10-14 15:50 ` Aurelien Jarno
2008-10-14 16:01 ` Nathan Froyd
0 siblings, 1 reply; 5+ messages in thread
From: Aurelien Jarno @ 2008-10-14 15:50 UTC (permalink / raw)
To: qemu-devel
On Tue, Oct 14, 2008 at 05:57:11AM -0700, Nathan Froyd wrote:
> On Tue, Oct 14, 2008 at 11:12:05AM +0200, Jan Kiszka wrote:
> > --- a/gdbstub.c
> > +++ b/gdbstub.c
> > @@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
> > #else
> > else if (n < 64) {
> > /* f0-f31 */
> > - uint32_t fpr;
> > -
> > env->fpr[n] = ldfl_p(mem_buf);
> > return 4;
> > } else if (n < 80) {
>
> And if somebody wanted to fix that to return 8 instead of 4, that'd be
> great too. :)
>
What's the rational behind that? AFAIK f0-f31 "registers" are 32-bit
"registers", even on SPARC64.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable
2008-10-14 15:50 ` Aurelien Jarno
@ 2008-10-14 16:01 ` Nathan Froyd
0 siblings, 0 replies; 5+ messages in thread
From: Nathan Froyd @ 2008-10-14 16:01 UTC (permalink / raw)
To: qemu-devel
On Tue, Oct 14, 2008 at 05:50:31PM +0200, Aurelien Jarno wrote:
> On Tue, Oct 14, 2008 at 05:57:11AM -0700, Nathan Froyd wrote:
> > And if somebody wanted to fix that to return 8 instead of 4, that'd be
> > great too. :)
> >
>
> What's the rational behind that? AFAIK f0-f31 "registers" are 32-bit
> "registers", even on SPARC64.
Sorry, wrong CPU. I didn't look at the wider context, my mistake.
-Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable
2008-10-14 9:12 [Qemu-devel] [PATCH] gdbstub: remove unused local variable Jan Kiszka
2008-10-14 12:57 ` Nathan Froyd
@ 2008-10-14 19:23 ` Aurelien Jarno
1 sibling, 0 replies; 5+ messages in thread
From: Aurelien Jarno @ 2008-10-14 19:23 UTC (permalink / raw)
To: qemu-devel
Thanks, applied.
On Tue, Oct 14, 2008 at 11:12:05AM +0200, Jan Kiszka wrote:
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> gdbstub.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: b/gdbstub.c
> ===================================================================
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
> #else
> else if (n < 64) {
> /* f0-f31 */
> - uint32_t fpr;
> -
> env->fpr[n] = ldfl_p(mem_buf);
> return 4;
> } else if (n < 80) {
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-10-14 19:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-14 9:12 [Qemu-devel] [PATCH] gdbstub: remove unused local variable Jan Kiszka
2008-10-14 12:57 ` Nathan Froyd
2008-10-14 15:50 ` Aurelien Jarno
2008-10-14 16:01 ` Nathan Froyd
2008-10-14 19:23 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.