[PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined

[PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined

[Venki Pallipadi]

When I7300_idle driver is not configured, there is a compile time
warning about IDLE_IOAT_CHANNEL not defined. Fix it.

Reported-by: Suresh Siddha <suresh.b.siddha@intel.com>

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

---
 drivers/dma/ioat_dma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/dma/ioat_dma.c
===================================================================
--- linux-2.6.orig/drivers/dma/ioat_dma.c	2008-10-23 15:27:43.000000000 -0700
+++ linux-2.6/drivers/dma/ioat_dma.c	2008-10-23 15:28:03.000000000 -0700
@@ -171,7 +171,7 @@ static int ioat_dma_enumerate_channels(s
 	xfercap_scale = readb(device->reg_base + IOAT_XFERCAP_OFFSET);
 	xfercap = (xfercap_scale == 0 ? -1 : (1UL << xfercap_scale));
 
-#if CONFIG_I7300_IDLE_IOAT_CHANNEL
+#ifdef CONFIG_I7300_IDLE_IOAT_CHANNEL
 	device->common.chancnt--;
 #endif
 	for (i = 0; i < device->common.chancnt; i++) {

Re: [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined

[Len Brown]

applied.

thanks,
-len

On Thu, 23 Oct 2008, Venki Pallipadi wrote:

> 
> When I7300_idle driver is not configured, there is a compile time
> warning about IDLE_IOAT_CHANNEL not defined. Fix it.
> 
> Reported-by: Suresh Siddha <suresh.b.siddha@intel.com>
> 
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> 
> ---
>  drivers/dma/ioat_dma.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/drivers/dma/ioat_dma.c
> ===================================================================
> --- linux-2.6.orig/drivers/dma/ioat_dma.c	2008-10-23 15:27:43.000000000 -0700
> +++ linux-2.6/drivers/dma/ioat_dma.c	2008-10-23 15:28:03.000000000 -0700
> @@ -171,7 +171,7 @@ static int ioat_dma_enumerate_channels(s
>  	xfercap_scale = readb(device->reg_base + IOAT_XFERCAP_OFFSET);
>  	xfercap = (xfercap_scale == 0 ? -1 : (1UL << xfercap_scale));
>  
> -#if CONFIG_I7300_IDLE_IOAT_CHANNEL
> +#ifdef CONFIG_I7300_IDLE_IOAT_CHANNEL
>  	device->common.chancnt--;
>  #endif
>  	for (i = 0; i < device->common.chancnt; i++) {
> 

Re: [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined

[Dan Williams]

On Thu, Oct 23, 2008 at 3:39 PM, Venki Pallipadi
<venkatesh.pallipadi@intel.com> wrote:
>
> When I7300_idle driver is not configured, there is a compile time
> warning about IDLE_IOAT_CHANNEL not defined. Fix it.
>

Please copy Maciej and myself on ioat changes.

Thanks,
Dan

[PATCH] memory power in config; show up only when it applies

[Venki Pallipadi]

Len,

One more one line patch.

Thanks,
Venki


Repair the config option for I7300_IDLE. The menu will now only show up when
applicable.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

---
 drivers/idle/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/idle/Kconfig
===================================================================
--- linux-2.6.orig/drivers/idle/Kconfig	2008-10-24 09:06:00.000000000 -0700
+++ linux-2.6/drivers/idle/Kconfig	2008-10-24 10:48:09.000000000 -0700
@@ -1,5 +1,6 @@
 
 menu "Memory power savings"
+depends on X86_64
 
 config I7300_IDLE_IOAT_CHANNEL
 	bool
@@ -7,7 +8,6 @@ config I7300_IDLE_IOAT_CHANNEL
 config I7300_IDLE
 	tristate "Intel chipset idle power saving driver"
 	select I7300_IDLE_IOAT_CHANNEL
-	depends on X86_64
 	help
 	  Enable idle power savings with certain Intel server chipsets.
 	  The chipset must have I/O AT support, such as the Intel 7300.