* [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined
@ 2008-10-23 22:39 Venki Pallipadi
2008-10-24 17:02 ` Len Brown
2008-10-24 17:53 ` [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined Dan Williams
0 siblings, 2 replies; 4+ messages in thread
From: Venki Pallipadi @ 2008-10-23 22:39 UTC (permalink / raw)
To: Len Brown; +Cc: linux-kernel, linux-acpi, Andrew Morton
When I7300_idle driver is not configured, there is a compile time
warning about IDLE_IOAT_CHANNEL not defined. Fix it.
Reported-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
---
drivers/dma/ioat_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/drivers/dma/ioat_dma.c
===================================================================
--- linux-2.6.orig/drivers/dma/ioat_dma.c 2008-10-23 15:27:43.000000000 -0700
+++ linux-2.6/drivers/dma/ioat_dma.c 2008-10-23 15:28:03.000000000 -0700
@@ -171,7 +171,7 @@ static int ioat_dma_enumerate_channels(s
xfercap_scale = readb(device->reg_base + IOAT_XFERCAP_OFFSET);
xfercap = (xfercap_scale == 0 ? -1 : (1UL << xfercap_scale));
-#if CONFIG_I7300_IDLE_IOAT_CHANNEL
+#ifdef CONFIG_I7300_IDLE_IOAT_CHANNEL
device->common.chancnt--;
#endif
for (i = 0; i < device->common.chancnt; i++) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined
2008-10-23 22:39 [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined Venki Pallipadi
@ 2008-10-24 17:02 ` Len Brown
2008-10-24 18:00 ` [PATCH] memory power in config; show up only when it applies Venki Pallipadi
2008-10-24 17:53 ` [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined Dan Williams
1 sibling, 1 reply; 4+ messages in thread
From: Len Brown @ 2008-10-24 17:02 UTC (permalink / raw)
To: Venki Pallipadi; +Cc: linux-kernel, linux-acpi, Andrew Morton
applied.
thanks,
-len
On Thu, 23 Oct 2008, Venki Pallipadi wrote:
>
> When I7300_idle driver is not configured, there is a compile time
> warning about IDLE_IOAT_CHANNEL not defined. Fix it.
>
> Reported-by: Suresh Siddha <suresh.b.siddha@intel.com>
>
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
> ---
> drivers/dma/ioat_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/dma/ioat_dma.c
> ===================================================================
> --- linux-2.6.orig/drivers/dma/ioat_dma.c 2008-10-23 15:27:43.000000000 -0700
> +++ linux-2.6/drivers/dma/ioat_dma.c 2008-10-23 15:28:03.000000000 -0700
> @@ -171,7 +171,7 @@ static int ioat_dma_enumerate_channels(s
> xfercap_scale = readb(device->reg_base + IOAT_XFERCAP_OFFSET);
> xfercap = (xfercap_scale == 0 ? -1 : (1UL << xfercap_scale));
>
> -#if CONFIG_I7300_IDLE_IOAT_CHANNEL
> +#ifdef CONFIG_I7300_IDLE_IOAT_CHANNEL
> device->common.chancnt--;
> #endif
> for (i = 0; i < device->common.chancnt; i++) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] memory power in config; show up only when it applies
2008-10-24 17:02 ` Len Brown
@ 2008-10-24 18:00 ` Venki Pallipadi
0 siblings, 0 replies; 4+ messages in thread
From: Venki Pallipadi @ 2008-10-24 18:00 UTC (permalink / raw)
To: Len Brown
Cc: Pallipadi, Venkatesh, linux-kernel, linux-acpi@vger.kernel.org,
Andrew Morton
Len,
One more one line patch.
Thanks,
Venki
Repair the config option for I7300_IDLE. The menu will now only show up when
applicable.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
---
drivers/idle/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/drivers/idle/Kconfig
===================================================================
--- linux-2.6.orig/drivers/idle/Kconfig 2008-10-24 09:06:00.000000000 -0700
+++ linux-2.6/drivers/idle/Kconfig 2008-10-24 10:48:09.000000000 -0700
@@ -1,5 +1,6 @@
menu "Memory power savings"
+depends on X86_64
config I7300_IDLE_IOAT_CHANNEL
bool
@@ -7,7 +8,6 @@ config I7300_IDLE_IOAT_CHANNEL
config I7300_IDLE
tristate "Intel chipset idle power saving driver"
select I7300_IDLE_IOAT_CHANNEL
- depends on X86_64
help
Enable idle power savings with certain Intel server chipsets.
The chipset must have I/O AT support, such as the Intel 7300.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined
2008-10-23 22:39 [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined Venki Pallipadi
2008-10-24 17:02 ` Len Brown
@ 2008-10-24 17:53 ` Dan Williams
1 sibling, 0 replies; 4+ messages in thread
From: Dan Williams @ 2008-10-24 17:53 UTC (permalink / raw)
To: Venki Pallipadi
Cc: Len Brown, linux-kernel, linux-acpi, Andrew Morton,
Sosnowski, Maciej
On Thu, Oct 23, 2008 at 3:39 PM, Venki Pallipadi
<venkatesh.pallipadi@intel.com> wrote:
>
> When I7300_idle driver is not configured, there is a compile time
> warning about IDLE_IOAT_CHANNEL not defined. Fix it.
>
Please copy Maciej and myself on ioat changes.
Thanks,
Dan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-24 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-23 22:39 [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined Venki Pallipadi
2008-10-24 17:02 ` Len Brown
2008-10-24 18:00 ` [PATCH] memory power in config; show up only when it applies Venki Pallipadi
2008-10-24 17:53 ` [PATCH] Fix compile warning CONFIG_I7300_IDLE_IOAT_CHANNEL not defined Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.