All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: sukadev@linux.vnet.ibm.com,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Pavel Emelyanov <xemul@openvz.org>,
	daniel@hozac.com, Nadia Derbey <Nadia.Derbey@bull.net>,
	clg@fr.ibm.com, Containers <containers@lists.osdl.org>,
	sukadev@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: Signals to cinit
Date: Wed, 12 Nov 2008 10:53:19 -0600	[thread overview]
Message-ID: <20081112165319.GC14572@us.ibm.com> (raw)
In-Reply-To: <20081110193228.GA15519@redhat.com>

Quoting Oleg Nesterov (oleg@redhat.com):
> --- K-IS/kernel/signal.c~T	2008-11-10 19:21:17.000000000 +0100
> +++ K-IS/kernel/signal.c	2008-11-10 20:31:24.000000000 +0100
> @@ -798,11 +798,19 @@ static inline int legacy_queue(struct si
>  	return (sig < SIGRTMIN) && sigismember(&signals->signal, sig);
>  }
> 
> +#define SIG_FROM_USER	INT_MIN		/* MSB */
> +
>  static int send_signal(int sig, struct siginfo *info, struct task_struct *t,
>  			int group)
>  {
>  	struct sigpending *pending;
>  	struct sigqueue *q;
> +	int from_ancestor_ns;
> +
> +	from_ancestor_ns = !is_si_special(info) &&
> +		(info->si_signo | SIG_FROM_USER) &&

I assume you mean '&'?

> +		/* if t can't see us we are from parent ns */
> +		task_pid_nr_ns(current, t->current->nsproxy->pid_ns) <= 0;

This doesn't look so bad...  (but still looking through followup emails)

-serge

  parent reply	other threads:[~2008-11-12 16:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-01 18:05 Signals to cinit sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
     [not found] ` <20081101180505.GA24268-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-11-10 17:38   ` Oleg Nesterov
     [not found]     ` <20081110173839.GA11121-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-10 18:00       ` Oleg Nesterov
2008-11-10 19:32     ` Oleg Nesterov
2008-11-10 23:27       ` sukadev
2008-11-12 14:52         ` Oleg Nesterov
2008-11-12 16:12           ` Oleg Nesterov
2008-11-12 16:49           ` Serge E. Hallyn
2008-11-12 18:12             ` Sukadev Bhattiprolu
2008-11-12 19:06               ` Serge E. Hallyn
2008-11-11  2:24       ` sukadev
2008-11-12 15:05         ` Oleg Nesterov
2008-11-12 19:04           ` Sukadev Bhattiprolu
2008-11-14 17:26             ` Oleg Nesterov
2008-11-12 16:53       ` Serge E. Hallyn [this message]
2008-11-13 19:10       ` Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112165319.GC14572@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=Nadia.Derbey@bull.net \
    --cc=clg@fr.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=daniel@hozac.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=sukadev@us.ibm.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.