From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] (ata.mod) avoid passing grub_errno to upper layer
Date: Tue, 25 Nov 2008 22:17:17 +0100 [thread overview]
Message-ID: <200811252217.18586.okuji@enbug.org> (raw)
In-Reply-To: <20081122153509.GA576@thorin>
On Saturday 22 November 2008 16:35:09 Robert Millan wrote:
> When an error is detected by ata.mod during drive scan, it will pass it to
> the upper layer. This results in GRUB aborting when trying to enter normal
> mode, even if the error is not critical (e.g. affects a drive not used
> during boot).
>
> There are a number of places in ata.mod where these errors could be
> handled, so I'm not sure if my proposed change would be the best approach.
> Some comment would be appreciated.
This is one way, but I think the upper layer should be more robust against
errors raised from modules. For example, we can unload a module, and clear
GRUB_ERRNO, if the init function in this module return an error.
Regards,
Okuji
next prev parent reply other threads:[~2008-11-25 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 15:35 [PATCH] (ata.mod) avoid passing grub_errno to upper layer Robert Millan
2008-11-25 21:17 ` Yoshinori K. Okuji [this message]
2008-11-28 19:37 ` Robert Millan
2008-11-29 10:01 ` Vesa Jääskeläinen
2008-11-29 12:48 ` Robert Millan
2008-11-29 18:37 ` Robert Millan
2008-11-29 21:06 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811252217.18586.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.