Re: [PATCH] (ata.mod) avoid passing grub_errno to upper layer

[Robert Millan <rmh@aybabtu.com>]

Committed (after repeating the same block for both calls, as Vesa suggested
on IRC).

On Sat, Nov 29, 2008 at 07:37:46PM +0100, Robert Millan wrote:
> 
> Okay, I think I got what you mean.  So how about this one?
> 
> -- 
> Robert Millan
> 
>   The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>   how) you may access your data; but nobody's threatening your freedom: we
>   still allow you to remove your data and not access it at all."

> 2008-11-29  Robert Millan  <rmh@aybabtu.com>
> 
> 	* disk/ata.c (grub_ata_pciinit): Handle errors rised by
> 	grub_ata_device_initialize() calls.
> 
> Index: disk/ata.c
> ===================================================================
> --- disk/ata.c	(revision 1929)
> +++ disk/ata.c	(working copy)
> @@ -542,6 +542,16 @@ grub_ata_pciinit (int bus, int device, i
>  	{
>  	  grub_ata_device_initialize (controller * 2 + i, 0, rega, regb);
>  	  grub_ata_device_initialize (controller * 2 + i, 1, rega, regb);
> +
> +	  /* Most errors rised by grub_ata_device_initialize() are harmless.
> +	     They just indicate this particular drive is not responding, most
> +	     likely because it doesn't exist.  We might want to ignore specific
> +	     error types here, instead of printing them.  */
> +	  if (grub_errno)
> +	    {
> +	      grub_print_error ();
> +	      grub_errno = GRUB_ERR_NONE;
> +	    }
>  	}
>      }
>  

> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."