From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: GPIO: Fix probe() error return in gpio driver probes
Date: Sun, 14 Dec 2008 16:11:17 -0800 [thread overview]
Message-ID: <200812141611.17555.david-b@pacbell.net> (raw)
In-Reply-To: <20081214213349.GA19483-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
On Sunday 14 December 2008, Ben Dooks wrote:
> Has anyone reveiwed this patch? Are there any comments, or can this
> be commited at somepoint (even if it is during the next merge window)?
I was thinking that -EINVAL is almost the least informative
diagnostic code possible, since so many places return it
that it's usually hard to find out *which* invalid parameter
triggered ...
Is there a less-overloaded code you could return?
I have no issue with the patch other than that.
- Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: GPIO: Fix probe() error return in gpio driver probes
Date: Sun, 14 Dec 2008 16:11:17 -0800 [thread overview]
Message-ID: <200812141611.17555.david-b@pacbell.net> (raw)
In-Reply-To: <20081214213349.GA19483@fluff.org.uk>
On Sunday 14 December 2008, Ben Dooks wrote:
> Has anyone reveiwed this patch? Are there any comments, or can this
> be commited at somepoint (even if it is during the next merge window)?
I was thinking that -EINVAL is almost the least informative
diagnostic code possible, since so many places return it
that it's usually hard to find out *which* invalid parameter
triggered ...
Is there a less-overloaded code you could return?
I have no issue with the patch other than that.
- Dave
next prev parent reply other threads:[~2008-12-15 0:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 15:24 GPIO: Fix probe() error return in gpio driver probes Ben Dooks
2008-12-12 15:24 ` Ben Dooks
[not found] ` <20081212152426.745254309-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-12-14 21:33 ` Ben Dooks
2008-12-14 21:33 ` Ben Dooks
[not found] ` <20081214213349.GA19483-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-12-15 0:11 ` David Brownell [this message]
2008-12-15 0:11 ` David Brownell
[not found] ` <200812141611.17555.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-12-15 7:46 ` Jean Delvare
2008-12-15 7:46 ` Jean Delvare
[not found] ` <20081215084600.5d237fea-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-12-15 10:16 ` Ben Dooks
2008-12-15 10:16 ` Ben Dooks
[not found] ` <20081215101616.GB12431-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-12-15 10:22 ` Jean Delvare
2008-12-15 10:22 ` Jean Delvare
[not found] ` <20081215112226.18f7fb29-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-12-18 18:16 ` David Brownell
2008-12-18 18:16 ` David Brownell
[not found] ` <200812181016.28184.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-12-18 22:29 ` Ben Dooks
2008-12-18 22:29 ` Ben Dooks
2008-12-15 10:15 ` Ben Dooks
2008-12-15 10:15 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 12:56 ben-elnMNo+KYs3pIgCt6eIbzw
2009-01-07 12:56 ` ben
[not found] ` <20090107125619.052023040-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-01-08 12:20 ` Ben Dooks
2009-01-08 12:20 ` Ben Dooks
2009-01-07 13:03 Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812141611.17555.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.