From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: GPIO: Fix probe() error return in gpio driver probes
Date: Thu, 8 Jan 2009 12:20:22 +0000 [thread overview]
Message-ID: <20090108122022.GO12431@fluff.org.uk> (raw)
In-Reply-To: <20090107125619.052023040-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
On Wed, Jan 07, 2009 at 12:56:19PM +0000, ben-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org wrote:
> A number of drivers in drivers/gpio return -ENODEV when confronted
> with missing setup parameters such as the platform data. However,
> returning -ENODEV causes the driver layer to silently ignore the
> driver as it assumes the probe did not find anything and was only
> speculative.
>
> To make life easier to discern why a driver is not being attached,
> change to returning -EINVAL, which is a better description of the
> fact that the driver data was not valid.
>
> Also add a set of dev_dbg() statements to the error paths to provide
> an better explanation of the error as there may be more that one point
> in the driver.
sorry, sent from the wrong email address please ignore.
--
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Cc: david-b@pacbell.net, linux-i2c@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: GPIO: Fix probe() error return in gpio driver probes
Date: Thu, 8 Jan 2009 12:20:22 +0000 [thread overview]
Message-ID: <20090108122022.GO12431@fluff.org.uk> (raw)
In-Reply-To: <20090107125619.052023040@fluff.org.uk>
On Wed, Jan 07, 2009 at 12:56:19PM +0000, ben@fluff.org.uk wrote:
> A number of drivers in drivers/gpio return -ENODEV when confronted
> with missing setup parameters such as the platform data. However,
> returning -ENODEV causes the driver layer to silently ignore the
> driver as it assumes the probe did not find anything and was only
> speculative.
>
> To make life easier to discern why a driver is not being attached,
> change to returning -EINVAL, which is a better description of the
> fact that the driver data was not valid.
>
> Also add a set of dev_dbg() statements to the error paths to provide
> an better explanation of the error as there may be more that one point
> in the driver.
sorry, sent from the wrong email address please ignore.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2009-01-08 12:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 12:56 GPIO: Fix probe() error return in gpio driver probes ben-elnMNo+KYs3pIgCt6eIbzw
2009-01-07 12:56 ` ben
[not found] ` <20090107125619.052023040-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-01-08 12:20 ` Ben Dooks [this message]
2009-01-08 12:20 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 13:03 Ben Dooks
2008-12-12 15:24 Ben Dooks
2008-12-12 15:24 ` Ben Dooks
[not found] ` <20081212152426.745254309-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-12-14 21:33 ` Ben Dooks
2008-12-14 21:33 ` Ben Dooks
[not found] ` <20081214213349.GA19483-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-12-15 0:11 ` David Brownell
2008-12-15 0:11 ` David Brownell
[not found] ` <200812141611.17555.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-12-15 7:46 ` Jean Delvare
2008-12-15 7:46 ` Jean Delvare
[not found] ` <20081215084600.5d237fea-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-12-15 10:16 ` Ben Dooks
2008-12-15 10:16 ` Ben Dooks
[not found] ` <20081215101616.GB12431-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-12-15 10:22 ` Jean Delvare
2008-12-15 10:22 ` Jean Delvare
[not found] ` <20081215112226.18f7fb29-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-12-18 18:16 ` David Brownell
2008-12-18 18:16 ` David Brownell
[not found] ` <200812181016.28184.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-12-18 22:29 ` Ben Dooks
2008-12-18 22:29 ` Ben Dooks
2008-12-15 10:15 ` Ben Dooks
2008-12-15 10:15 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108122022.GO12431@fluff.org.uk \
--to=ben-linux-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.