All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v5] spi: Add PPC4xx SPI driver
Date: Sat, 27 Dec 2008 11:32:25 -0800	[thread overview]
Message-ID: <200812271132.25468.david-b@pacbell.net> (raw)
In-Reply-To: <1227628088-10849-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>

Also:

> +static struct of_platform_driver spi_ppc4xx_of_driver = {
> +       .owner = THIS_MODULE,
> +       .name = DRIVER_NAME,

I'd hope the PPC folk eliminate this duplication soonish.
Those fields are obvious duplicates of the driver model
fields...


> +       .match_table = spi_ppc4xx_of_match,
> +       .probe = spi_ppc4xx_of_probe,
> +       .remove = __exit_p(spi_ppc4xx_of_remove),
> +       .driver = {
> +               .name = DRIVER_NAME,
> +               .owner = THIS_MODULE,
> +       },
> +};



------------------------------------------------------------------------------

WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v5] spi: Add PPC4xx SPI driver
Date: Sat, 27 Dec 2008 11:32:25 -0800	[thread overview]
Message-ID: <200812271132.25468.david-b@pacbell.net> (raw)
In-Reply-To: <1227628088-10849-1-git-send-email-sr@denx.de>

Also:

> +static struct of_platform_driver spi_ppc4xx_of_driver = {
> +       .owner = THIS_MODULE,
> +       .name = DRIVER_NAME,

I'd hope the PPC folk eliminate this duplication soonish.
Those fields are obvious duplicates of the driver model
fields...


> +       .match_table = spi_ppc4xx_of_match,
> +       .probe = spi_ppc4xx_of_probe,
> +       .remove = __exit_p(spi_ppc4xx_of_remove),
> +       .driver = {
> +               .name = DRIVER_NAME,
> +               .owner = THIS_MODULE,
> +       },
> +};

  parent reply	other threads:[~2008-12-27 19:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 15:48 [PATCH v5] spi: Add PPC4xx SPI driver Stefan Roese
2008-11-25 15:48 ` Stefan Roese
2008-12-09 21:48 ` Steven A. Falco
2008-12-09 22:14   ` Steven A. Falco
     [not found] ` <1227628088-10849-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2008-12-27 19:30   ` David Brownell
2008-12-27 19:30     ` David Brownell
     [not found]     ` <200812271130.12513.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-01-05 18:12       ` Stefan Roese
2009-01-05 18:12     ` Stefan Roese
2009-01-05 18:12     ` Stefan Roese
     [not found]       ` <200901051912.25874.sr-ynQEQJNshbs@public.gmane.org>
2009-01-05 19:31         ` Wolfgang Denk
2009-01-05 19:31           ` Wolfgang Denk
     [not found]           ` <20090105193117.E5AD98387CDB-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
2009-01-06  8:26             ` Stefan Roese
2009-01-06  8:26           ` Stefan Roese
2009-01-06  8:26           ` Stefan Roese
2008-12-27 19:32   ` David Brownell [this message]
2008-12-27 19:32     ` David Brownell
2008-12-27 21:36     ` Stephen Rothwell
2008-12-27 21:36       ` Stephen Rothwell
2009-01-06  2:06   ` Anton Vorontsov
2009-01-06  2:06     ` [spi-devel-general] " Anton Vorontsov
     [not found]     ` <20090106020603.GA14074-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-01-06  8:14       ` Stefan Roese
2009-01-06  8:14         ` [spi-devel-general] " Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812271132.25468.david-b@pacbell.net \
    --to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=sr-ynQEQJNshbs@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.