From: Ingo Molnar <mingo@elte.hu>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] tip - Solution of ath9k: turn off temporarily (66b5c4a2c638b5a69d3e41abe4a2bae55035a92e)
Date: Fri, 2 Jan 2009 19:07:30 +0100 [thread overview]
Message-ID: <20090102180730.GA10072@elte.hu> (raw)
In-Reply-To: <3f9a31f40901020936l4bed87e2jb64678572d2ad45b@mail.gmail.com>
* Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:
> Hello Ingo,
>
> If you choose :
> CONFIG_RFKILL=m
> CONFIG_ATH9K=y
>
> It will give linking error because ATH9K need RFKILL functions.
>
> But if you choose :
> CONFIG_RFKILL=y
> CONFIG_ATH9K=y
>
> OR
>
> CONFIG_RFKILL=m
> CONFIG_ATH9K=m
>
> It is OK.
this was just a quick hatchet job to make the build regression go away.
Would you like to send a real fix, with the wireless list and maintainers
Cc-ed? Then i can revert the hack below from tip/out-of-tree.
ngo
------------------>
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Cc: x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ath9k-devel@venema.h4ckr.net
Subject: Re: tip - Solution of ath9k: turn off temporarily (66b5c4a2c638b5a69d3e41abe4a2bae55035a92e)
Date: Fri, 2 Jan 2009 19:07:30 +0100 [thread overview]
Message-ID: <20090102180730.GA10072@elte.hu> (raw)
In-Reply-To: <3f9a31f40901020936l4bed87e2jb64678572d2ad45b@mail.gmail.com>
* Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:
> Hello Ingo,
>
> If you choose :
> CONFIG_RFKILL=m
> CONFIG_ATH9K=y
>
> It will give linking error because ATH9K need RFKILL functions.
>
> But if you choose :
> CONFIG_RFKILL=y
> CONFIG_ATH9K=y
>
> OR
>
> CONFIG_RFKILL=m
> CONFIG_ATH9K=m
>
> It is OK.
this was just a quick hatchet job to make the build regression go away.
Would you like to send a real fix, with the wireless list and maintainers
Cc-ed? Then i can revert the hack below from tip/out-of-tree.
ngo
------------------>
>From 66b5c4a2c638b5a69d3e41abe4a2bae55035a92e Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 2 Jan 2009 16:04:03 +0100
Subject: [PATCH] ath9k: turn off temporarily
Impact: fix build failure
ath9k fails to build:
drivers/built-in.o: In function `ath_detach':
main.c:(.text+0x16720b): undefined reference to `rfkill_unregister'
drivers/built-in.o: In function `ath_rfkill_poll':
main.c:(.text+0x167801): undefined reference to `rfkill_force_state'
drivers/built-in.o: In function `ath9k_start':
main.c:(.text+0x167f01): undefined reference to `rfkill_register'
main.c:(.text+0x167f11): undefined reference to `rfkill_free'
drivers/built-in.o: In function `ath_pci_probe':
main.c:(.text+0x169754): undefined reference to `rfkill_allocate'
when:
CONFIG_RFKILL=m
CONFIG_ATH9K=y
---
drivers/net/wireless/ath9k/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath9k/Kconfig b/drivers/net/wireless/ath9k/Kconfig
index c43bd32..b849a45 100644
--- a/drivers/net/wireless/ath9k/Kconfig
+++ b/drivers/net/wireless/ath9k/Kconfig
@@ -1,6 +1,8 @@
config ATH9K
tristate "Atheros 802.11n wireless cards support"
depends on PCI && MAC80211 && WLAN_80211
+ # build failures
+ depends on 0
select MAC80211_LEDS
select LEDS_CLASS
select NEW_LEDS
next prev parent reply other threads:[~2009-01-02 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 17:36 [ath9k-devel] tip - Solution of ath9k: turn off temporarily (66b5c4a2c638b5a69d3e41abe4a2bae55035a92e) Jaswinder Singh Rajput
2009-01-02 17:36 ` Jaswinder Singh Rajput
2009-01-02 18:07 ` Ingo Molnar [this message]
2009-01-02 18:07 ` Ingo Molnar
2009-01-02 18:40 ` [ath9k-devel] " Jaswinder Singh Rajput
2009-01-02 18:40 ` Jaswinder Singh Rajput
2009-01-02 18:40 ` Jaswinder Singh Rajput
2009-01-02 19:35 ` [ath9k-devel] " H. Peter Anvin
2009-01-02 19:35 ` H. Peter Anvin
2009-01-02 19:58 ` [ath9k-devel] " Ingo Molnar
2009-01-02 19:58 ` Ingo Molnar
2009-01-05 11:51 ` [ath9k-devel] [PATCH] ath9k: Enforce module build if rfkill is a module Jouni Malinen
2009-01-05 11:51 ` Jouni Malinen
2009-01-05 14:04 ` [ath9k-devel] " Ingo Molnar
2009-01-05 14:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102180730.GA10072@elte.hu \
--to=mingo@elte.hu \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.