All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jouni Malinen <jouni.malinen@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Enforce module build if rfkill is a module
Date: Mon, 5 Jan 2009 13:51:24 +0200	[thread overview]
Message-ID: <20090105115124.GA2235@jm.kir.nu> (raw)
In-Reply-To: <20090102195802.GA28494@elte.hu>

CONFIG_ATH9K=y results in build issues if CONFIG_RFKILL=m since ath9k
does not depend on rfkill in kconfig (i.e., CONFIG_RFKILL is used to
select whether to enable rfkill in ath9k), but uses its functions if
rfkill is enabled. Enforce ath9k to be build as a module if
CONFIG_RFKILL=m to avoid this invalid configuration.

Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>

---
 drivers/net/wireless/ath9k/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- wireless-testing.orig/drivers/net/wireless/ath9k/Kconfig	2009-01-05 13:27:01.000000000 +0200
+++ wireless-testing/drivers/net/wireless/ath9k/Kconfig	2009-01-05 13:36:27.000000000 +0200
@@ -1,6 +1,7 @@
 config ATH9K
 	tristate "Atheros 802.11n wireless cards support"
 	depends on PCI && MAC80211 && WLAN_80211
+	depends on RFKILL || RFKILL=n
 	select MAC80211_LEDS
 	select LEDS_CLASS
 	select NEW_LEDS

-- 
Jouni Malinen                                            PGP id EFC895FA

WARNING: multiple messages have this Message-ID (diff)
From: Jouni Malinen <jouni.malinen@atheros.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org
Subject: [PATCH] ath9k: Enforce module build if rfkill is a module
Date: Mon, 5 Jan 2009 13:51:24 +0200	[thread overview]
Message-ID: <20090105115124.GA2235@jm.kir.nu> (raw)
In-Reply-To: <20090102195802.GA28494@elte.hu>

CONFIG_ATH9K=y results in build issues if CONFIG_RFKILL=m since ath9k
does not depend on rfkill in kconfig (i.e., CONFIG_RFKILL is used to
select whether to enable rfkill in ath9k), but uses its functions if
rfkill is enabled. Enforce ath9k to be build as a module if
CONFIG_RFKILL=m to avoid this invalid configuration.

Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>

---
 drivers/net/wireless/ath9k/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- wireless-testing.orig/drivers/net/wireless/ath9k/Kconfig	2009-01-05 13:27:01.000000000 +0200
+++ wireless-testing/drivers/net/wireless/ath9k/Kconfig	2009-01-05 13:36:27.000000000 +0200
@@ -1,6 +1,7 @@
 config ATH9K
 	tristate "Atheros 802.11n wireless cards support"
 	depends on PCI && MAC80211 && WLAN_80211
+	depends on RFKILL || RFKILL=n
 	select MAC80211_LEDS
 	select LEDS_CLASS
 	select NEW_LEDS

-- 
Jouni Malinen                                            PGP id EFC895FA

  reply	other threads:[~2009-01-05 11:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-02 17:36 [ath9k-devel] tip - Solution of ath9k: turn off temporarily (66b5c4a2c638b5a69d3e41abe4a2bae55035a92e) Jaswinder Singh Rajput
2009-01-02 17:36 ` Jaswinder Singh Rajput
2009-01-02 18:07 ` [ath9k-devel] " Ingo Molnar
2009-01-02 18:07   ` Ingo Molnar
2009-01-02 18:40   ` [ath9k-devel] " Jaswinder Singh Rajput
2009-01-02 18:40     ` Jaswinder Singh Rajput
2009-01-02 18:40     ` Jaswinder Singh Rajput
2009-01-02 19:35     ` [ath9k-devel] " H. Peter Anvin
2009-01-02 19:35       ` H. Peter Anvin
2009-01-02 19:58       ` [ath9k-devel] " Ingo Molnar
2009-01-02 19:58         ` Ingo Molnar
2009-01-05 11:51         ` Jouni Malinen [this message]
2009-01-05 11:51           ` [PATCH] ath9k: Enforce module build if rfkill is a module Jouni Malinen
2009-01-05 14:04           ` [ath9k-devel] " Ingo Molnar
2009-01-05 14:04             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090105115124.GA2235@jm.kir.nu \
    --to=jouni.malinen@atheros.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.