Re: [PATCH] sparc: Clean arch-specific code in prom_common.c

[Sam Ravnborg <sam@ravnborg.org>]

On Sun, Jan 04, 2009 at 12:47:52PM +1100, Julian Calaby wrote:
> sparc: Clean arch-specific code in prom_common.c
> 
> prom_nextprop() and prom_firstprop() have slightly different calling 
> conventions in 32 and 64 bit SPARC.
> 
> prom_common.c uses a ifdef guard to ensure that these functions are 
> called correctly.
> 
> Adjust code to eliminate this ifdef by using a calling convention that 
> is compatible with both 32 and 64 bit SPARC.
> 
> Signed-off-by: Julian Calaby <julian.calaby@gmail.com>

Looks good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

As a natural next step you could eliminate the following:
#ifdef CONFIG_SPARC32
                strcpy(p->name, name);
#endif

by moving this strcpy() to the prom_* functions
for sparc32.

	Sam