All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc: Clean arch-specific code in prom_common.c
Date: Mon, 05 Jan 2009 08:07:29 +0000	[thread overview]
Message-ID: <20090105.000729.96111745.davem@davemloft.net> (raw)
In-Reply-To: <49601548.509@gmail.com>

From: Sam Ravnborg <sam@ravnborg.org>
Date: Sun, 4 Jan 2009 09:51:12 +0100

> On Sun, Jan 04, 2009 at 12:47:52PM +1100, Julian Calaby wrote:
> > sparc: Clean arch-specific code in prom_common.c
> > 
> > prom_nextprop() and prom_firstprop() have slightly different calling 
> > conventions in 32 and 64 bit SPARC.
> > 
> > prom_common.c uses a ifdef guard to ensure that these functions are 
> > called correctly.
> > 
> > Adjust code to eliminate this ifdef by using a calling convention that 
> > is compatible with both 32 and 64 bit SPARC.
> > 
> > Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
> 
> Looks good.
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Looks good to me too, applied.

Thanks everyone.

      parent reply	other threads:[~2009-01-05  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-04  1:47 [PATCH] sparc: Clean arch-specific code in prom_common.c Julian Calaby
2009-01-04  2:12 ` Julian Calaby
2009-01-04  8:51 ` Sam Ravnborg
2009-01-04 10:10 ` Julian Calaby
2009-01-05  8:07 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090105.000729.96111745.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.