All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Calaby <julian.calaby@gmail.com>
To: sparclinux@vger.kernel.org
Subject: [PATCH] sparc: Clean arch-specific code in prom_common.c
Date: Sun, 04 Jan 2009 01:47:52 +0000	[thread overview]
Message-ID: <49601548.509@gmail.com> (raw)

sparc: Clean arch-specific code in prom_common.c

prom_nextprop() and prom_firstprop() have slightly different calling 
conventions in 32 and 64 bit SPARC.

prom_common.c uses a ifdef guard to ensure that these functions are 
called correctly.

Adjust code to eliminate this ifdef by using a calling convention that 
is compatible with both 32 and 64 bit SPARC.

Signed-off-by: Julian Calaby <julian.calaby@gmail.com>

---

This has been build tested on sparc64 native, however I'm yet to boot it.

It hasn't been checked with sparc32 as I lack a working build environment.

  arch/sparc/kernel/prom_common.c |   14 +++-----------
  1 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/arch/sparc/kernel/prom_common.c 
b/arch/sparc/kernel/prom_common.c
index 4e9af59..ff7b591 100644
--- a/arch/sparc/kernel/prom_common.c
+++ b/arch/sparc/kernel/prom_common.c
@@ -155,20 +155,12 @@ static struct property * __init 
build_one_prop(phandle node, char *prev,
  		p->value = prom_early_alloc(special_len);
  		memcpy(p->value, special_val, special_len);
  	} else {
-#ifdef CONFIG_SPARC32
-		if (prev = NULL) {
-			name = prom_firstprop(node, NULL);
-		} else {
-			name = prom_nextprop(node, prev, NULL);
-		}
-#else
  		if (prev = NULL) {
-			prom_firstprop(node, p->name);
+			name = prom_firstprop(node, p->name);
  		} else {
-			prom_nextprop(node, prev, p->name);
+			name = prom_nextprop(node, prev, p->name);
  		}
-		name = p->name;
-#endif
+
  		if (strlen(name) = 0) {
  			tmp = p;
  			return NULL;

             reply	other threads:[~2009-01-04  1:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-04  1:47 Julian Calaby [this message]
2009-01-04  2:12 ` [PATCH] sparc: Clean arch-specific code in prom_common.c Julian Calaby
2009-01-04  8:51 ` Sam Ravnborg
2009-01-04 10:10 ` Julian Calaby
2009-01-05  8:07 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49601548.509@gmail.com \
    --to=julian.calaby@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.