All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jan Beulich <jbeulich@novell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Ingo Molnar <mingo@elte.hu>,
	rostedt@goodmis.org, Steven Rostedt <srostedt@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	sparclinux <sparclinux@vger.kernel.org>
Subject: Re: ftrace breaks sparc64 build
Date: Tue, 06 Jan 2009 13:34:42 +0000	[thread overview]
Message-ID: <20090106133442.GA14780@uranus.ravnborg.org> (raw)
In-Reply-To: <20090106113543.GS28946@ZenIV.linux.org.uk>

On Tue, Jan 06, 2009 at 11:35:43AM +0000, Al Viro wrote:
> On Tue, Jan 06, 2009 at 07:53:04AM +0000, Jan Beulich wrote:
> 
> > The __crc_... reference is definitely bogus - none should survive with the
> > new .c->.o rule. Could you find out what object file they originate from?
> 
> So can you, by use of arcane tool known as "grep"...  It's in kernel/softirq.c
> and that's genksyms parser being fucked in head.  Look for TYPEOF_KEYW
> in parse.y and you'll see.  Especially amusing part is a kludge from
> commit a89a0a2354ae666612968e254d650bfd04f11eb6...

Any feedback on what to do to make it better?
Never used typeof myself so I do not know the exact syntax.

> 
> > The others look like a tools side behavioral difference, as I never saw any
> > such. Is this problem sparc32-specific (I tested x86 and ia64 only)? What's
> > the binutils version used?
> 
> 2.18.50.0.6.
> 
> And no, it's not tools side.  What it is, AFAICT, is that sparc32 has
> LDFLAGS_vmlinux = -r, which leaves a metric arseload of relocs that
> wouldn't have survived into vmlinux otherwise.  Look at .rela__ksymtab
> in .tmp_vmlinux1, for example...

The use of -r is to support the btfixup magic.
I have been thinking of moving the btfixup phase so it happens _before_
the final link of vmlinux. This should help us here.

But I never managed to really understand what the btfixup thing is all
about and has then been sidetracked by funnier stuff.

	Sam



WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jan Beulich <jbeulich@novell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Ingo Molnar <mingo@elte.hu>,
	rostedt@goodmis.org, Steven Rostedt <srostedt@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	sparclinux <sparclinux@vger.kernel.org>
Subject: Re: ftrace breaks sparc64 build
Date: Tue, 6 Jan 2009 14:34:42 +0100	[thread overview]
Message-ID: <20090106133442.GA14780@uranus.ravnborg.org> (raw)
In-Reply-To: <20090106113543.GS28946@ZenIV.linux.org.uk>

On Tue, Jan 06, 2009 at 11:35:43AM +0000, Al Viro wrote:
> On Tue, Jan 06, 2009 at 07:53:04AM +0000, Jan Beulich wrote:
> 
> > The __crc_... reference is definitely bogus - none should survive with the
> > new .c->.o rule. Could you find out what object file they originate from?
> 
> So can you, by use of arcane tool known as "grep"...  It's in kernel/softirq.c
> and that's genksyms parser being fucked in head.  Look for TYPEOF_KEYW
> in parse.y and you'll see.  Especially amusing part is a kludge from
> commit a89a0a2354ae666612968e254d650bfd04f11eb6...

Any feedback on what to do to make it better?
Never used typeof myself so I do not know the exact syntax.

> 
> > The others look like a tools side behavioral difference, as I never saw any
> > such. Is this problem sparc32-specific (I tested x86 and ia64 only)? What's
> > the binutils version used?
> 
> 2.18.50.0.6.
> 
> And no, it's not tools side.  What it is, AFAICT, is that sparc32 has
> LDFLAGS_vmlinux = -r, which leaves a metric arseload of relocs that
> wouldn't have survived into vmlinux otherwise.  Look at .rela__ksymtab
> in .tmp_vmlinux1, for example...

The use of -r is to support the btfixup magic.
I have been thinking of moving the btfixup phase so it happens _before_
the final link of vmlinux. This should help us here.

But I never managed to really understand what the btfixup thing is all
about and has then been sidetracked by funnier stuff.

	Sam



  parent reply	other threads:[~2009-01-06 13:34 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-05 18:19 ftrace breaks sparc64 build Sam Ravnborg
2009-01-05 18:19 ` Sam Ravnborg
2009-01-05 19:31 ` Steven Rostedt
2009-01-05 19:31   ` Steven Rostedt
2009-01-05 19:42   ` [PATCH] sparc: make proces_ver_nack a bit more readable Steven Rostedt
2009-01-05 19:42     ` Steven Rostedt
2009-01-05 19:46     ` Steven Rostedt
2009-01-05 19:46       ` Steven Rostedt
2009-01-05 19:56     ` Steven Rostedt
2009-01-05 19:56       ` Steven Rostedt
2009-01-05 20:07       ` Sam Ravnborg
2009-01-05 20:07         ` Sam Ravnborg
2009-01-05 20:08     ` Sam Ravnborg
2009-01-05 20:08       ` Sam Ravnborg
2009-01-06 18:23       ` David Miller
2009-01-06 18:23         ` David Miller
2009-01-05 19:54   ` ftrace breaks sparc64 build Sam Ravnborg
2009-01-05 19:54     ` Sam Ravnborg
2009-01-05 20:05     ` Steven Rostedt
2009-01-05 20:05       ` Steven Rostedt
2009-01-05 21:31       ` Sam Ravnborg
2009-01-05 21:31         ` Sam Ravnborg
2009-01-05 21:52         ` Steven Rostedt
2009-01-05 21:52           ` Steven Rostedt
2009-01-05 22:01           ` Sam Ravnborg
2009-01-05 22:01             ` Sam Ravnborg
2009-01-05 22:14             ` Steven Rostedt
2009-01-05 22:14               ` Steven Rostedt
2009-01-05 23:11               ` Heiko Carstens
2009-01-05 23:11                 ` Heiko Carstens
2009-01-06  2:07                 ` Steven Rostedt
2009-01-06  2:07                   ` Steven Rostedt
2009-01-06  9:36                   ` Heiko Carstens
2009-01-06  9:36                     ` Heiko Carstens
2009-01-06  4:30                 ` Steven Rostedt
2009-01-06  4:30                   ` Steven Rostedt
2009-01-06  9:45                   ` Heiko Carstens
2009-01-06  9:45                     ` Heiko Carstens
2009-01-06 18:32       ` David Miller
2009-01-06 18:32         ` David Miller
2009-01-06 18:52         ` Steven Rostedt
2009-01-06 18:52           ` Steven Rostedt
2009-01-06 19:01           ` David Miller
2009-01-06 19:01             ` David Miller
2009-01-06 19:52             ` Sam Ravnborg
2009-01-06 19:52               ` Sam Ravnborg
2009-01-06 20:02               ` David Miller
2009-01-06 20:02                 ` David Miller
2009-01-05 20:30     ` [PATCH] module: clean up initialization of variable Steven Rostedt
2009-01-05 20:30       ` Steven Rostedt
2009-01-05 22:59       ` Harvey Harrison
2009-01-05 22:59         ` Harvey Harrison
2009-01-06  1:22       ` Rusty Russell
2009-01-06  1:34         ` Rusty Russell
2009-01-06  2:02         ` Steven Rostedt
2009-01-06  2:02           ` Steven Rostedt
2009-01-05 19:48 ` ftrace breaks sparc64 build Al Viro
2009-01-05 19:48   ` Al Viro
2009-01-05 19:55   ` Sam Ravnborg
2009-01-05 19:55     ` Sam Ravnborg
2009-01-06  7:53     ` Jan Beulich
2009-01-06  7:53       ` Jan Beulich
2009-01-06 11:35       ` Al Viro
2009-01-06 11:35         ` Al Viro
2009-01-06 12:39         ` Jan Beulich
2009-01-06 12:39           ` Jan Beulich
2009-01-06 13:34         ` Sam Ravnborg [this message]
2009-01-06 13:34           ` Sam Ravnborg
2009-01-06 15:52           ` Al Viro
2009-01-06 15:52             ` Al Viro
2009-01-06 18:39           ` David Miller
2009-01-06 18:39             ` David Miller
2009-01-08  9:28         ` Jan Beulich
2009-01-08  9:28           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090106133442.GA14780@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=davem@davemloft.net \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=srostedt@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.