All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <n0-1@freewrt.org>
To: linux-ide@vger.kernel.org
Cc: jeff@garzik.org, bzolnier@gmail.com, florian@openwrt.org
Subject: [PATCH 5/5] pata-rb532-cf: drop custom freeze and thaw
Date: Tue, 20 Jan 2009 17:41:00 +0100	[thread overview]
Message-ID: <20090120164306.ECA26400E133@mail.nwl.cc> (raw)
In-Reply-To: <1232469660-22335-5-git-send-email-n0-1@freewrt.org>

I'm not quite sure what freezing and thawing is used for. Tests showed
that the port is being frozen at initialisation state and thawed right
afterwards, then the functions were not called anymore. Dropping the
complete custom code for handling the frozen state seems to work at
least for a standard use case including mounting a partition, copying
some files in it (in parallel) and finally removing them and unmounting
the partition.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
---
 drivers/ata/pata_rb532_cf.c |   20 +-------------------
 1 files changed, 1 insertions(+), 19 deletions(-)

diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index 9fb91e4..fbfee1b 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -48,26 +48,11 @@
 struct rb532_cf_info {
 	void __iomem	*iobase;
 	unsigned int	gpio_line;
-	int		frozen;
 	unsigned int	irq;
 };
 
 /* ------------------------------------------------------------------------ */
 
-static void rb532_pata_freeze(struct ata_port *ap)
-{
-	struct rb532_cf_info *info = ap->host->private_data;
-
-	info->frozen = 1;
-}
-
-static void rb532_pata_thaw(struct ata_port *ap)
-{
-	struct rb532_cf_info *info = ap->host->private_data;
-
-	info->frozen = 0;
-}
-
 static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
 {
 	struct ata_host *ah = dev_instance;
@@ -75,8 +60,7 @@ static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
 
 	if (gpio_get_value(info->gpio_line)) {
 		set_irq_type(info->irq, IRQ_TYPE_LEVEL_LOW);
-		if (!info->frozen)
-			ata_sff_interrupt(info->irq, dev_instance);
+		ata_sff_interrupt(info->irq, dev_instance);
 	} else {
 		set_irq_type(info->irq, IRQ_TYPE_LEVEL_HIGH);
 	}
@@ -87,8 +71,6 @@ static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
 static struct ata_port_operations rb532_pata_port_ops = {
 	.inherits		= &ata_sff_port_ops,
 	.sff_data_xfer		= ata_sff_data_xfer32,
-	.freeze			= rb532_pata_freeze,
-	.thaw			= rb532_pata_thaw,
 };
 
 /* ------------------------------------------------------------------------ */
-- 
1.5.6.4


  parent reply	other threads:[~2009-01-20 16:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200811202002.16178.david-b@pacbell.net>
2008-11-28 19:35 ` MIPS: RB532: Provide functions for gpio configuration Phil Sutter
2008-11-28 19:45   ` [PATCH] MIPS: rb532: add set_type() function to IRQ struct Phil Sutter
2009-01-29 16:39     ` Ralf Baechle
2008-11-28 19:46   ` [PATCH] MIPS: rb532: auto disable GPIO alternate function Phil Sutter
2009-01-29 16:41     ` Ralf Baechle
2008-11-28 19:46   ` [PATCH] MIPS: rb532: remove useless CF GPIO initialisation Phil Sutter
2009-01-29 16:47     ` Ralf Baechle
2008-11-28 19:46   ` [PATCH] MIPS: rb532: remove unused rb532_gpio_set_func() Phil Sutter
2009-01-22  0:41     ` Phil Sutter
2008-11-28 19:48   ` [PATCH] pata-rb532-cf: fix and rename register definitions Phil Sutter
2008-12-01 19:24     ` Jeff Garzik
2008-11-28 19:48   ` [PATCH] pata-rb532-cf: fix signature of the xfer function Phil Sutter
2008-12-01 19:24     ` Jeff Garzik
2008-11-28 19:48   ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Phil Sutter
2009-01-20 16:40     ` review of pata-rb532-cf Phil Sutter
2009-01-24 14:12       ` Bartlomiej Zolnierkiewicz
     [not found]     ` <1232469660-22335-1-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40       ` [PATCH 1/5] pata-rb532-cf: remove set_irq_type from finish_io Phil Sutter
2009-01-27  7:13         ` Jeff Garzik
     [not found]       ` <1232469660-22335-2-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40         ` [PATCH 2/5] pata-rb532-cf: replace rb532_pata_finish_io() Phil Sutter
2009-01-27  7:14           ` Jeff Garzik
2009-01-27 13:36             ` Phil Sutter
2009-01-27 13:35               ` Phil Sutter
2009-02-03  4:19                 ` Jeff Garzik
     [not found]               ` <1233063353-12770-1-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35                 ` [PATCH 3/5] pata-rb532-cf: use ata_sff_exec_command() Phil Sutter
     [not found]                 ` <1233063353-12770-2-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35                   ` [PATCH 4/5] pata-rb532-cf: use ata_sff_data_xfer32() Phil Sutter
     [not found]                   ` <1233063353-12770-3-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35                     ` [PATCH 5/5] pata-rb532-cf: drop custom freeze and thaw Phil Sutter
     [not found]         ` <1232469660-22335-3-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40           ` [PATCH 3/5] pata-rb532-cf: use ata_sff_exec_command() Phil Sutter
     [not found]           ` <1232469660-22335-4-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40             ` [PATCH 4/5] pata-rb532-cf: use ata_sff_data_xfer32() Phil Sutter
     [not found]             ` <1232469660-22335-5-git-send-email-n0-1@freewrt.org>
2009-01-20 16:41               ` Phil Sutter [this message]
2009-01-22 18:28   ` [PATCH] rb532: update headers Phil Sutter
2009-01-29 18:04     ` Ralf Baechle
2009-01-22 18:32   ` [PATCH] MIPS: rb532: export rb532_gpio_set_func() Phil Sutter
2009-01-29 18:05     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090120164306.ECA26400E133@mail.nwl.cc \
    --to=n0-1@freewrt.org \
    --cc=bzolnier@gmail.com \
    --cc=florian@openwrt.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.