From: Jeff Garzik <jeff@garzik.org>
To: Phil Sutter <n0-1@freewrt.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata-rb532-cf: fix and rename register definitions
Date: Mon, 01 Dec 2008 14:24:25 -0500 [thread overview]
Message-ID: <493439E9.9010804@garzik.org> (raw)
In-Reply-To: <20081128194550.734FF386DBBE@mail.ifyouseekate.net>
Phil Sutter wrote:
> The original standalone driver uses a custom address for the error
> register. Use it in pata-rb532-cf, too.
>
> Rename two register definitions:
> - The address offset 0x0800 in fact is the ATA base, not ATA command
> address.
> - The offset 0x0C00 is not a regular ATA data address, but a buffered one
> allowing 4-byte IO.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> ---
> drivers/ata/pata_rb532_cf.c | 11 +++++++----
applied
next prev parent reply other threads:[~2008-12-01 19:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200811202002.16178.david-b@pacbell.net>
2008-11-28 19:35 ` MIPS: RB532: Provide functions for gpio configuration Phil Sutter
2008-11-28 19:45 ` [PATCH] MIPS: rb532: add set_type() function to IRQ struct Phil Sutter
2009-01-29 16:39 ` Ralf Baechle
2008-11-28 19:46 ` [PATCH] MIPS: rb532: auto disable GPIO alternate function Phil Sutter
2009-01-29 16:41 ` Ralf Baechle
2008-11-28 19:46 ` [PATCH] MIPS: rb532: remove useless CF GPIO initialisation Phil Sutter
2009-01-29 16:47 ` Ralf Baechle
2008-11-28 19:46 ` [PATCH] MIPS: rb532: remove unused rb532_gpio_set_func() Phil Sutter
2009-01-22 0:41 ` Phil Sutter
2008-11-28 19:48 ` [PATCH] pata-rb532-cf: fix and rename register definitions Phil Sutter
2008-12-01 19:24 ` Jeff Garzik [this message]
2008-11-28 19:48 ` [PATCH] pata-rb532-cf: fix signature of the xfer function Phil Sutter
2008-12-01 19:24 ` Jeff Garzik
2008-11-28 19:48 ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Phil Sutter
2009-01-20 16:40 ` review of pata-rb532-cf Phil Sutter
2009-01-24 14:12 ` Bartlomiej Zolnierkiewicz
[not found] ` <1232469660-22335-1-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40 ` [PATCH 1/5] pata-rb532-cf: remove set_irq_type from finish_io Phil Sutter
2009-01-27 7:13 ` Jeff Garzik
[not found] ` <1232469660-22335-2-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40 ` [PATCH 2/5] pata-rb532-cf: replace rb532_pata_finish_io() Phil Sutter
2009-01-27 7:14 ` Jeff Garzik
2009-01-27 13:36 ` Phil Sutter
2009-01-27 13:35 ` Phil Sutter
2009-02-03 4:19 ` Jeff Garzik
[not found] ` <1233063353-12770-1-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35 ` [PATCH 3/5] pata-rb532-cf: use ata_sff_exec_command() Phil Sutter
[not found] ` <1233063353-12770-2-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35 ` [PATCH 4/5] pata-rb532-cf: use ata_sff_data_xfer32() Phil Sutter
[not found] ` <1233063353-12770-3-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35 ` [PATCH 5/5] pata-rb532-cf: drop custom freeze and thaw Phil Sutter
[not found] ` <1232469660-22335-3-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40 ` [PATCH 3/5] pata-rb532-cf: use ata_sff_exec_command() Phil Sutter
[not found] ` <1232469660-22335-4-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40 ` [PATCH 4/5] pata-rb532-cf: use ata_sff_data_xfer32() Phil Sutter
[not found] ` <1232469660-22335-5-git-send-email-n0-1@freewrt.org>
2009-01-20 16:41 ` [PATCH 5/5] pata-rb532-cf: drop custom freeze and thaw Phil Sutter
2009-01-22 18:28 ` [PATCH] rb532: update headers Phil Sutter
2009-01-29 18:04 ` Ralf Baechle
2009-01-22 18:32 ` [PATCH] MIPS: rb532: export rb532_gpio_set_func() Phil Sutter
2009-01-29 18:05 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493439E9.9010804@garzik.org \
--to=jeff@garzik.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=n0-1@freewrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.