All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Phil Sutter <n0-1@freewrt.org>
Cc: linux-ide@vger.kernel.org, jeff@garzik.org, florian@openwrt.org
Subject: Re: review of pata-rb532-cf
Date: Sat, 24 Jan 2009 15:12:11 +0100	[thread overview]
Message-ID: <200901241512.11657.bzolnier@gmail.com> (raw)
In-Reply-To: <20090120164314.07AD3400E137@mail.nwl.cc>


Hi,

On Tuesday 20 January 2009, Phil Sutter wrote:
> 
> Hi,
> 
> I did some review of pata-rb532-cf in order to simplify the code a bit
> in which I think have succeeded.
> 
> After finding the first patch by accident, patches two and three were
> quite obvious. Patch four also solves the discussed changes to
> rb532_pata_data_xfer() as it drops it completely, replacing it by
> a standard libata function. Patch 5 is rather experimental and hopefully
> triggers a discussion about the changes it introduces.

FWIW patches 1-4 look OK to me.

Thanks,
Bart

  reply	other threads:[~2009-01-24 14:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200811202002.16178.david-b@pacbell.net>
2008-11-28 19:35 ` MIPS: RB532: Provide functions for gpio configuration Phil Sutter
2008-11-28 19:45   ` [PATCH] MIPS: rb532: add set_type() function to IRQ struct Phil Sutter
2009-01-29 16:39     ` Ralf Baechle
2008-11-28 19:46   ` [PATCH] MIPS: rb532: auto disable GPIO alternate function Phil Sutter
2009-01-29 16:41     ` Ralf Baechle
2008-11-28 19:46   ` [PATCH] MIPS: rb532: remove useless CF GPIO initialisation Phil Sutter
2009-01-29 16:47     ` Ralf Baechle
2008-11-28 19:46   ` [PATCH] MIPS: rb532: remove unused rb532_gpio_set_func() Phil Sutter
2009-01-22  0:41     ` Phil Sutter
2008-11-28 19:48   ` [PATCH] pata-rb532-cf: fix and rename register definitions Phil Sutter
2008-12-01 19:24     ` Jeff Garzik
2008-11-28 19:48   ` [PATCH] pata-rb532-cf: fix signature of the xfer function Phil Sutter
2008-12-01 19:24     ` Jeff Garzik
2008-11-28 19:48   ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Phil Sutter
2009-01-20 16:40     ` review of pata-rb532-cf Phil Sutter
2009-01-24 14:12       ` Bartlomiej Zolnierkiewicz [this message]
     [not found]     ` <1232469660-22335-1-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40       ` [PATCH 1/5] pata-rb532-cf: remove set_irq_type from finish_io Phil Sutter
2009-01-27  7:13         ` Jeff Garzik
     [not found]       ` <1232469660-22335-2-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40         ` [PATCH 2/5] pata-rb532-cf: replace rb532_pata_finish_io() Phil Sutter
2009-01-27  7:14           ` Jeff Garzik
2009-01-27 13:36             ` Phil Sutter
2009-01-27 13:35               ` Phil Sutter
2009-02-03  4:19                 ` Jeff Garzik
     [not found]               ` <1233063353-12770-1-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35                 ` [PATCH 3/5] pata-rb532-cf: use ata_sff_exec_command() Phil Sutter
     [not found]                 ` <1233063353-12770-2-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35                   ` [PATCH 4/5] pata-rb532-cf: use ata_sff_data_xfer32() Phil Sutter
     [not found]                   ` <1233063353-12770-3-git-send-email-n0-1@freewrt.org>
2009-01-27 13:35                     ` [PATCH 5/5] pata-rb532-cf: drop custom freeze and thaw Phil Sutter
     [not found]         ` <1232469660-22335-3-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40           ` [PATCH 3/5] pata-rb532-cf: use ata_sff_exec_command() Phil Sutter
     [not found]           ` <1232469660-22335-4-git-send-email-n0-1@freewrt.org>
2009-01-20 16:40             ` [PATCH 4/5] pata-rb532-cf: use ata_sff_data_xfer32() Phil Sutter
     [not found]             ` <1232469660-22335-5-git-send-email-n0-1@freewrt.org>
2009-01-20 16:41               ` [PATCH 5/5] pata-rb532-cf: drop custom freeze and thaw Phil Sutter
2009-01-22 18:28   ` [PATCH] rb532: update headers Phil Sutter
2009-01-29 18:04     ` Ralf Baechle
2009-01-22 18:32   ` [PATCH] MIPS: rb532: export rb532_gpio_set_func() Phil Sutter
2009-01-29 18:05     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901241512.11657.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=florian@openwrt.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=n0-1@freewrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.