* [PATCH] Reset pos in cr_write_pids()
@ 2009-01-22 5:14 Sukadev Bhattiprolu
[not found] ` <20090122051407.GA20039-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sukadev Bhattiprolu @ 2009-01-22 5:14 UTC (permalink / raw)
To: orenl-r/Jw6+rmf7HQT0dZR+AlfA; +Cc: Containers
Noticed this while reviewing the code in [v12] branch of your git tree.
---
From: Sukadev Bhattiprolu <suka@sukaT61.(none)>
Date: Wed, 21 Jan 2009 21:10:34 -0800
Subject: [PATCH] Reset pos in cr_write_pids()
If the number of tasks exceed CR_HDR_PIDS_CHUNK, pos must be reset
for a second iteration in the outer loop.
---
checkpoint/checkpoint.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/checkpoint/checkpoint.c b/checkpoint/checkpoint.c
index fbcd9eb..3136850 100644
--- a/checkpoint/checkpoint.c
+++ b/checkpoint/checkpoint.c
@@ -297,7 +297,7 @@ static int cr_write_pids(struct cr_ctx *ctx)
struct pid_namespace *ns;
struct task_struct *task;
struct task_struct **tasks_arr;
- int tasks_nr, n, ret = 0, pos = 0;
+ int tasks_nr, n, ret = 0, pos;
ns = ctx->root_nsproxy->pid_ns;
tasks_arr = ctx->tasks_arr;
@@ -306,6 +306,7 @@ static int cr_write_pids(struct cr_ctx *ctx)
hh = cr_hbuf_get(ctx, sizeof(*hh) * CR_HDR_PIDS_CHUNK);
while (tasks_nr > 0) {
+ pos = 0;
rcu_read_lock();
for (n = min(tasks_nr, CR_HDR_PIDS_CHUNK); n; n--) {
task = tasks_arr[pos];
--
1.5.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20090122051407.GA20039-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] Reset pos in cr_write_pids() [not found] ` <20090122051407.GA20039-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> @ 2009-01-22 5:19 ` Sukadev Bhattiprolu 2009-01-23 23:08 ` Oren Laadan 1 sibling, 0 replies; 3+ messages in thread From: Sukadev Bhattiprolu @ 2009-01-22 5:19 UTC (permalink / raw) To: orenl-r/Jw6+rmf7HQT0dZR+AlfA; +Cc: Containers Fix typo in Oren's address --- Oren, Noticed this while reviewing the code in [v12] branch of your git tree. --- From: Sukadev Bhattiprolu <suka@sukaT61.(none)> Date: Wed, 21 Jan 2009 21:10:34 -0800 Subject: [PATCH] Reset pos in cr_write_pids() If the number of tasks exceed CR_HDR_PIDS_CHUNK, pos must be reset for a second iteration in the outer loop. --- checkpoint/checkpoint.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/checkpoint/checkpoint.c b/checkpoint/checkpoint.c index fbcd9eb..3136850 100644 --- a/checkpoint/checkpoint.c +++ b/checkpoint/checkpoint.c @@ -297,7 +297,7 @@ static int cr_write_pids(struct cr_ctx *ctx) struct pid_namespace *ns; struct task_struct *task; struct task_struct **tasks_arr; - int tasks_nr, n, ret = 0, pos = 0; + int tasks_nr, n, ret = 0, pos; ns = ctx->root_nsproxy->pid_ns; tasks_arr = ctx->tasks_arr; @@ -306,6 +306,7 @@ static int cr_write_pids(struct cr_ctx *ctx) hh = cr_hbuf_get(ctx, sizeof(*hh) * CR_HDR_PIDS_CHUNK); while (tasks_nr > 0) { + pos = 0; rcu_read_lock(); for (n = min(tasks_nr, CR_HDR_PIDS_CHUNK); n; n--) { task = tasks_arr[pos]; -- 1.5.4.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Reset pos in cr_write_pids() [not found] ` <20090122051407.GA20039-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> 2009-01-22 5:19 ` Sukadev Bhattiprolu @ 2009-01-23 23:08 ` Oren Laadan 1 sibling, 0 replies; 3+ messages in thread From: Oren Laadan @ 2009-01-23 23:08 UTC (permalink / raw) To: Sukadev Bhattiprolu; +Cc: Containers Sukadev Bhattiprolu wrote: > Noticed this while reviewing the code in [v12] branch of your git tree. Thanks. Will fix. Oren. > > --- > From: Sukadev Bhattiprolu <suka@sukaT61.(none)> > Date: Wed, 21 Jan 2009 21:10:34 -0800 > Subject: [PATCH] Reset pos in cr_write_pids() > > If the number of tasks exceed CR_HDR_PIDS_CHUNK, pos must be reset > for a second iteration in the outer loop. > --- > checkpoint/checkpoint.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/checkpoint/checkpoint.c b/checkpoint/checkpoint.c > index fbcd9eb..3136850 100644 > --- a/checkpoint/checkpoint.c > +++ b/checkpoint/checkpoint.c > @@ -297,7 +297,7 @@ static int cr_write_pids(struct cr_ctx *ctx) > struct pid_namespace *ns; > struct task_struct *task; > struct task_struct **tasks_arr; > - int tasks_nr, n, ret = 0, pos = 0; > + int tasks_nr, n, ret = 0, pos; > > ns = ctx->root_nsproxy->pid_ns; > tasks_arr = ctx->tasks_arr; > @@ -306,6 +306,7 @@ static int cr_write_pids(struct cr_ctx *ctx) > hh = cr_hbuf_get(ctx, sizeof(*hh) * CR_HDR_PIDS_CHUNK); > > while (tasks_nr > 0) { > + pos = 0; > rcu_read_lock(); > for (n = min(tasks_nr, CR_HDR_PIDS_CHUNK); n; n--) { > task = tasks_arr[pos]; ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-23 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-22 5:14 [PATCH] Reset pos in cr_write_pids() Sukadev Bhattiprolu
[not found] ` <20090122051407.GA20039-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-22 5:19 ` Sukadev Bhattiprolu
2009-01-23 23:08 ` Oren Laadan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.