All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	Pavel Machek <pavel@suse.cz>,
	npiggin@yahoo.com.au, Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH] Re: Corrupted XFS log replay oops.
Date: Fri, 23 Jan 2009 10:37:17 +1100	[thread overview]
Message-ID: <20090122233717.GB32390@disturbed> (raw)
In-Reply-To: <20090122100648.GA16660@alice>

On Thu, Jan 22, 2009 at 11:06:48AM +0100, Eric Sesterhenn wrote:
> * Christoph Hellwig (hch@infradead.org) wrote:
> > On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
> > >  xfs_buf_t *
> > >  xlog_get_bp(
> > >  	xlog_t		*log,
> > > -	int		num_bblks)
> > > +	int		nbblks)
> > 
> > Any reason for reanming this variable?  That causes quite a bit of
> > churn.
> > 
> > >  {
> > > -	ASSERT(num_bblks > 0);
> > > +	if (nbblks <= 0 || nbblks > log->l_logBBsize) {
> > > +		xlog_warn("XFS: Invalid block length (0x%x) given for buffer", nbblks);
> > 
> > And doesn't prevent this line from needing a linebreak to stay under 80
> > characters :)
> > 
> > Except for these nitpicks it looks fine to me.
> 
> Using the image at http://www.cccmz.de/~snakebyte/xfs.254.img.bz2
> I was able to produce a pretty similar error with the patch applied

Different problem, obviously. ;)

I'll have a look at this later today....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Pavel Machek <pavel@suse.cz>,
	Chris Mason <chris.mason@oracle.com>,
	linux-kernel@vger.kernel.org, npiggin@yahoo.com.au,
	xfs@oss.sgi.com
Subject: Re: [PATCH] Re: Corrupted XFS log replay oops.
Date: Fri, 23 Jan 2009 10:37:17 +1100	[thread overview]
Message-ID: <20090122233717.GB32390@disturbed> (raw)
In-Reply-To: <20090122100648.GA16660@alice>

On Thu, Jan 22, 2009 at 11:06:48AM +0100, Eric Sesterhenn wrote:
> * Christoph Hellwig (hch@infradead.org) wrote:
> > On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
> > >  xfs_buf_t *
> > >  xlog_get_bp(
> > >  	xlog_t		*log,
> > > -	int		num_bblks)
> > > +	int		nbblks)
> > 
> > Any reason for reanming this variable?  That causes quite a bit of
> > churn.
> > 
> > >  {
> > > -	ASSERT(num_bblks > 0);
> > > +	if (nbblks <= 0 || nbblks > log->l_logBBsize) {
> > > +		xlog_warn("XFS: Invalid block length (0x%x) given for buffer", nbblks);
> > 
> > And doesn't prevent this line from needing a linebreak to stay under 80
> > characters :)
> > 
> > Except for these nitpicks it looks fine to me.
> 
> Using the image at http://www.cccmz.de/~snakebyte/xfs.254.img.bz2
> I was able to produce a pretty similar error with the patch applied

Different problem, obviously. ;)

I'll have a look at this later today....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2009-01-22 23:43 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 14:21 Warning and BUG with btrfs and corrupted image Eric Sesterhenn
2009-01-13 14:40 ` Chris Mason
2009-01-13 14:43   ` Eric Sesterhenn
2009-01-15  2:13     ` Chris Mason
2009-01-18 17:40     ` Pavel Machek
2009-01-20  6:31       ` Eric Sesterhenn
2009-01-20  9:34         ` Pavel Machek
2009-01-20 10:11         ` Dave Chinner
2009-01-20 10:15           ` Eric Sesterhenn
2009-01-20 12:59             ` Dave Chinner
2009-01-20 13:28               ` Christoph Hellwig
2009-01-20 22:20                 ` Pavel Machek
2009-01-21  4:00                   ` Dave Chinner
2009-01-26 16:27                     ` Pavel Machek
2009-01-26 20:06                       ` [Discussion] Apparent inconsistancies in use of io_align, io_width & sector_size ashford
2009-02-01  1:40                       ` Warning and BUG with btrfs and corrupted image Dave Chinner
2009-02-04 18:29                         ` Pavel Machek
2009-02-05  8:59                           ` Dave Chinner
2009-02-05  8:59                             ` Dave Chinner
2009-02-05  9:02                             ` Pavel Machek
2009-02-05 13:02                               ` Chris Mason
2009-02-05 13:50                                 ` Pavel Machek
2009-02-05 14:19                                   ` jim owens
2009-02-25 19:54                                     ` Pavel Machek
2009-01-20 17:34               ` Eric Sesterhenn
2009-01-20 22:18                 ` Pavel Machek
2009-01-21  9:36                   ` Eric Sesterhenn
2009-01-21  3:57                 ` Corrupted XFS log replay oops. (was Re: Warning and BUG with btrfs and corrupted image) Dave Chinner
2009-01-21  3:57                   ` Dave Chinner
2009-01-21  4:03                   ` Nick Piggin
2009-01-22  4:37                     ` [PATCH] Re: Corrupted XFS log replay oops Dave Chinner
2009-01-22  4:37                       ` Dave Chinner
2009-01-22  5:50                       ` Felix Blyakher
2009-01-22  5:50                         ` Felix Blyakher
2009-01-22  6:11                       ` Christoph Hellwig
2009-01-22  6:11                         ` Christoph Hellwig
2009-01-22  8:35                         ` Eric Sesterhenn
2009-01-22  8:35                           ` Eric Sesterhenn
2009-01-22 10:06                         ` Eric Sesterhenn
2009-01-22 10:06                           ` Eric Sesterhenn
2009-01-22 23:37                           ` Dave Chinner [this message]
2009-01-22 23:37                             ` Dave Chinner
2009-01-23  1:10                             ` Dave Chinner
2009-01-23  1:10                               ` Dave Chinner
2009-01-22 23:35                         ` Dave Chinner
2009-01-22 23:35                           ` Dave Chinner
2009-01-23  0:02                         ` Dave Chinner
2009-01-23  0:02                           ` Dave Chinner
2009-01-23  0:06                           ` Christoph Hellwig
2009-01-23  0:06                             ` Christoph Hellwig
2009-01-23  6:20                             ` Felix Blyakher
2009-01-23  6:20                               ` Felix Blyakher
2009-02-03 20:48                       ` Eric Sandeen
2009-01-21  4:03                   ` Corrupted XFS log replay oops. (was Re: Warning and BUG with btrfs and corrupted image) Dave Chinner
2009-01-21  4:03                     ` Dave Chinner
2009-01-20 13:11         ` Warning and BUG with btrfs and corrupted image Chris Mason
2009-01-20 16:51           ` Eric Sesterhenn
2009-01-22  2:15             ` Phillip Lougher
2009-01-23  8:56               ` Eric Sesterhenn
2009-01-23  8:56                 ` Eric Sesterhenn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090122233717.GB32390@disturbed \
    --to=david@fromorbit.com \
    --cc=chris.mason@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=npiggin@yahoo.com.au \
    --cc=pavel@suse.cz \
    --cc=snakebyte@gmx.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.