mmotm 2009-01-28-02-17 uploaded

mmotm 2009-01-28-02-17 uploaded

[akpm]

The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to

   http://userweb.kernel.org/~akpm/mmotm/

and will soon be available at

   git://git.zen-sources.org/zen/mmotm.git

It contains the following patches against 2.6.29-rc2:

origin.patch
sgi-xpc-ensure-flags-are-updated-before-bte_copy.patch
sgi-xpc-ensure-flags-are-updated-before-bte_copy-update.patch
sgi-xpc-remove-null-pointer-dereference.patch
sgi-xpc-fixup-stale-dbug_on-statements.patch
kprobes-fix-module-compilation-error-with-config_kprobes=n.patch
oom-documentation-update.patch
cgroups-use-hierarchy-mutex-in-creation-failure-path.patch
memcg-get-put-parents-at-create-free.patch
memcg-get-put-parents-at-create-free-fix.patch
gpiolib-fix-request-related-issue.patch
memcg-fix-refcnt-handling-at-swapoff.patch
memcg-update-document-to-mention-swapoff-should-be-test.patch
hp-wmi-fix-regressions-caused-by-missing-if-statement.patch
fbdev-incorrect-url-given-in-drivers-video-kconfig.patch
memcg-null-pointer-dereference-at-rmdir-on-some-numa-systems-v2.patch
alpha-use-syscall-wrappers.patch
alpha-compile-fixes.patch
alpha-fix-the-bug-macro.patch
cgroups-fix-lock-inconsistency-in-cgroup_clone.patch
cgroups-add-cpu_relax-calls-in-css_tryget-and-cgroup_clear_css_refs.patch
cgroup-fix-root_count-when-mount-fails-due-to-busy-subsystem.patch
hpilo-increment-version.patch
hwmon-applesmc-add-support-for-macpro-3-temperature-sensors.patch
i-need-old-gcc.patch
repeatable-slab-corruption-with-ltp-msgctl08.patch
linux-next.patch
next-remove-localversion.patch
linux-next-git-rejects.patch
kvm-unbork.patch
acpi-check-_pss-invalidation-when-bios-report-_pss-with-all-0x80000000.patch
acpi-fix-pmtimer-overflow-which-makes-cx-states-time-incorrect.patch
acpi-fix-pmtimer-overflow-which-makes-cx-states-time-incorrect-checkpatch-fixes.patch
mm-only-enforce-acpi-resource-conflict-checks.patch
thinkpad-acpi-split-delayed-leds-stuff-clean-up-code.patch
thinkpad-acpi-split-delayed-leds-stuff-clean-up-code-checkpatch-fixes.patch
x86-simplify-highmem-related-kconfig-entries.patch
x86-define-arch_want_frame_pointers.patch
x86-define-arch_want_frame_pointers-fix.patch
kgdb-fix-kernel-doc-error.patch
auditsc-fix-kernel-doc-notation.patch
audit-execve-record-remove-bogus-newline.patch
kernel-auditscc-fix-warning.patch
pcmcia-pccard-deadlock-fix.patch
early-platform-drivers-v2.patch
drivers-consolidate-driver_probe_done-loops-into-one-place.patch
drivers-consolidate-driver_probe_done-loops-into-one-place-fix.patch
drivers-consolidate-driver_probe_done-loops-into-one-place-checkpatch-fixes.patch
resume-wait-for-device-probing-to-finish.patch
sysfs-reference-sysfs_dirent-from-sysfs-inodes.patch
sysfs-reference-sysfs_dirent-from-sysfs-inodes-fix.patch
dvb-negative-internal-sub_range-wont-get-noticed.patch
i2c-incremental-i2c-mpc-driver-fix-for-multi-master-i2c-busses.patch
i2c-fix-i2c-mpc-driver-for-multi-master-i2c-busses.patch
clocksource-pass-clocksource-to-read-callback.patch
clocksource-add-enable-and-disable-callbacks.patch
clocksource-sanity-check-sysfs-clocksource-changes.patch
input-touchscreen-driver-add-support-ad7877-touchscreen-driver.patch
input-mousedev-distinguish-a-moving-finger-from-a-tapping-finger.patch
input-ad7879-touchscreen-driver.patch
input-mouse-alpsc-handle-touchpoints-buttons-correctly.patch
input-ads7846c-sparse-lock-annotation.patch
drivers-input-keyboard-atkbdc-use-function-for-generation-of-keyrelease-events.patch
drivers-input-keyboard-atkbdc-fujitsu-siemens-amilo-pa-1510-quirks.patch
input-allow-certain-ev_abs-events-to-bypass-all-filtering.patch
es-input-allow-certain-ev_abs-events-to-bypass-all-filtering-fix.patch
input-add-a-detailed-multi-touch-finger-data-report-protocol-rev2.patch
input-keyboard-hilkbdc-fix-crash-when-removing-hilkbd-module.patch
drivers-input-serio-hp_sdcc-fix-crash-when-removing-hp_sdc-module.patch
ads7846-pin-change-interrupt-support.patch
dmar-fix-endless-unknown-dmar-structure-type-loop.patch
sm501-fix-section-mismatches.patch
ricoh_mmc-use-suspend-resume_noirq-v2.patch
mmc-s3cmci-fix-hangup-in-do_pio_write.patch
mmc-fixes-and-enhancements-for-the-mmc-spi-driver.patch
mmc-add-modalias-linkage-for-mmc-sd-devices.patch
mmc-add-extended-csd-as-a-device-attribute.patch
mmc-add-extended-csd-as-a-device-attribute-update.patch
blackfin-nfc-driver-do-not-clobber-dmac1_perimux.patch
blackfin-nfc-driver-mark-bf5xx_nand_add_partition-as-__devinit.patch
blackfin-nfc-driver-drop-pointless-casts-with-set_dma_callback.patch
jffs2-force-the-jffs2-gc-daemon-to-behave-a-bit-better.patch
mtd-txx9-add-ndfmc-support.patch
mtd-rbtx4939-add-mtd-support.patch
mtd-rbtx4939-add-mtd-support-fix.patch
mtd-txx9-soc-nand-flash-memory-controller-driver.patch
mtd-rbtx4939-map-driver.patch
forcedeth-fix-mac-address-detection-on-network-card-regression-in-2623.patch
forcedeth-mgmt-unit-interface-changes.patch
e1000e-make-e1000e-default-to-the-same-kconfig-setting-as-e1000.patch
3x59x-fix-pci-resource-management.patch
gpio_free-might-sleep-blackfin-architecture.patch
ext4-allocate-s_blockgroup_lock-separately.patch
ext4-dont-inherit-inappropriate-inode-flags-from-parent.patch
ext4-tighten-restrictions-on-inode-flags.patch
sunrpc-fix-rdma-dependency.patch
fakephp-allocate-pci-resources-before-adding-the-device.patch
pci-quirks-unhide-overflow-device-on-i828675p-pe-chipsets.patch
pci-quirks-hp-hides-smbus-controller-in-compaq-nx9500-laptops.patch
sysrq-include-interrupth-instead-of-irqh.patch
irq-free-setup_irq-interrupt-using-free_irq.patch
if-0-ses_match_host.patch
scsi-replace-__inline-with-inline.patch
mpt-remove-unused-struct-mpt_proc_entry_t.patch
scsi-use-the-common-hex_asc-array-rather-than-a-private-one.patch
drivers-scsi-a2091c-make-2-functions-static.patch
drivers-scsi-a3000c-make-2-functions-static.patch
scsi-gdthc-use-unaligned-access-helpers.patch
scsi-annotate-gdth_rdcap_data-gdth_rdcap16_data-endianness.patch
esp-fix-section-mismatch-warning.patch
sg_io-dont-perform-unneeded-copy-in-compat-code.patch
scsi-mpt-suppress-debugobjects-warning.patch
paride-pgc-xs-confusion.patch
radio-si470x-add-usb-id-for-dealextreme-usb-radio.patch
usb-another-unusual_devs-entry-for-another-bad-argosy-storage-device.patch
usb-kill-prehistorical-comments-about-usb_ehci_hcd.patch
usb-fsl_qe_udc-fix-oops-on-qe-udc-probe-failure.patch
usb-fsl_qe_udc-fix-recursive-locking-bug-in-ch9getstatus.patch
usb-fsl_qe_udc-fix-qe-usb-controller-initialization.patch
usb-fsl_qe_udc-fix-disconnects-reporting-during-bus-reset.patch
usb-fsl_qe_udc-fix-muram-corruption-by-disabled-endpoints.patch
usb-fsl_qe_udc-fix-stalled-tx-requests-bug.patch
vfs-fix-vfs_rename_dir-for-fs_rename_does_d_move-filesystems.patch
raw-fix-rawctl-compat-ioctls-breakage-on-amd64-and-itanic.patch
vfs-update-fsh-to-use-inline-functions-when-no-file-locking-set.patch
vfs-further-changes-from-macro-to-inline-function-in-fsh.patch
mm.patch
scripts-add-x86-register-parser-to-markup_oopspl.patch
scripts-add-x86-64-bit-support-to-the-markup_oopspl-script.patch
hpilo-open-close-fix.patch
generic-swap-dont-return-a-value-from-swap.patch
misc-dell-laptop-should-depend-on-power_supply.patch
rtc-rtc-dm355evm-driver.patch
fbmem-copy_from-to_user-with-mutex-held-v3.patch
kmalloc-return-null-instead-of-link-failure.patch
shm-fix-shmctlshm_info-lockup-with-config_shmem.patch
revert-rlimit-permit-setting-rlimit_nofile-to-rlim_infinity.patch
seq_file-move-traverse-so-it-can-be-used-from-seq_read.patch
seq_file-properly-cope-with-pread.patch
ext2-add-blk_issue_flush-to-syncing-paths.patch
max3100-spi-uart-driver.patch
scsi-dpt_i2o-is-bust-on-ia64.patch
acpi-kconfig-fix-acpi_container-module-name.patch
acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read.patch
acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read-simplification.patch
arm-at91-fix-nr_aic_irqs-undeclared.patch
mfd-initialise-wm8350-interrupts-earlier.patch
mfd-mark-wm835x-usb_slv_500ma-bit-as-accessible.patch
mfd-pcf50633-terminate-i2c_device_id-list.patch
nommu-fix-a-number-of-issues-with-the-per-mm-vma-patch.patch
powerpc-fix-code-for-reserved-memory-spanning-across-nodes.patch
atmel_serial-might-lose-modem-status-change.patch
pipe_rdwr_fasync-fix-the-error-handling-to-prevent-the-leak-crash.patch
mm-mminit_validate_memmodel_limits-get-rid-of-redundant-test.patch
vmap-remove-needless-lock-and-list-in-vmap.patch
oom_kill-dont-call-for-int_sqrt0.patch
page_fault-retry-with-nopage_retry.patch
page_fault-retry-with-nopage_retry-fix.patch
page_fault-retry-with-nopage_retry-fix-fix.patch
radix-tree-gang-set-if-tagged-operation.patch
mm-shmemc-fix-division-by-zero.patch
mm-fix-pdflush-thread-creation-upper-bound.patch
mm-add-proc-controls-for-pdflush-threads.patch
mm-add-proc-controls-for-pdflush-threads-fix.patch
mm-add-proc-controls-for-pdflush-threads-fix-fix.patch
get_mm_hiwater_xxx-trivial-s-define-inline.patch
mm-get_nid_for_pfn-returns-int.patch
mm-unify-some-pmd_-functions.patch
proc-pid-maps-dont-show-pgoff-of-pure-anon-vmas.patch
proc-pid-maps-dont-show-pgoff-of-pure-anon-vmas-checkpatch-fixes.patch
hibernation-introduce-system_entering_hibernation.patch
dmi-introduce-dmi_first_match-to-make-the-interface-more-flexible.patch
sata-blacklisting-of-systems-that-spin-off-disks-during-acpi-power-off.patch
sata-ahci-blacklist-system-that-spins-off-disks-during-acpi-power-off.patch
sata-sil-blacklist-system-that-spins-off-disks-during-acpi-power-off.patch
sata-piix-blacklist-system-that-spins-off-disks-during-acpi-power-off.patch
loop-add-ioctl-to-resize-a-loop-device.patch
loop-add-ioctl-to-resize-a-loop-device-security-check-for-loop_set_capacity.patch
loop-add-ioctl-to-resize-a-loop-device-loop_set_capacity-sector_t-may-be-narrow-for-bit-shfit.patch
lib-rbtreec-optimize-rb_erase.patch
fix-longstanding-error-storage-size-of-__mod_dmi_device_table-isnt-known.patch
getrusage-fill-ru_maxrss-value.patch
softirq-introduce-statistics-for-softirq.patch
proc-export-statistics-for-softirq-to-proc.patch
proc-export-statistics-for-softirq-to-proc-fix.patch
proc-update-document-for-proc-softirqs-and-proc-stat.patch
hp-accelerometer-add-freefall-detection.patch
pci-use-pci_ioremap_bar-in-drivers-serial.patch
spi_mpc83xx-fix-sparse-warnings.patch
spi_mpc83xx-rework-chip-selects-handling.patch
spi_mpc83xx-add-of-platform-driver-bindings.patch
powerpc-add-mmc-spi-slot-bindings.patch
powerpc-83xx-add-mmc-spi-support-via-the-device-tree-for-mpc8323e-rdb.patch
powerpc-fsl_soc-isolate-legacy-fsl_spi-support-to-mpc832x_rdb-boards.patch
kprobes-cleanup-aggr_kprobe-related-code.patch
kprobes-move-export_symbol_gpl-just-after-function-definitions.patch
kprobes-cleanup-comment-style-in-kprobesh.patch
kprobes-rename-kprobe_enabled-to-kprobes_all_disarmed.patch
kprobes-support-per-kprobe-disabling.patch
kprobes-support-kretprobe-and-jprobe-per-probe-disabling.patch
rtc-convert-wm8350-use-new-alarm-and-update-operations.patch
rtc-convert-leap_year-into-an-inline.patch
rtc-add-platform-driver-for-efi.patch
rtc-add-platform-driver-for-efi-fix.patch
rtc-parisc-add-a-missing-include-for-linux-rtch.patch
rtc-parisc-remove-redundant-locking.patch
rtc-parisc-remove-struct-parisc_rtc.patch
rtc-parisc-use-rtc_valid_tm-in-parisc_get_time.patch
rtc-parisc-use-platform_driver_probe.patch
rtc-parisc-declare-rtc_parisc_dev-as-static.patch
rtc-parisc-remove-unnecessary-ret-variable.patch
rtc-parisc-remove-a-couple-unnecessary-variables.patch
rtc-parisc-rename-p-pointer-to-rtc.patch
rtc-ds1307-true-smbus-compatibility.patch
gpiolib-allow-gpios-to-be-named.patch
lxfb-fix-it-for-directfb-usage.patch
intelfb-support-i854.patch
pnpbios-fix-warning-if-no-hotplug.patch
pnpbios-propagate-kthread_run-error.patch
ext3-remove-the-bkl-in-ext3-ioctlc.patch
jbd-fix-oops-in-jbd_journal_init_inode-on-corrupted-fs.patch
hfsplus-identify-journal-info-block-in-volume-header.patch
hfsplus-fix-journal-detection.patch
ufs-sector_t-cannot-be-negative.patch
ufs-validate-maximum-fast-symlink-size-from-superblock.patch
ufs-dont-truncate-longer-ufs2-fast-symlinks.patch
ufs-ensure-fast-symlinks-are-nul-terminated.patch
ufs-copy-symlink-data-into-the-correct-union-member.patch
cgroups-fix-cgrouph-comments.patch
relax-ns_can_attach-checks-to-allow-attaching-to-grandchild-cgroups.patch
cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set.patch
cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-checkpatch-fixes.patch
kthread-dont-looking-for-a-task-in-create_kthread-2.patch
make-shm_get_stat-more-robust.patch
bin_elf_fdpic-check-the-return-value-of-clear_user.patch
pids-document-task_pgrp-task_session-is-not-safe-without-tasklist-rcu.patch
pids-document-task_pgrp-task_session-is-not-safe-without-tasklist-rcu-fix.patch
pids-improve-get_task_pid-to-fix-the-unsafe-sys_wait4-task_pgrp.patch
pids-refactor-vnr-nr_ns-helpers-to-make-them-safe.patch
pids-kill-now-unused-signal_struct-__pgrp-__session-and-friends.patch
nbd-trivial-cleanups.patch
relay-reset-consumed.patch
trace-code-and-documentation.patch
trace-code-and-documentation-merging-documentation-tracetxt-with-documentation-filesystems-relaytxt.patch
trace-sample.patch
edac-add-more-verbose-debug-info.patch
edac-remove-edacs-experimental-status.patch
kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists.patch
kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix.patch
sgi-gru-add-definitions-of-x86_64-gru-mmrs.patch
sgi-gru-add-definitions-of-x86_64-gru-mmrs-fix.patch
sgi-gru-add-definitions-of-ia64-gru-mmrs.patch
sgi-gru-add-macros-for-using-the-uv-hub-to-send-interrupts.patch
sgi-gru-misc-gru-cleanup.patch
sgi-gru-improvements-to-gru-debug-messages-statistics.patch
sgi-gru-change-gru-cch-commands-from-inline-functions-to-outofline-functions.patch
sgi-gru-add-statistics-to-the-gru-context-management-functions.patch
sgi-gru-add-support-for-a-user-to-explicitly-unload-a-gru-context.patch
sgi-gru-asid-context-management-bug-fixes.patch
sgi-gru-restructure-the-gru-vtop-functions.patch
sgi-gru-add-support-to-the-gru-driver-for-message-queue-interrupts.patch
sgi-gru-macro-for-scanning-all-gru-chiplets.patch
sgi-gru-fix-bugs-related-to-module-unload-of-the-gru-driver.patch
sgi-gru-support-multiple-pagesizes-in-gru.patch
synchronize-device-shutdown.patch
serios-async-shutdown.patch
sd-async-shutdown.patch
linuxpps-core-support.patch
linuxpps-core-support-sysfs-not-needed-variables-removed.patch
pps-userland-header-file-for-pps-api.patch
pps-documentation-programs-and-examples.patch
pps-linuxpps-clients-support.patch
ldisc-new-dcd_change-method-for-line-disciplines.patch
pps-parallel-port-clients-support.patch
factor-out-ifdefs-from-kernel-spinlockc-to-lock_contended_flags.patch
allow-rwlocks-to-re-enable-interrupts.patch
ia64-implement-interrupt-enabling-rwlocks.patch
fs-adfs-return-f_fsid-for-statfs2.patch
fs-affs-return-f_fsid-for-statfs2.patch
fs-befs-return-f_fsid-for-statfs2.patch
fs-cramfs-return-f_fsid-for-statfs2.patch
fs-efs-return-f_fsid-for-statfs2.patch
fs-fat-return-f_fsid-for-statfs2.patch
fs-hfs-return-f_fsid-for-statfs2.patch
fs-hfsplus-return-f_fsid-for-statfs2.patch
fs-hpfs-return-f_fsid-for-statfs2.patch
fs-isofs-return-f_fsid-for-statfs2.patch
fs-jfs-return-f_fsid-for-statfs2.patch
fs-minix-return-f_fsid-for-statfs2.patch
fs-omfs-return-f_fsid-for-statfs2.patch
fs-qnx4-return-f_fsid-for-statfs2.patch
fs-reiserfs-return-f_fsid-for-statfs2.patch
fs-romfs-return-f_fsid-for-statfs2.patch
fs-squashfs-return-f_fsid-for-statfs2.patch
fs-sysv-return-f_fsid-for-statfs2.patch
fs-udf-return-f_fsid-for-statfs2.patch
fs-ufs-return-f_fsid-for-statfs2.patch
nilfs2-add-document.patch
nilfs2-disk-format-and-userland-interface.patch
nilfs2-add-inode-and-other-major-structures.patch
nilfs2-integrated-block-mapping.patch
nilfs2-integrated-block-mapping-remove-nilfs-bmap-wrapper-macros.patch
nilfs2-integrated-block-mapping-remove-nilfs-bmap-wrapper-macros-checkpatch-fixes.patch
nilfs2-b-tree-based-block-mapping.patch
nilfs2-direct-block-mapping.patch
nilfs2-b-tree-node-cache.patch
nilfs2-buffer-and-page-operations.patch
nilfs2-meta-data-file.patch
nilfs2-persistent-object-allocator.patch
nilfs2-disk-address-translator.patch
nilfs2-inode-map-file.patch
nilfs2-checkpoint-file.patch
nilfs2-segment-usage-file.patch
nilfs2-inode-operations.patch
nilfs2-inode-operations-fix.patch
nilfs2-file-operations.patch
nilfs2-directory-entry-operations.patch
nilfs2-pathname-operations.patch
nilfs2-pathname-operations-fix.patch
nilfs2-operations-for-the_nilfs-core-object.patch
nilfs2-super-block-operations.patch
nilfs2-super-block-operations-fix.patch
nilfs2-segment-buffer.patch
nilfs2-segment-constructor.patch
nilfs2-segment-constructor-insert-checks-and-hole-block-allocation-in-page_mkwrite.patch
nilfs2-fix-miss-sync-issue-for-do_sync_mapping_range.patch
nilfs2-recovery-functions.patch
nilfs2-another-dat-for-garbage-collection.patch
nilfs2-block-cache-for-garbage-collection.patch
nilfs2-ioctl-operations.patch
nilfs2-update-makefile-and-kconfig.patch
nilfs2-fix-problems-of-memory-allocation-in-ioctl.patch
nilfs2-cleanup-nilfs_clear_inode.patch
nilfs2-avoid-double-error-caused-by-nilfs_transaction_end.patch
nilfs2-insert-explanations-in-gcinode-file.patch
nilfs2-add-maintainer.patch
nilfs2-fix-gc-failure-on-volumes-keeping-numerous-snapshots.patch
nilfs2-clean-up-indirect-function-calling-conventions.patch
reiser4-vfs-add-super_operationssync_inodes-2.patch
reiser4-export-remove_from_page_cache.patch
reiser4-export-find_get_pages.patch
reiser4.patch
reiser4-adjust-to-the-new-aops.patch
reiser4-adjust-to-the-new-aops-fixup.patch
reiser4-remove-simple_prepare_write-usage.patch
reiser4-remove-simple_prepare_write-usage-checkpatch-fixes.patch
fs-symlink-write_begin-allocation-context-fix-reiser4-fix.patch
reiser4-handling-error-returned-by-d_obtain_alias-fixup.patch
make-sure-nobodys-leaking-resources.patch
journal_add_journal_head-debug.patch
releasing-resources-with-children.patch
make-frame_pointer-default=y.patch
mutex-subsystem-synchro-test-module.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
add-debugging-aid-for-memory-initialisation-problems.patch
shrink_slab-handle-bad-shrinkers.patch
keep-track-of-network-interface-renaming.patch
workaround-for-a-pci-restoring-bug.patch
prio_tree-debugging-patch.patch
single_open-seq_release-leak-diagnostics.patch
add-a-refcount-check-in-dput.patch
getblk-handle-2tb-devices.patch
getblk-handle-2tb-devices-fix.patch
undeprecate-pci_find_device.patch
notify_change-callers-must-hold-i_mutex.patch
drivers-net-bonding-bond_sysfsc-suppress-uninitialized-var-warning.patch
w1-build-fix.patch

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> and will soon be available at
> 
>    git://git.zen-sources.org/zen/mmotm.git


10 randconfigs on i386, 1 good build.

The other 9 ended with either of these build errors:

init/main.c:876: error: 'struct task_struct' has no member named 'mems_allowed'
CONFIG_CPUSETS=n


or

kernel/printk.c:142: error: implicit declaration of function 'VMCOREINFO_SYMBOL'
# CONFIG_KEXEC is not set

-- 
~Randy

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Andrew Morton]

On Wed, 28 Jan 2009 08:56:31 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://git.zen-sources.org/zen/mmotm.git
> 
> 
> 10 randconfigs on i386, 1 good build.
> 
> The other 9 ended with either of these build errors:
> 
> init/main.c:876: error: 'struct task_struct' has no member named 'mems_allowed'
> CONFIG_CPUSETS=n

Well that sucks a bit.

--- a/init/main.c~cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-fix
+++ a/init/main.c
@@ -873,7 +873,9 @@ static int __init kernel_init(void * unu
 	 */
 	init_pid_ns.child_reaper = current;
 
+#ifdef CONFIG_CPUSETS
 	current->mems_allowed = node_possible_map;
+#endif
 
 	cad_pid = task_pid(current);
 
_

> 
> or
> 
> kernel/printk.c:142: error: implicit declaration of function 'VMCOREINFO_SYMBOL'
> # CONFIG_KEXEC is not set
> 

So does that.

--- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
+++ a/kernel/printk.c
@@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
 static int log_buf_len = __LOG_BUF_LEN;
 static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
 
+#ifdef CONFIG_KEXEC
 void log_buf_kexec_setup(void)
 {
 	VMCOREINFO_SYMBOL(log_buf);
 	VMCOREINFO_SYMBOL(log_end);
 }
+#endif
 
 static int __init log_buf_len_setup(char *str)
 {
_

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Simon Horman]

On Wed, Jan 28, 2009 at 04:30:40PM -0800, Andrew Morton wrote:
> On Wed, 28 Jan 2009 08:56:31 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > akpm@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > > 
> > >    http://userweb.kernel.org/~akpm/mmotm/
> > > 
> > > and will soon be available at
> > > 
> > >    git://git.zen-sources.org/zen/mmotm.git
> > 
> > 
> > 10 randconfigs on i386, 1 good build.
> > 
> > The other 9 ended with either of these build errors:
> > 

[snip]

> So does that.
> 
> --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> +++ a/kernel/printk.c
> @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
>  static int log_buf_len = __LOG_BUF_LEN;
>  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
>  
> +#ifdef CONFIG_KEXEC
>  void log_buf_kexec_setup(void)
>  {
>  	VMCOREINFO_SYMBOL(log_buf);
>  	VMCOREINFO_SYMBOL(log_end);
>  }
> +#endif
>  
>  static int __init log_buf_len_setup(char *str)
>  {
> _

Weird, I thought I checked that just now. In any case this email
was already in my inbox. In any case, I can now produce the problem,
and this patch resolves it.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en

Re: mmotm 2009-01-28-02-17 uploaded

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/

cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set.patch

breaks compiles with CONFIG_CPUSETS=n

  CC      init/main.o
init/main.c: In function 'kernel_init':
init/main.c:876: error: 'struct task_struct' has no member named 'mems_allowed'
make[1]: *** [init/main.o] Error 1

Looks like it adds a reference to task->mems_allowed to kernel/main.c
and kernel/kthreads.c and neither one is wrapped with #ifdef CONFIG_CPUSETS
or anything.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: mmotm 2009-01-28-02-17 uploaded

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/

kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists.patch

breaks the compile with CONFIG_KEXEC=n

  CC      kernel/printk.o
kernel/printk.c: In function 'log_buf_kexec_setup':
kernel/printk.c:142: error: implicit declaration of function 'VMCOREINFO_SYMBOL'
make[1]: *** [kernel/printk.o] Error 1
make: *** [kernel] Error 2


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Neil Horman]

On Thu, Jan 29, 2009 at 11:28:50AM +0900, Simon Horman wrote:
> On Wed, Jan 28, 2009 at 04:30:40PM -0800, Andrew Morton wrote:
> > On Wed, 28 Jan 2009 08:56:31 -0800
> > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > 
> > > akpm@linux-foundation.org wrote:
> > > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > > > 
> > > >    http://userweb.kernel.org/~akpm/mmotm/
> > > > 
> > > > and will soon be available at
> > > > 
> > > >    git://git.zen-sources.org/zen/mmotm.git
> > > 
> > > 
> > > 10 randconfigs on i386, 1 good build.
> > > 
> > > The other 9 ended with either of these build errors:
> > > 
> 
> [snip]
> 
> > So does that.
> > 
> > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > +++ a/kernel/printk.c
> > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> >  static int log_buf_len = __LOG_BUF_LEN;
> >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> >  
> > +#ifdef CONFIG_KEXEC
> >  void log_buf_kexec_setup(void)
> >  {
> >  	VMCOREINFO_SYMBOL(log_buf);
> >  	VMCOREINFO_SYMBOL(log_end);
> >  }
> > +#endif
> >  
> >  static int __init log_buf_len_setup(char *str)
> >  {
> > _
> 
> Weird, I thought I checked that just now. In any case this email
> was already in my inbox. In any case, I can now produce the problem,
> and this patch resolves it.
> 

Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
of which apparently must be ifdefd for this to work.  Why not just fix it in
conditional definition?

Neil

> -- 
> Simon Horman
>   VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
>   H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en
> 
> 

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Vivek Goyal]

On Thu, Jan 29, 2009 at 07:09:35AM -0500, Neil Horman wrote:
> On Thu, Jan 29, 2009 at 11:28:50AM +0900, Simon Horman wrote:
> > On Wed, Jan 28, 2009 at 04:30:40PM -0800, Andrew Morton wrote:
> > > On Wed, 28 Jan 2009 08:56:31 -0800
> > > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > 
> > > > akpm@linux-foundation.org wrote:
> > > > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > > > > 
> > > > >    http://userweb.kernel.org/~akpm/mmotm/
> > > > > 
> > > > > and will soon be available at
> > > > > 
> > > > >    git://git.zen-sources.org/zen/mmotm.git
> > > > 
> > > > 
> > > > 10 randconfigs on i386, 1 good build.
> > > > 
> > > > The other 9 ended with either of these build errors:
> > > > 
> > 
> > [snip]
> > 
> > > So does that.
> > > 
> > > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > > +++ a/kernel/printk.c
> > > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> > >  static int log_buf_len = __LOG_BUF_LEN;
> > >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> > >  
> > > +#ifdef CONFIG_KEXEC
> > >  void log_buf_kexec_setup(void)
> > >  {
> > >  	VMCOREINFO_SYMBOL(log_buf);
> > >  	VMCOREINFO_SYMBOL(log_end);
> > >  }
> > > +#endif
> > >  
> > >  static int __init log_buf_len_setup(char *str)
> > >  {
> > > _
> > 
> > Weird, I thought I checked that just now. In any case this email
> > was already in my inbox. In any case, I can now produce the problem,
> > and this patch resolves it.
> > 
> 
> Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
> assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
> that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
> of which apparently must be ifdefd for this to work.  Why not just fix it in
> conditional definition?
> 

This kind of makes sense. We probably should be taken care in kexec.h with
empty definition of VMCOREINFO_SYMBOL so that we can get rid of #ifdef
KEXEC in printk.c

Neil, do you want to throw in a patch for that.

Thanks
Vivek

Re: mmotm 2009-01-28-02-17 uploaded - docking station issues.

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/

% ls -l /sys/devices/platform/dock.0/docked
-r--r--r-- 1 root root 4096 2009-01-29 10:49 /sys/devices/platform/dock.0/docked
% cat /sys/devices/platform/dock.0/docked
ñÞcat: write error: Bad address

strace of the cat shows:

open("/sys/devices/platform/dock.0/docked", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 1812586496

Under 2.6.29-rc2-mmotm0116, this would return either "0" or "1", not 4K
of nulls.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: mmotm 2009-01-28-02-17 uploaded

[Andrew Morton]

On Wed, 28 Jan 2009 22:43:24 -0500 Valdis.Kletnieks@vt.edu wrote:

> On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> 
> cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set.patch
> 
> breaks compiles with CONFIG_CPUSETS=n
> 
>   CC      init/main.o
> init/main.c: In function 'kernel_init':
> init/main.c:876: error: 'struct task_struct' has no member named 'mems_allowed'
> make[1]: *** [init/main.o] Error 1
> 
> Looks like it adds a reference to task->mems_allowed to kernel/main.c
> and kernel/kthreads.c and neither one is wrapped with #ifdef CONFIG_CPUSETS
> or anything.
> 

yup.  mmotm-2009-01-29-02-29 has

diff -puN include/linux/cpuset.h~cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-fix-2 include/linux/cpuset.h
--- a/include/linux/cpuset.h~cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-fix-2
+++ a/include/linux/cpuset.h
@@ -79,6 +79,11 @@ extern void rebuild_sched_domains(void);
 
 extern void cpuset_print_task_mems_allowed(struct task_struct *p);
 
+static inline void set_mems_allowed(nodemask_t nodemask)
+{
+	current->mems_allowed = nodemask;
+}
+
 #else /* !CONFIG_CPUSETS */
 
 static inline int cpuset_init(void) { return 0; }
@@ -163,6 +168,10 @@ static inline void cpuset_print_task_mem
 {
 }
 
+static inline void set_mems_allowed(nodemask_t nodemask)
+{
+}
+
 #endif /* !CONFIG_CPUSETS */
 
 #endif /* _LINUX_CPUSET_H */
diff -puN init/main.c~cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-fix-2 init/main.c
--- a/init/main.c~cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-fix-2
+++ a/init/main.c
@@ -873,7 +873,7 @@ static int __init kernel_init(void * unu
 	 */
 	init_pid_ns.child_reaper = current;
 
-	current->mems_allowed = node_possible_map;
+	set_mems_allowed(node_possible_map);
 
 	cad_pid = task_pid(current);
 
diff -puN kernel/kthread.c~cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-fix-2 kernel/kthread.c
--- a/kernel/kthread.c~cpuset-fix-allocating-page-cache-slab-object-on-the-unallowed-node-when-memory-spread-is-set-fix-2
+++ a/kernel/kthread.c
@@ -13,6 +13,8 @@
 #include <linux/file.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/cpuset.h>
+
 #include <trace/sched.h>
 
 #define KTHREAD_NICE_LEVEL (-5)
@@ -242,7 +244,7 @@ int kthreadd(void *unused)
 	set_user_nice(tsk, KTHREAD_NICE_LEVEL);
 	set_cpus_allowed_ptr(tsk, CPU_MASK_ALL_PTR);
 
-	current->mems_allowed = node_possible_map;
+	set_mems_allowed(node_possible_map);
 	current->flags |= PF_NOFREEZE | PF_FREEZER_NOSIG;
 
 	for (;;) {
_

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Andrew Morton]

On Thu, 29 Jan 2009 07:09:35 -0500 Neil Horman <nhorman@tuxdriver.com> wrote:

> > > So does that.
> > > 
> > > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > > +++ a/kernel/printk.c
> > > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> > >  static int log_buf_len = __LOG_BUF_LEN;
> > >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> > >  
> > > +#ifdef CONFIG_KEXEC
> > >  void log_buf_kexec_setup(void)
> > >  {
> > >  	VMCOREINFO_SYMBOL(log_buf);
> > >  	VMCOREINFO_SYMBOL(log_end);
> > >  }
> > > +#endif
> > >  
> > >  static int __init log_buf_len_setup(char *str)
> > >  {
> > > _
> > 
> > Weird, I thought I checked that just now. In any case this email
> > was already in my inbox. In any case, I can now produce the problem,
> > and this patch resolves it.
> > 
> 
> Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
> assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
> that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
> of which apparently must be ifdefd for this to work.  Why not just fix it in
> conditional definition?

I didn't do that because then we'd have an empty function log_buf_kexec_setup()
floating about in every vmlinux.

Hardly a big issue, but a bit regrettable.

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Neil Horman]

On Thu, Jan 29, 2009 at 10:01:57AM -0800, Andrew Morton wrote:
> On Thu, 29 Jan 2009 07:09:35 -0500 Neil Horman <nhorman@tuxdriver.com> wrote:
> 
> > > > So does that.
> > > > 
> > > > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > > > +++ a/kernel/printk.c
> > > > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> > > >  static int log_buf_len = __LOG_BUF_LEN;
> > > >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> > > >  
> > > > +#ifdef CONFIG_KEXEC
> > > >  void log_buf_kexec_setup(void)
> > > >  {
> > > >  	VMCOREINFO_SYMBOL(log_buf);
> > > >  	VMCOREINFO_SYMBOL(log_end);
> > > >  }
> > > > +#endif
> > > >  
> > > >  static int __init log_buf_len_setup(char *str)
> > > >  {
> > > > _
> > > 
> > > Weird, I thought I checked that just now. In any case this email
> > > was already in my inbox. In any case, I can now produce the problem,
> > > and this patch resolves it.
> > > 
> > 
> > Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
> > assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
> > that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
> > of which apparently must be ifdefd for this to work.  Why not just fix it in
> > conditional definition?
> 
> I didn't do that because then we'd have an empty function log_buf_kexec_setup()
> floating about in every vmlinux.
> 
> Hardly a big issue, but a bit regrettable.
> 
Won't the compiler just eliminate that symbol during final link, given that its
not an exported symbol?
Neil

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Neil Horman]

On Thu, Jan 29, 2009 at 09:20:49AM -0500, Vivek Goyal wrote:
> On Thu, Jan 29, 2009 at 07:09:35AM -0500, Neil Horman wrote:
> > On Thu, Jan 29, 2009 at 11:28:50AM +0900, Simon Horman wrote:
> > > On Wed, Jan 28, 2009 at 04:30:40PM -0800, Andrew Morton wrote:
> > > > On Wed, 28 Jan 2009 08:56:31 -0800
> > > > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > > 
> > > > > akpm@linux-foundation.org wrote:
> > > > > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > > > > > 
> > > > > >    http://userweb.kernel.org/~akpm/mmotm/
> > > > > > 
> > > > > > and will soon be available at
> > > > > > 
> > > > > >    git://git.zen-sources.org/zen/mmotm.git
> > > > > 
> > > > > 
> > > > > 10 randconfigs on i386, 1 good build.
> > > > > 
> > > > > The other 9 ended with either of these build errors:
> > > > > 
> > > 
> > > [snip]
> > > 
> > > > So does that.
> > > > 
> > > > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > > > +++ a/kernel/printk.c
> > > > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> > > >  static int log_buf_len = __LOG_BUF_LEN;
> > > >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> > > >  
> > > > +#ifdef CONFIG_KEXEC
> > > >  void log_buf_kexec_setup(void)
> > > >  {
> > > >  	VMCOREINFO_SYMBOL(log_buf);
> > > >  	VMCOREINFO_SYMBOL(log_end);
> > > >  }
> > > > +#endif
> > > >  
> > > >  static int __init log_buf_len_setup(char *str)
> > > >  {
> > > > _
> > > 
> > > Weird, I thought I checked that just now. In any case this email
> > > was already in my inbox. In any case, I can now produce the problem,
> > > and this patch resolves it.
> > > 
> > 
> > Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
> > assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
> > that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
> > of which apparently must be ifdefd for this to work.  Why not just fix it in
> > conditional definition?
> > 
> 
> This kind of makes sense. We probably should be taken care in kexec.h with
> empty definition of VMCOREINFO_SYMBOL so that we can get rid of #ifdef
> KEXEC in printk.c
> 
> Neil, do you want to throw in a patch for that.
> 

I'd be happy to put this together, I'll do so shortly.
Neil

> Thanks
> Vivek
> 

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Andrew Morton]

On Thu, 29 Jan 2009 14:27:34 -0500
Neil Horman <nhorman@tuxdriver.com> wrote:

> On Thu, Jan 29, 2009 at 10:01:57AM -0800, Andrew Morton wrote:
> > On Thu, 29 Jan 2009 07:09:35 -0500 Neil Horman <nhorman@tuxdriver.com> wrote:
> > 
> > > > > So does that.
> > > > > 
> > > > > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > > > > +++ a/kernel/printk.c
> > > > > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> > > > >  static int log_buf_len = __LOG_BUF_LEN;
> > > > >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> > > > >  
> > > > > +#ifdef CONFIG_KEXEC
> > > > >  void log_buf_kexec_setup(void)
> > > > >  {
> > > > >  	VMCOREINFO_SYMBOL(log_buf);
> > > > >  	VMCOREINFO_SYMBOL(log_end);
> > > > >  }
> > > > > +#endif
> > > > >  
> > > > >  static int __init log_buf_len_setup(char *str)
> > > > >  {
> > > > > _
> > > > 
> > > > Weird, I thought I checked that just now. In any case this email
> > > > was already in my inbox. In any case, I can now produce the problem,
> > > > and this patch resolves it.
> > > > 
> > > 
> > > Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
> > > assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
> > > that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
> > > of which apparently must be ifdefd for this to work.  Why not just fix it in
> > > conditional definition?
> > 
> > I didn't do that because then we'd have an empty function log_buf_kexec_setup()
> > floating about in every vmlinux.
> > 
> > Hardly a big issue, but a bit regrettable.
> > 
> Won't the compiler just eliminate that symbol during final link, given that its
> not an exported symbol?

I don't think it's that smart.

akpm:/home/akpm> cat t.c

void foo(void)
{
}
	
main()
{
}
akpm:/home/akpm> gcc -O2 t.c
akpm:/home/akpm> nm a.out|grep foo
08048300 T foo

With -ffunction-sections or other fancy options, maybe.  And it'll be
version-dependent.

Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Neil Horman]

On Thu, Jan 29, 2009 at 11:48:59AM -0800, Andrew Morton wrote:
> On Thu, 29 Jan 2009 14:27:34 -0500
> Neil Horman <nhorman@tuxdriver.com> wrote:
> 
> > On Thu, Jan 29, 2009 at 10:01:57AM -0800, Andrew Morton wrote:
> > > On Thu, 29 Jan 2009 07:09:35 -0500 Neil Horman <nhorman@tuxdriver.com> wrote:
> > > 
> > > > > > So does that.
> > > > > > 
> > > > > > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > > > > > +++ a/kernel/printk.c
> > > > > > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> > > > > >  static int log_buf_len = __LOG_BUF_LEN;
> > > > > >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> > > > > >  
> > > > > > +#ifdef CONFIG_KEXEC
> > > > > >  void log_buf_kexec_setup(void)
> > > > > >  {
> > > > > >  	VMCOREINFO_SYMBOL(log_buf);
> > > > > >  	VMCOREINFO_SYMBOL(log_end);
> > > > > >  }
> > > > > > +#endif
> > > > > >  
> > > > > >  static int __init log_buf_len_setup(char *str)
> > > > > >  {
> > > > > > _
> > > > > 
> > > > > Weird, I thought I checked that just now. In any case this email
> > > > > was already in my inbox. In any case, I can now produce the problem,
> > > > > and this patch resolves it.
> > > > > 
> > > > 
> > > > Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
> > > > assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
> > > > that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
> > > > of which apparently must be ifdefd for this to work.  Why not just fix it in
> > > > conditional definition?
> > > 
> > > I didn't do that because then we'd have an empty function log_buf_kexec_setup()
> > > floating about in every vmlinux.
> > > 
> > > Hardly a big issue, but a bit regrettable.
> > > 
> > Won't the compiler just eliminate that symbol during final link, given that its
> > not an exported symbol?
> 
> I don't think it's that smart.
> 
> akpm:/home/akpm> cat t.c
> 
> void foo(void)
> {
> }
> 	
> main()
> {
> }
> akpm:/home/akpm> gcc -O2 t.c
> akpm:/home/akpm> nm a.out|grep foo
> 08048300 T foo
> 
> With -ffunction-sections or other fancy options, maybe.  And it'll be
> version-dependent.
> 
huh, how about that.  I always thought we stripped out empty functions.  Perhaps
that a later stage in most of the build processes I've used (a strip or
something later on perhaps).  Anywho, I stand corrected.  In light of this, its
probably best that we keep what we have, and just ifdef out the callers.

Thanks Andrew!
Neil

> 

Re: mmotm 2009-01-28-02-17 uploaded - docking station issues.

[Andrew Morton]

On Thu, 29 Jan 2009 11:25:43 -0500 Valdis.Kletnieks@vt.edu wrote:

> On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> 
> % ls -l /sys/devices/platform/dock.0/docked
> -r--r--r-- 1 root root 4096 2009-01-29 10:49 /sys/devices/platform/dock.0/docked
> % cat /sys/devices/platform/dock.0/docked
> ñÞcat: write error: Bad address
> 
> strace of the cat shows:
> 
> open("/sys/devices/platform/dock.0/docked", O_RDONLY) = 3
> fstat(3, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
> read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 1812586496
> 
> Under 2.6.29-rc2-mmotm0116, this would return either "0" or "1", not 4K
> of nulls.
> 

Is it due to 

acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read.patch

and/or

acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read-simplification.patch

?
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mmotm 2009-01-28-02-17 uploaded - docking station issues.

[Andrew Morton]

On Thu, 29 Jan 2009 11:25:43 -0500 Valdis.Kletnieks@vt.edu wrote:

> On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> 
> % ls -l /sys/devices/platform/dock.0/docked
> -r--r--r-- 1 root root 4096 2009-01-29 10:49 /sys/devices/platform/dock.0/docked
> % cat /sys/devices/platform/dock.0/docked
> ñÞcat: write error: Bad address
> 
> strace of the cat shows:
> 
> open("/sys/devices/platform/dock.0/docked", O_RDONLY) = 3
> fstat(3, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
> read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 1812586496
> 
> Under 2.6.29-rc2-mmotm0116, this would return either "0" or "1", not 4K
> of nulls.
> 

Is it due to 

acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read.patch

and/or

acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read-simplification.patch

?

Re: mmotm 2009-01-28-02-17 uploaded - docking station issues.

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

On Fri, 30 Jan 2009 21:03:52 PST, Andrew Morton said:
> On Thu, 29 Jan 2009 11:25:43 -0500 Valdis.Kletnieks@vt.edu wrote:
> 
> > On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > >    http://userweb.kernel.org/~akpm/mmotm/

> > % ls -l /sys/devices/platform/dock.0/docked
> > -r--r--r-- 1 root root 4096 2009-01-29 10:49 /sys/devices/platform/dock.0/docked
> > % cat /sys/devices/platform/dock.0/docked
> > =F1=DEcat: write error: Bad address
> >
> > strace of the cat shows:
> >
> > open("/sys/devices/platform/dock.0/docked", O_RDONLY) = 3
> > fstat(3, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
> > read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 1812586496

> > Under 2.6.29-rc2-mmotm0116, this would return either "0" or "1", not 4K
> > of nulls.

> Is it due to
>
> acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read.patch

Bingo. Reverting that patch and the sysfs-read-simplified.patch fixed it.

So obviously something in there doesn't agree with the innards of my laptop -

Dell Latitude D820, BIOS is A09 (current), if that helps anybody...

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: mmotm 2009-01-28-02-17 uploaded - docking station issues.

[Andrew Morton]

On Sat, 31 Jan 2009 03:40:14 -0500 Valdis.Kletnieks@vt.edu wrote:

> On Fri, 30 Jan 2009 21:03:52 PST, Andrew Morton said:
> > On Thu, 29 Jan 2009 11:25:43 -0500 Valdis.Kletnieks@vt.edu wrote:
> > 
> > > On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> > > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > > >    http://userweb.kernel.org/~akpm/mmotm/
> 
> > > % ls -l /sys/devices/platform/dock.0/docked
> > > -r--r--r-- 1 root root 4096 2009-01-29 10:49 /sys/devices/platform/dock.0/docked
> > > % cat /sys/devices/platform/dock.0/docked
> > > =F1=DEcat: write error: Bad address
> > >
> > > strace of the cat shows:
> > >
> > > open("/sys/devices/platform/dock.0/docked", O_RDONLY) = 3
> > > fstat(3, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
> > > read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 1812586496
> 
> > > Under 2.6.29-rc2-mmotm0116, this would return either "0" or "1", not 4K
> > > of nulls.
> 
> > Is it due to
> >
> > acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read.patch
> 
> Bingo. Reverting that patch and the sysfs-read-simplified.patch fixed it.
> 
> So obviously something in there doesn't agree with the innards of my laptop -
> 

urgh,
acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read-simplification.patch
is completely wrong (return value) and the insane warning storm which
kernel builds create hid that from me.

I dropped it.