All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Frank Seidel <frank@f-seidel.de>
Cc: Frank Seidel <fseidel@suse.de>,
	linux kernel <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
	kristen.c.accardi@intel.com, ashok.raj@intel.com,
	shaohua.li@intel.com, anil.s.keshavamurthy@intel.com,
	fenghua.yu@intel.com, akpm@linux-foundation.org,
	Frans Pop <elendil@planet.nl>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH] PCI: add missing KERN_* constants to printks
Date: Thu, 5 Feb 2009 09:49:59 -0800	[thread overview]
Message-ID: <20090205174959.GA29368@kroah.com> (raw)
In-Reply-To: <498B23A5.6090006@f-seidel.de>

On Thu, Feb 05, 2009 at 06:36:37PM +0100, Frank Seidel wrote:
> Frank Seidel wrote:
> > No, its definition in pciehp.h is:
> > ...
> 
> P.S.: I also thought about changing it directly inside
> the macro. Would you prefer that?
> I decided against that because those printk-macros often
> still use the loglevel prefix and i didn't want to change
> semantics of the macro (eventhough one would of course
> suspect it to set KERN_DEBUG).

I think that any macro called "dbg" should set the level automatically,
as that is the way that the other macros in the kernel with this name do
things...

thanks,

greg k-h

  reply	other threads:[~2009-02-05 17:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 17:25 [PATCH] PCI: add missing KERN_* constants to printks Frank Seidel
2009-02-05 17:28 ` Greg KH
2009-02-05 17:32   ` Frank Seidel
2009-02-05 17:36     ` Frank Seidel
2009-02-05 17:49       ` Greg KH [this message]
2009-02-05 18:01         ` Frank Seidel
2009-02-05 18:02 ` [PATCHv2] " Frank Seidel
2009-02-06  8:04   ` Kenji Kaneshige
2009-02-06  8:07     ` Frank Seidel
2009-02-06  8:57       ` Kenji Kaneshige
2009-02-06  9:01   ` Taku Izumi
2009-02-06  9:16     ` Frank Seidel
2009-02-06 10:23     ` Geert Uytterhoeven
2009-02-06  9:23 ` [PATCHv3] " Frank Seidel
2009-02-09  6:47   ` Kenji Kaneshige
2009-02-13 21:16   ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090205174959.GA29368@kroah.com \
    --to=greg@kroah.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=ashok.raj@intel.com \
    --cc=elendil@planet.nl \
    --cc=fenghua.yu@intel.com \
    --cc=frank@f-seidel.de \
    --cc=fseidel@suse.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.