All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Seidel <fseidel@suse.de>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
	greg@kroah.com, kristen.c.accardi@intel.com, ashok.raj@intel.com,
	shaohua.li@intel.com, anil.s.keshavamurthy@intel.com,
	fenghua.yu@intel.com, akpm@linux-foundation.org,
	frank@f-seidel.de, Frans Pop <elendil@planet.nl>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCHv2] PCI: add missing KERN_* constants to printks
Date: Fri, 06 Feb 2009 09:07:09 +0100	[thread overview]
Message-ID: <498BEFAD.8070102@suse.de> (raw)
In-Reply-To: <498BEEF6.2040803@jp.fujitsu.com>

Kenji Kaneshige wrote:
> How about below. I think we can write printk in one line.
> 
> #define dbg(format, arg...)						\
> do {									\
> 	if (pciehp_debug)						\
> 		printk(KERN_DEBUG "%s: " format, MY_NAME, ## arg);	\
> } while (0)

I wanted to keep the change as simple as possible and didn't wanna
play with surrounding indentation. But yes, if thats preferred...
i gonna change the patch to this. Shall i?

Thanks,
Frank

  reply	other threads:[~2009-02-06  8:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 17:25 [PATCH] PCI: add missing KERN_* constants to printks Frank Seidel
2009-02-05 17:28 ` Greg KH
2009-02-05 17:32   ` Frank Seidel
2009-02-05 17:36     ` Frank Seidel
2009-02-05 17:49       ` Greg KH
2009-02-05 18:01         ` Frank Seidel
2009-02-05 18:02 ` [PATCHv2] " Frank Seidel
2009-02-06  8:04   ` Kenji Kaneshige
2009-02-06  8:07     ` Frank Seidel [this message]
2009-02-06  8:57       ` Kenji Kaneshige
2009-02-06  9:01   ` Taku Izumi
2009-02-06  9:16     ` Frank Seidel
2009-02-06 10:23     ` Geert Uytterhoeven
2009-02-06  9:23 ` [PATCHv3] " Frank Seidel
2009-02-09  6:47   ` Kenji Kaneshige
2009-02-13 21:16   ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498BEFAD.8070102@suse.de \
    --to=fseidel@suse.de \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=ashok.raj@intel.com \
    --cc=elendil@planet.nl \
    --cc=fenghua.yu@intel.com \
    --cc=frank@f-seidel.de \
    --cc=greg@kroah.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.