From: Frank Seidel <fseidel@suse.de>
To: linux kernel <linux-kernel@vger.kernel.org>
Cc: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
greg@kroah.com, kristen.c.accardi@intel.com, ashok.raj@intel.com,
shaohua.li@intel.com, anil.s.keshavamurthy@intel.com,
fenghua.yu@intel.com, akpm@linux-foundation.org,
frank@f-seidel.de, fseidel@suse.de, Frans Pop <elendil@planet.nl>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: [PATCH] PCI: add missing KERN_* constants to printks
Date: Thu, 05 Feb 2009 18:25:42 +0100 [thread overview]
Message-ID: <498B2116.6010707@suse.de> (raw)
From: Frank Seidel <frank@f-seidel.de>
According to kerneljanitors todo list all printk calls (beginning
a new line) should have an according KERN_* constant.
Those are the missing pieces here for the pci subsystem.
Signed-off-by: Frank Seidel <frank@f-seidel.de>
---
drivers/pci/hotplug/pciehp_core.c | 6 +++---
drivers/pci/hotplug/shpchp_core.c | 4 ++--
drivers/pci/intel-iommu.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
--- a/drivers/pci/hotplug/pciehp_core.c
+++ b/drivers/pci/hotplug/pciehp_core.c
@@ -526,16 +526,16 @@ static int __init pcied_init(void)
pciehp_firmware_init();
retval = pcie_port_service_register(&hpdriver_portdrv);
- dbg("pcie_port_service_register = %d\n", retval);
+ dbg(KERN_DEBUG "pcie_port_service_register = %d\n", retval);
info(DRIVER_DESC " version: " DRIVER_VERSION "\n");
if (retval)
- dbg("Failure to register service\n");
+ dbg(KERN_DEBUG "Failure to register service\n");
return retval;
}
static void __exit pcied_cleanup(void)
{
- dbg("unload_pciehpd()\n");
+ dbg(KERN_DEBUG "unload_pciehpd()\n");
pcie_port_service_unregister(&hpdriver_portdrv);
info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
}
--- a/drivers/pci/hotplug/shpchp_core.c
+++ b/drivers/pci/hotplug/shpchp_core.c
@@ -396,14 +396,14 @@ static int __init shpcd_init(void)
int retval = 0;
retval = pci_register_driver(&shpc_driver);
- dbg("%s: pci_register_driver = %d\n", __func__, retval);
+ dbg(KERN_DEBUG "%s: pci_register_driver = %d\n", __func__, retval);
info(DRIVER_DESC " version: " DRIVER_VERSION "\n");
return retval;
}
static void __exit shpcd_cleanup(void)
{
- dbg("unload_shpchpd()\n");
+ dbg(KERN_DEBUG "unload_shpchpd()\n");
pci_unregister_driver(&shpc_driver);
info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
}
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi
ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024);
if (ret)
- printk("IOMMU: Failed to create 0-64M identity map, "
+ printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, "
"floppy might not work\n");
}
next reply other threads:[~2009-02-05 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 17:25 Frank Seidel [this message]
2009-02-05 17:28 ` [PATCH] PCI: add missing KERN_* constants to printks Greg KH
2009-02-05 17:32 ` Frank Seidel
2009-02-05 17:36 ` Frank Seidel
2009-02-05 17:49 ` Greg KH
2009-02-05 18:01 ` Frank Seidel
2009-02-05 18:02 ` [PATCHv2] " Frank Seidel
2009-02-06 8:04 ` Kenji Kaneshige
2009-02-06 8:07 ` Frank Seidel
2009-02-06 8:57 ` Kenji Kaneshige
2009-02-06 9:01 ` Taku Izumi
2009-02-06 9:16 ` Frank Seidel
2009-02-06 10:23 ` Geert Uytterhoeven
2009-02-06 9:23 ` [PATCHv3] " Frank Seidel
2009-02-09 6:47 ` Kenji Kaneshige
2009-02-13 21:16 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498B2116.6010707@suse.de \
--to=fseidel@suse.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ashok.raj@intel.com \
--cc=elendil@planet.nl \
--cc=fenghua.yu@intel.com \
--cc=frank@f-seidel.de \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.