[PATCH] auxdisplay: remove PARPORT dependency

[PATCH] auxdisplay: remove PARPORT dependency

[hartleys]

Remove PARPORT dependency for Auxiliary Display support.

This is not needed since the dependency for the KS0108 driver is
PARPORT_PC.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 14b9d5f..c07e725 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -6,7 +6,6 @@
 #
 
 menuconfig AUXDISPLAY
-	depends on PARPORT
 	bool "Auxiliary Display support"
 	---help---
 	  Say Y here to get to see options for auxiliary display
drivers.
@@ -14,7 +13,7 @@ menuconfig AUXDISPLAY
 
 	  If you say N, all options in this submenu will be skipped and
disabled.
 
-if AUXDISPLAY && PARPORT
+if AUXDISPLAY
 
 config KS0108
 	tristate "KS0108 LCD Controller" 

Re: [PATCH] auxdisplay: remove PARPORT dependency

[Andrew Morton]

(please cc the maintainers on patches)

On Fri, 6 Feb 2009 19:06:51 -0500
"hartleys" <hartleys@visionengravers.com> wrote:

> Remove PARPORT dependency for Auxiliary Display support.
> 
> This is not needed since the dependency for the KS0108 driver is
> PARPORT_PC.
> 

OK, but the patch also accidentally removes the parport dependency from
cfag12864b.c and cfag12864bfb.c.

A quick grep indicates that those drivers don't need parport, but I
didn't look very closely.

> 
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 14b9d5f..c07e725 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -6,7 +6,6 @@
>  #
>  
>  menuconfig AUXDISPLAY
> -	depends on PARPORT
>  	bool "Auxiliary Display support"
>  	---help---
>  	  Say Y here to get to see options for auxiliary display
> drivers.
> @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY
>  
>  	  If you say N, all options in this submenu will be skipped and
> disabled.
>  
> -if AUXDISPLAY && PARPORT
> +if AUXDISPLAY
>  
>  config KS0108
>  	tristate "KS0108 LCD Controller" 

Your email client wordwraps patches.  Please fix that up for next time.

RE: [PATCH] auxdisplay: remove PARPORT dependency

[hartleys]

On Monday, February 09, 2009 3:37 PM, Andrew Morton wrote:
> (please cc the maintainers on patches)

Sorry about missing that.  I wasn't sure how patches to Kconfig were
handled.

>> Remove PARPORT dependency for Auxiliary Display support.
>> 
>> This is not needed since the dependency for the KS0108 driver is 
>> PARPORT_PC.
>> 
>
> OK, but the patch also accidentally removes the parport dependency
> from cfag12864b.c and cfag12864bfb.c.
>
> A quick grep indicates that those drivers don't need parport, but I
> didn't look very closely.

I think the dependency will be handled automatically.  Both cfag12864b.c
and cfag12864bfb.c are enabled by CFAG12864B which has a dependency on
KS0108, which it turn depends on PARPORT_PC.

>> 
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig 
>> index 14b9d5f..c07e725 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -6,7 +6,6 @@
>>  #
>>  
>>  menuconfig AUXDISPLAY
>> -	depends on PARPORT
>>  	bool "Auxiliary Display support"
>>  	---help---
>>  	  Say Y here to get to see options for auxiliary display
drivers.
>> @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY
>>  
>>  	  If you say N, all options in this submenu will be skipped and 
>> disabled.
>>  
>> -if AUXDISPLAY && PARPORT
>> +if AUXDISPLAY
>>  
>>  config KS0108
>>  	tristate "KS0108 LCD Controller" 
>
> Your email client wordwraps patches.  Please fix that up for next
time.

Sorry about that also.  Do you have any idea how to correctly configure
Outlook to not mess with wordwraps?  I know, it's a stupid client, but's
that's what I'm stuck with here at work.  I've been beating my head with
it trying to get it to work correctly.

Re: [PATCH] auxdisplay: remove PARPORT dependency

[Miguel Ojeda]

On Mon, Feb 9, 2009 at 11:46 PM, hartleys <hartleys@visionengravers.com> wrote:
> On Monday, February 09, 2009 3:37 PM, Andrew Morton wrote:
>> (please cc the maintainers on patches)
>
> Sorry about missing that.  I wasn't sure how patches to Kconfig were
> handled.
>
>>> Remove PARPORT dependency for Auxiliary Display support.
>>>
>>> This is not needed since the dependency for the KS0108 driver is
>>> PARPORT_PC.
>>>
>>
>> OK, but the patch also accidentally removes the parport dependency
>> from cfag12864b.c and cfag12864bfb.c.
>>
>> A quick grep indicates that those drivers don't need parport, but I
>> didn't look very closely.
>
> I think the dependency will be handled automatically.  Both cfag12864b.c
> and cfag12864bfb.c are enabled by CFAG12864B which has a dependency on
> KS0108, which it turn depends on PARPORT_PC.

That's true; however, I think it is intentional: cfag12864bfb depends
on cfags12864b, and this one depends on ks0108, which depends on
parport and, for the moment, there aren't more entries on "Auxiliary
Display support". Thereafter, if PARPORT is not selected, the user is
not bothered with an additional menu entry on "Device Drivers".

I don't know which is the trend nowadays in this subject (i.e. to show
every menu althought empty or not). I see Andrew has already added the
patch, so I bet on his decision ;)

>
>>>
>>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>>> index 14b9d5f..c07e725 100644
>>> --- a/drivers/auxdisplay/Kconfig
>>> +++ b/drivers/auxdisplay/Kconfig
>>> @@ -6,7 +6,6 @@
>>>  #
>>>
>>>  menuconfig AUXDISPLAY
>>> -    depends on PARPORT
>>>      bool "Auxiliary Display support"
>>>      ---help---
>>>        Say Y here to get to see options for auxiliary display
> drivers.
>>> @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY
>>>
>>>        If you say N, all options in this submenu will be skipped and
>>> disabled.
>>>
>>> -if AUXDISPLAY && PARPORT
>>> +if AUXDISPLAY
>>>
>>>  config KS0108
>>>      tristate "KS0108 LCD Controller"
>>
>> Your email client wordwraps patches.  Please fix that up for next
> time.
>
> Sorry about that also.  Do you have any idea how to correctly configure
> Outlook to not mess with wordwraps?  I know, it's a stupid client, but's
> that's what I'm stuck with here at work.  I've been beating my head with
> it trying to get it to work correctly.
>
>

RE: [PATCH] auxdisplay: remove PARPORT dependency

[hartleys]

On Wednesday, February 11, 2009 3:38 AM, Miguel Ojeda wrote:
>> I think the dependency will be handled automatically.  Both
>> cfag12864b.c and cfag12864bfb.c are enabled by CFAG12864B which
>> has a dependency on KS0108, which it turn depends on PARPORT_PC.
>
> That's true; however, I think it is intentional: cfag12864bfb
> depends on cfags12864b, and this one depends on ks0108, which
> depends on parport and, for the moment, there aren't more entries
> on "Auxiliary Display support". Thereafter, if PARPORT is not
> selected, the user is not bothered with an additional menu entry
> on "Device Drivers".
>
> I don't know which is the trend nowadays in this subject (i.e. to
> show every menu althought empty or not). I see Andrew has already
> added the patch, so I bet on his decision ;)

The arm branch Kconfig was updated awhile back to include auxdisplay.

I have been messing with a couple LCD devices similar to the cfag12864.
Every time I update my kernel source I have needed to add this patch
since my arm platform does not have PARPORT_PC.

That was my stimulus for the patch.  It does cause the empty menu to
appear but some others already do that so I didn't think it was a
problem.

Regards,
Hartley